From patchwork Wed Nov 5 01:33:39 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 7274 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 7E4E4DDDF6 for ; Wed, 5 Nov 2008 12:34:18 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753752AbYKEBeR (ORCPT ); Tue, 4 Nov 2008 20:34:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753867AbYKEBeR (ORCPT ); Tue, 4 Nov 2008 20:34:17 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41888 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753752AbYKEBeO (ORCPT ); Tue, 4 Nov 2008 20:34:14 -0500 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id mA51Xd19005243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 4 Nov 2008 17:33:40 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id mA51XdGK018615; Tue, 4 Nov 2008 17:33:39 -0800 Message-Id: <200811050133.mA51XdGK018615@imap1.linux-foundation.org> Subject: + quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes.patch added to -mm tree To: mm-commits@vger.kernel.org Cc: akpm@linux-foundation.org, cmm@us.ibm.com, jack@ucw.cz, linux-ext4@vger.kernel.org From: akpm@linux-foundation.org Date: Tue, 04 Nov 2008 17:33:39 -0800 X-Spam-Status: No, hits=-2.871 required=5 tests=AWL,BAYES_00 X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org The patch titled quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes has been added to the -mm tree. Its filename is quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes From: Andrew Morton ERROR: code indent should use tabs where possible #193: FILE: fs/dquot.c:1279: + * re-enter the quota code and are already holding the mutex$ ERROR: code indent should use tabs where possible #194: FILE: fs/dquot.c:1280: + */$ WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #254: FILE: fs/dquot.c:2352: +EXPORT_SYMBOL(dquot_reserve_space); WARNING: line over 80 characters #274: FILE: include/linux/quota.h:295: + int (*reserve_space) (struct inode *, qsize_t, int); /* reserve quota for delayed block allocation */ total: 2 errors, 2 warnings, 244 lines checked ./patches/quota-add-reservation-support-for-delayed-block-allocation.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Cc: Jan Kara Cc: Mingming Cao Signed-off-by: Andrew Morton --- fs/dquot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN fs/dquot.c~quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes fs/dquot.c --- a/fs/dquot.c~quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes +++ a/fs/dquot.c @@ -1276,8 +1276,8 @@ int dquot_alloc_space(struct inode *inod /* * First test before acquiring mutex - solves deadlocks when we - * re-enter the quota code and are already holding the mutex - */ + * re-enter the quota code and are already holding the mutex + */ if (IS_NOQUOTA(inode)) { inode_add_bytes(inode, number); return ret;