diff mbox series

[v2] ext4: remove set but rewrite variables

Message ID 1621493752-36890-1-git-send-email-tiantao6@hisilicon.com
State Awaiting Upstream
Headers show
Series [v2] ext4: remove set but rewrite variables | expand

Commit Message

tiantao \(H\) May 20, 2021, 6:55 a.m. UTC 
In the ext4_dx_add_entry function, the at variable is assigned but will
reset just after “again:” label. So delete the unnecessary assignment.
this will not chang the logic.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Reviewed-by: Artem Blagodarenko <artem.blagodarenko@gmail.com>
---

v2: update the commit message.
---
 fs/ext4/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Theodore Ts'o June 17, 2021, 3:01 p.m. UTC | #1 
On Thu, May 20, 2021 at 02:55:52PM +0800, Tian Tao wrote:
> In the ext4_dx_add_entry function, the at variable is assigned but will
> reset just after “again:” label. So delete the unnecessary assignment.
> this will not chang the logic.
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Reviewed-by: Artem Blagodarenko <artem.blagodarenko@gmail.com>

Applied, thanks.

					- Ted
diff mbox series

Patch

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index afb9d05..18bbf15 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2497,7 +2497,7 @@  static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
 
 			/* Which index block gets the new entry? */
 			if (at - entries >= icount1) {
-				frame->at = at = at - entries - icount1 + entries2;
+				frame->at = at - entries - icount1 + entries2;
 				frame->entries = entries = entries2;
 				swap(frame->bh, bh2);
 			}