Message ID | 1387261599-24122-1-git-send-email-adilger@dilger.ca |
---|---|
State | Accepted, archived |
Headers | show |
On Mon, Dec 16, 2013 at 11:26:39PM -0700, Andreas Dilger wrote: > Since commit 5ad07acad if $TMP cannot hold large test filesystems > for resize testing the resize_test creates temporary test files > in the local working directory. Since it overrides TMPFILE locally > the calling program does not delete the generated file correctly. > > Delete the large $TMPFILE within resize_test if it passes, but leave > it for debugging if the test failed. > > Signed-off-by: Andreas Dilger <adilger@dilger.ca> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/scripts/resize_test b/tests/scripts/resize_test index 30532a5..6a8b0e9 100755 --- a/tests/scripts/resize_test +++ b/tests/scripts/resize_test @@ -149,6 +149,7 @@ then return 1 fi +rm $TMPFILE return 0 }
Since commit 5ad07acad if $TMP cannot hold large test filesystems for resize testing the resize_test creates temporary test files in the local working directory. Since it overrides TMPFILE locally the calling program does not delete the generated file correctly. Delete the large $TMPFILE within resize_test if it passes, but leave it for debugging if the test failed. Signed-off-by: Andreas Dilger <adilger@dilger.ca> --- tests/scripts/resize_test | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)