| Message ID | 1254135442-28755-1-git-send-email-bergwolf@gmail.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
On Mon, Sep 28, 2009 at 06:57:22PM +0800, Peng Tao wrote: > checker/* blkid_types.h ../libblkid.a ../libblkid_p.a \ > $(SMANPAGES) blkid > - -rmdir tests > + -rmdir --ignore-fail-on-non-empty tests > Sorry, NACK. This will blow up on systems that aren't using the GNU shellutils. The error is ignored, which is good enough. We can do something like this instead: @echo rmdir tests/tmp tests -@rmdir tests/tmp tests >& /dev/null If we really care, I suppose. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/lib/blkid/Makefile.in b/lib/blkid/Makefile.in index 9169226..618c0b2 100644 --- a/lib/blkid/Makefile.in +++ b/lib/blkid/Makefile.in @@ -181,7 +181,7 @@ clean:: tests/*.img results test_probe core profiled/* \ checker/* blkid_types.h ../libblkid.a ../libblkid_p.a \ $(SMANPAGES) blkid - -rmdir tests + -rmdir --ignore-fail-on-non-empty tests mostlyclean:: clean distclean:: clean
Otherwise, make clean returns the following error, which is missleading. rmdir tests rmdir: failed to remove `tests': Directory not empty make: [clean] Error 1 (ignored) Signed-off-by: Peng Tao <bergwolf@gmail.com> --- lib/blkid/Makefile.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)