Message ID | 20240229163011.16248-1-lhenriques@suse.de |
---|---|
Headers | show
Return-Path: <SRS0=13dD=KG=vger.kernel.org=linux-ext4+bounces-1437-patchwork-incoming=ozlabs.org@ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=eXtJ+IqM; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=L11vjaZV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=eXtJ+IqM; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=L11vjaZV; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org (client-ip=2404:9400:2221:ea00::3; helo=gandalf.ozlabs.org; envelope-from=srs0=13dd=kg=vger.kernel.org=linux-ext4+bounces-1437-patchwork-incoming=ozlabs.org@ozlabs.org; receiver=patchwork.ozlabs.org) Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Tlxb02LzPz1yX7 for <incoming@patchwork.ozlabs.org>; Fri, 1 Mar 2024 03:32:28 +1100 (AEDT) Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4Tlxb01sz6z4wb2 for <incoming@patchwork.ozlabs.org>; Fri, 1 Mar 2024 03:32:28 +1100 (AEDT) Received: by gandalf.ozlabs.org (Postfix) id 4Tlxb01qTxz4wbQ; Fri, 1 Mar 2024 03:32:28 +1100 (AEDT) Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: gandalf.ozlabs.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: gandalf.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=eXtJ+IqM; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=L11vjaZV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=eXtJ+IqM; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=L11vjaZV; dkim-atps=neutral Authentication-Results: gandalf.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45e3:2400::1; helo=sv.mirrors.kernel.org; envelope-from=linux-ext4+bounces-1437-patchwork-incoming=ozlabs.org@vger.kernel.org; receiver=ozlabs.org) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [IPv6:2604:1380:45e3:2400::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by gandalf.ozlabs.org (Postfix) with ESMTPS id 4TlxZz6f6Zz4wb2 for <patchwork-incoming@ozlabs.org>; Fri, 1 Mar 2024 03:32:27 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B0ABC28AF0D for <patchwork-incoming@ozlabs.org>; Thu, 29 Feb 2024 16:32:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2ED8F273FC; Thu, 29 Feb 2024 16:30:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="eXtJ+IqM"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="L11vjaZV"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="eXtJ+IqM"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="L11vjaZV" X-Original-To: linux-ext4@vger.kernel.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 374E9160651; Thu, 29 Feb 2024 16:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709224218; cv=none; b=LDrZSKp40jj6f+2+8uNX7eVr5fP47J+0pgl1FOqJ3QNE+y0kltHQZWuCaYNM2b1cRJyyY+mPJLkPf2Qmj+al+RlKEmZl0Dn8llvtOb1/+ElxNayGp5l9ZZWm4+BS+RhvL5KnnBq9A5+zU5mjmtWLAE68ga6oA3yxw6uov37U71k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709224218; c=relaxed/simple; bh=7lVefdRKuQZZ/rmSHRQj+gMhsbmZ1UvSbxylCoYLCSI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=U4zKup+hqHVZgajTUXYHkX/+7WpswdE5pjG77Web0B9OG7CtpCGwx8+jDqzXuKftBBq2j7FUgO6FkW8uxL0ao4wHj1bnGIY2HwNiopXYfJaawf1MjjNtxua2qHClBi8ixX9NST0dxAE/vyQHe1pAjS9gQ6eGhEDxF6YPOwh9Pzw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=eXtJ+IqM; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=L11vjaZV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=eXtJ+IqM; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=L11vjaZV; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0B4CA21F8F; Thu, 29 Feb 2024 16:30:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709224215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=f97jQf9rT96/WVP8/erEc6CgFevFY/2Sd34ERaaDVsE=; b=eXtJ+IqMp7YMYyfCsO2aN9wVkwyYE10+k0stGA5ny66SmwGchxX0UtN1YNXxwsEwYb/3VQ X333D26DNRJgr13plJo6TflVfS2+sYb/wFm7Wd01qYpwW2wMu4UAu7zwag5b4oP3sxxygI jqHtZeTKAo4AOOm0OV4YDivsV9oGPpQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709224215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=f97jQf9rT96/WVP8/erEc6CgFevFY/2Sd34ERaaDVsE=; b=L11vjaZVoANBzf2ktWepEddJbYkOJQpYJ1LzOBqZXle9IhZfA8OkS90ctDxvmcL8EX3f0f PZANm5iBGquwVyBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709224215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=f97jQf9rT96/WVP8/erEc6CgFevFY/2Sd34ERaaDVsE=; b=eXtJ+IqMp7YMYyfCsO2aN9wVkwyYE10+k0stGA5ny66SmwGchxX0UtN1YNXxwsEwYb/3VQ X333D26DNRJgr13plJo6TflVfS2+sYb/wFm7Wd01qYpwW2wMu4UAu7zwag5b4oP3sxxygI jqHtZeTKAo4AOOm0OV4YDivsV9oGPpQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709224215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=f97jQf9rT96/WVP8/erEc6CgFevFY/2Sd34ERaaDVsE=; b=L11vjaZVoANBzf2ktWepEddJbYkOJQpYJ1LzOBqZXle9IhZfA8OkS90ctDxvmcL8EX3f0f PZANm5iBGquwVyBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3ED9C13A4B; Thu, 29 Feb 2024 16:30:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id fwwgDBax4GU0PwAAD6G6ig (envelope-from <lhenriques@suse.de>); Thu, 29 Feb 2024 16:30:14 +0000 Received: from localhost (brahms.olymp [local]) by brahms.olymp (OpenSMTPD) with ESMTPA id c276250a; Thu, 29 Feb 2024 16:30:13 +0000 (UTC) From: Luis Henriques <lhenriques@suse.de> To: Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger.kernel@dilger.ca>, Alexander Viro <viro@zeniv.linux.org.uk>, Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>, Miklos Szeredi <miklos@szeredi.hu>, Amir Goldstein <amir73il@gmail.com> Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Henriques <lhenriques@suse.de> Subject: [PATCH 0/3] fs_parser: handle parameters that can be empty and don't have a value Date: Thu, 29 Feb 2024 16:30:07 +0000 Message-ID: <20240229163011.16248-1-lhenriques@suse.de> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: <linux-ext4.vger.kernel.org> List-Subscribe: <mailto:linux-ext4+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-ext4+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: *** X-Spam-Score: 3.70 X-Spamd-Result: default: False [3.70 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[4]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_TWELVE(0.00)[12]; MID_CONTAINS_FROM(1.00)[]; FREEMAIL_TO(0.00)[mit.edu,dilger.ca,zeniv.linux.org.uk,kernel.org,suse.cz,szeredi.hu,gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; BAYES_HAM(-0.00)[35.51%] X-Spam-Flag: NO |
Series |
fs_parser: handle parameters that can be empty and don't have a value
|
expand
|
> Unfortunately, the two filesystems that use this flag (ext4 and overlayfs) > aren't prepared to have the parameter value set to NULL. Patches #2 and #3 > fix this. Both ext4 and overlayfs define #define fsparam_string_empty(NAME, OPT) \ __fsparam(fs_param_is_string, NAME, OPT, fs_param_can_be_empty, NULL) Please add that to include/linux/fs_parser.h so that it can be used by both.
On 3/1/24 7:12 AM, Christian Brauner wrote: >> Unfortunately, the two filesystems that use this flag (ext4 and overlayfs) >> aren't prepared to have the parameter value set to NULL. Patches #2 and #3 >> fix this. > > Both ext4 and overlayfs define > > #define fsparam_string_empty(NAME, OPT) \ > __fsparam(fs_param_is_string, NAME, OPT, fs_param_can_be_empty, NULL) > > Please add that to include/linux/fs_parser.h so that it can be used by both. The f2fs conversion will also need this, so yes, it'd be nice to hoist it out of ext4 and overlayfs. -Eric