[0/2,v2] ext4: Fix crash when adding entry to corrupted directory

Message ID	20220518093143.20955-1-jack@suse.cz
Headers	show Return-Path: <SRS0=PmKW=V2=vger.kernel.org=linux-ext4-owner@ozlabs.org> From: Jan Kara <jack@suse.cz> To: Ted Tso <tytso@mit.edu> Cc: <linux-ext4@vger.kernel.org>, Jan Kara <jack@suse.cz> Subject: [PATCH 0/2 v2] ext4: Fix crash when adding entry to corrupted directory Date: Wed, 18 May 2022 11:33:27 +0200 Message-Id: <20220518093143.20955-1-jack@suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	ext4: Fix crash when adding entry to corrupted directory \| expand [0/2,v2] ext4: Fix crash when adding entry to corrupted directory [1/2] ext4: Verify dir block before splitting it [2/2] ext4: Avoid cycles in directory h-tree

Message ID

20220518093143.20955-1-jack@suse.cz

Headers

From: Jan Kara <jack@suse.cz>
To: Ted Tso <tytso@mit.edu>
Cc: <linux-ext4@vger.kernel.org>, Jan Kara <jack@suse.cz>
Subject: [PATCH 0/2 v2] ext4: Fix crash when adding entry to corrupted
 directory
Date: Wed, 18 May 2022 11:33:27 +0200
Message-Id: <20220518093143.20955-1-jack@suse.cz>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

ext4: Fix crash when adding entry to corrupted directory | expand

Message

Jan Kara May 18, 2022, 9:33 a.m. UTC

Hello,

two patches in this series try to fix a crash when adding directory entry to a
directory with corrupted h-tree. Since I don't have the filesystem image
causing the crash, I'm not sure what was the cause but the stacktrace suggests
we have corrupted one h-tree node while modifying another one so likely
there was a cycle created in the h-tree. This series checks for it and bails
out early.

Changes since v1:
* Fixed compilation error in the first patch (which got fixed in the second
  patch)
* Fixed stack corruption issue with largedir feature

								Honza

Previous versions:
Link: http://lore.kernel.org/r/20220428180355.15209-1-jack@suse.cz # v1