mbox series

[v4,0/8] e2fsck: add fast commit replay path

Message ID 20210122054504.1498532-1-user@harshads-520.kir.corp.google.com
Headers show
Series e2fsck: add fast commit replay path | expand

Message

harshad shirwadkar Jan. 22, 2021, 5:44 a.m. UTC
From: Harshad Shirwadkar <harshadshirwadkar@gmail.com>

This patch series consists of modified e2fsck fast commit replay
patches from the patch series "[PATCH v3 00/15] Fast commit changes
for e2fsprogs" sent on Jan 20, 2021
(https://patchwork.ozlabs.org/project/linux-ext4/list/?series=225577&state=*). All
the patches except fast commit recovery path were merged upstream. So,
this series contains only the fast commit replay patch changes.

Verified that all the regression tests pass:
367 tests succeeded     0 tests failed

New fast commit recovery test:
j_recover_fast_commit: ok

Changes Since V3:
----------------

- All the patches except the replay path were merged upstream. Thus,
  this version of the series is shorter than the V3 of the series and
  only contains the recovery path changes.

- Added errcode_to_errno() function to translate libe2fs errcode to
  standard linux error codes. As of now, we simply translate any
  errcode_t > 256 to -EFAULT and <= 256 to -errno. We also log the
  actual ext2fs error code to stderr along with function name and line
  number for debugging purpose.

- Consistent naming: renamed e2fsck replay path functions to have the
  following convention - all the ext4_* functions in the e2fsck fast
  commit replay path return standard linux style error codes while the
  functions starting with ext2fs_* return errcode_t error codes.

Harshad Shirwadkar (8):
  ext2fs: add new APIs needed for fast commits
  e2fsck: add function to rewrite extent tree
  e2fsck: add fast commit setup code
  e2fsck: add fast commit scan pass
  e2fsck: add fast commit replay skeleton
  e2fsck: add fc replay for link, unlink, creat tags
  e2fsck: add replay for add_range, del_range, and inode tags
  tests: add fast commit recovery tests

 e2fsck/e2fsck.h                      |  32 ++
 e2fsck/extents.c                     | 175 ++++---
 e2fsck/journal.c                     | 654 +++++++++++++++++++++++++++
 lib/ext2fs/ext2_fs.h                 |   1 +
 lib/ext2fs/ext2fs.h                  |   8 +
 lib/ext2fs/extent.c                  |  64 +++
 lib/ext2fs/unlink.c                  |   6 +-
 tests/j_recover_fast_commit/commands |   4 +
 tests/j_recover_fast_commit/expect   |  22 +
 tests/j_recover_fast_commit/image.gz | Bin 0 -> 3595 bytes
 tests/j_recover_fast_commit/script   |  26 ++
 11 files changed, 929 insertions(+), 63 deletions(-)
 create mode 100644 tests/j_recover_fast_commit/commands
 create mode 100644 tests/j_recover_fast_commit/expect
 create mode 100644 tests/j_recover_fast_commit/image.gz
 create mode 100755 tests/j_recover_fast_commit/script

Comments

Theodore Ts'o Jan. 27, 2021, 4:56 p.m. UTC | #1
On Thu, Jan 21, 2021 at 09:44:56PM -0800, Harshad Shirwadkar wrote:
> From: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
> 
> This patch series consists of modified e2fsck fast commit replay
> patches from the patch series "[PATCH v3 00/15] Fast commit changes
> for e2fsprogs" sent on Jan 20, 2021
> (https://patchwork.ozlabs.org/project/linux-ext4/list/?series=225577&state=*). All
> the patches except fast commit recovery path were merged upstream. So,
> this series contains only the fast commit replay patch changes.
> 
> Verified that all the regression tests pass:
> 367 tests succeeded     0 tests failed
> 
> New fast commit recovery test:
> j_recover_fast_commit: ok

I've applied this patch series, thanks!

						- Ted