diff mbox series

cifs: Do not include crypto/internal header files

Message ID aApTFgDKVzgS_HFZ@gondor.apana.org.au
State New
Headers show
Series cifs: Do not include crypto/internal header files | expand

Commit Message

Herbert Xu April 24, 2025, 3:04 p.m. UTC
Any files under crypto/internal should not be included by users
outside of the Crypto API.

Remove crypto/internal/hash.h from cifsglob.h and add crypto/hash.h
to the files where the hash API is actually used.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff mbox series

Patch

diff --git a/fs/smb/client/cifsencrypt.c b/fs/smb/client/cifsencrypt.c
index e69968e88fe7..dd143f6e629b 100644
--- a/fs/smb/client/cifsencrypt.c
+++ b/fs/smb/client/cifsencrypt.c
@@ -24,6 +24,7 @@ 
 #include <linux/iov_iter.h>
 #include "../common/arc4.h"
 #include <crypto/aead.h>
+#include <crypto/hash.h>
 
 static size_t cifs_shash_step(void *iter_base, size_t progress, size_t len,
 			      void *priv, void *priv2)
diff --git a/fs/smb/client/cifsglob.h b/fs/smb/client/cifsglob.h
index 07c4688ec4c9..167a42f190c5 100644
--- a/fs/smb/client/cifsglob.h
+++ b/fs/smb/client/cifsglob.h
@@ -22,7 +22,6 @@ 
 #include <linux/netfs.h>
 #include "cifs_fs_sb.h"
 #include "cifsacl.h"
-#include <crypto/internal/hash.h>
 #include <uapi/linux/cifs/cifs_mount.h>
 #include "../common/smb2pdu.h"
 #include "smb2pdu.h"
diff --git a/fs/smb/client/link.c b/fs/smb/client/link.c
index 769752ad2c5c..e13671869e0c 100644
--- a/fs/smb/client/link.c
+++ b/fs/smb/client/link.c
@@ -5,6 +5,7 @@ 
  *   Author(s): Steve French (sfrench@us.ibm.com)
  *
  */
+#include <crypto/hash.h>
 #include <linux/fs.h>
 #include <linux/stat.h>
 #include <linux/slab.h>
diff --git a/fs/smb/client/misc.c b/fs/smb/client/misc.c
index 7b6ed9b23e71..b283ed0f46e2 100644
--- a/fs/smb/client/misc.c
+++ b/fs/smb/client/misc.c
@@ -6,6 +6,7 @@ 
  *
  */
 
+#include <crypto/hash.h>
 #include <linux/slab.h>
 #include <linux/ctype.h>
 #include <linux/mempool.h>
diff --git a/fs/smb/client/smb2misc.c b/fs/smb/client/smb2misc.c
index cddf273c14ae..caf06548657d 100644
--- a/fs/smb/client/smb2misc.c
+++ b/fs/smb/client/smb2misc.c
@@ -7,6 +7,7 @@ 
  *              Pavel Shilovsky (pshilovsky@samba.org) 2012
  *
  */
+#include <crypto/hash.h>
 #include <linux/ctype.h>
 #include "cifsglob.h"
 #include "cifsproto.h"
diff --git a/fs/smb/client/smb2transport.c b/fs/smb/client/smb2transport.c
index 475b36c27f65..304370befcd4 100644
--- a/fs/smb/client/smb2transport.c
+++ b/fs/smb/client/smb2transport.c
@@ -19,6 +19,7 @@ 
 #include <linux/mempool.h>
 #include <linux/highmem.h>
 #include <crypto/aead.h>
+#include <crypto/hash.h>
 #include "cifsglob.h"
 #include "cifsproto.h"
 #include "smb2proto.h"