diff mbox series

[-next,V2] ksmbd: fix memory leak in smb2_lock()

Message ID 20231204012308.2964687-1-wozizhi@huawei.com
State New
Headers show
Series [-next,V2] ksmbd: fix memory leak in smb2_lock() | expand

Commit Message

Zizhi Wo Dec. 4, 2023, 1:23 a.m. UTC
In smb2_lock(), if setup_async_work() executes successfully,
work->cancel_argv will bind the argv that generated by kmalloc(). And
release_async_work() is called in ksmbd_conn_try_dequeue_request() or
smb2_lock() to release argv.
However, when setup_async_work function fails, work->cancel_argv has not
been bound to the argv, resulting in the previously allocated argv not
being released. Call kfree() to fix it.

Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
 fs/smb/server/smb2pdu.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series


diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 658209839729..67cbeb713f70 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -7078,6 +7078,7 @@  int smb2_lock(struct ksmbd_work *work)
 				if (rc) {
+					kfree(argv);
 					err = -ENOMEM;
 					goto out;