From patchwork Fri Jun 16 14:23:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?546L5piOLei9r+S7tuW6leWxguaKgOacr+mDqA==?= X-Patchwork-Id: 1795946 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=vivo.com header.i=@vivo.com header.a=rsa-sha256 header.s=selector2 header.b=A0295nrj; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4QjLy30Knzz20X8 for ; Sat, 17 Jun 2023 00:24:11 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229577AbjFPOYJ (ORCPT ); Fri, 16 Jun 2023 10:24:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjFPOYI (ORCPT ); Fri, 16 Jun 2023 10:24:08 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2137.outbound.protection.outlook.com [40.107.117.137]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B01530D3; Fri, 16 Jun 2023 07:24:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B1j5z4CUx9+RQ1TZiAva9Skc2Z1cHMUXIs7Xi2xcCNUbF3wsOdO1oD0qR8oUtkFq43xWRBsKu5KoVAf/7XvTax5SzodSbuL6JU3PYfKuv/RcLpiAZkd6vrSn3DSiGVDcYUChc6a/P7UT/mIV6G8ufeX+D1AWSiFD3C66eIjhC//IE5CyzoU7MAJkPr+Tkba4/T05zJ+3FyeobhcQ5KuCAt0PjZ7Yw8HBK74OiPh0p3H1VZDjMJ30bLJabsV3j4MJGEhgBs0DwOF5SYkV05OxCjoUFTJ1isdcZ8iRMExOHImfnC8TK760xEa/MEbzVHd7TMBtuVhidV2WD8PUaAFCxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OAjZHGH33o0T/Bxn4xjPISH0ZtWZfkGNYF55lq2QVLY=; b=RgP1rhp3WIMHPnr9K9TsuXTcPJayAznfsOqs/SQuKFn5vPJfwhMD/QTWqhUNJs/71kMgdsBJ7WBR7HXS69LS/d4gsQsp4UJSUKyIz/pxOTvm31bQYdFliYxN4gEMOAsq08YPGlmnZgM0pHbAOgG1EQbYR/DoiwWhcg3heSl8AanhiThwpXQoX+KSyNrz69cseRFPoT0DsdsYus6R5XriZ7wbaJYrEtoWbZpZAH8uNy5KS933Vo0D3c+aBFLw9cwSCK/+ytVEc5+o37+FyKrtEf96u0PoRVuldVLvUHfJwel6RIR7BfCMfaqpitK0xTAps6rlEKPqBietcrSydzaasA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OAjZHGH33o0T/Bxn4xjPISH0ZtWZfkGNYF55lq2QVLY=; b=A0295nrjZsotrepa4iECmDmsaF+9nerUy0XwCUjraI2H4l0Iaqklv3Omj6UE6ziGrImhNxl2fbUXubR3MYYvwpvou1ngQE9znI4q0SruqELNu1PIehKzAU7GEeqL3jpwszsmG4P1w6bwsemOif1BBRN/a8vgPdluE+aUMexqqReRwhv1mYQN2XfUZllImvti2pEXdmRMwBgglrrj2usCkHc9Dn/8/OwvlBOvi+JB0tRBale+tJ2iIeFnZUuCfcQFEVVCasSEDf29+2eQ0Rpl9lKH4Lg4T/0YGjnWhzgEKIMzdj+jyKPW/2dbnuTKfPVEaKBb6uL2AS6xh+SC5QrJRA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SG2PR06MB3743.apcprd06.prod.outlook.com (2603:1096:4:d0::18) by TYUPR06MB6098.apcprd06.prod.outlook.com (2603:1096:400:358::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.46; Fri, 16 Jun 2023 14:24:03 +0000 Received: from SG2PR06MB3743.apcprd06.prod.outlook.com ([fe80::7dfd:a3ed:33ca:9cc8]) by SG2PR06MB3743.apcprd06.prod.outlook.com ([fe80::7dfd:a3ed:33ca:9cc8%6]) with mapi id 15.20.6500.029; Fri, 16 Jun 2023 14:24:03 +0000 From: Wang Ming To: linkinjeon@kernel.org Cc: opensource.kernel@vivo.com, Wang Ming , Steve French , Sergey Senozhatsky , Tom Talpey , Stephen Rothwell , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] fs:smb:server:Fix unsigned compared with less than zero Date: Fri, 16 Jun 2023 22:23:04 +0800 Message-Id: <20230616142337.4656-1-machel@vivo.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SI1PR02CA0031.apcprd02.prod.outlook.com (2603:1096:4:1f6::11) To SG2PR06MB3743.apcprd06.prod.outlook.com (2603:1096:4:d0::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG2PR06MB3743:EE_|TYUPR06MB6098:EE_ X-MS-Office365-Filtering-Correlation-Id: 2195d473-fd7e-47fa-e0be-08db6e755571 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lZZCcjmRf9icI3MaihI1sWYxYft1LS7VgeeEOJfQea7LdwaPxB8GK29hKNC0i4T4B6EQ5eT8EYyjGtRNURp023apqd6gA3Vci9tRFAeKNNS1+HkAoqVRPyGghxb35oC1QnH9XviLlQFk91diqcje4p636qLu45BbaegcSYPJImey7f6Yti+Kp2d2lawGiQTJJdMTWbkQnxGt/kKCjFRwIDozkJ2mPnvA3pkflidqNRhQMyF/ADF9xh1O9ZkiVEuxnmIMd95jKUyP9wdHoL7eZoT2g9NjKW33LHzqRVmV4MknWY57bPV3ezE6HbkBJ+JL8FhPdDuY5f8lmQMZx680ayxjFd1H8cIC5Epb4MuwURlCfRe1fjYfw2tn8WLJ7pHYwzDl8KyJh9dHAsFhTZhe1zJkdA1EmwODO45Hb8Sdr2NlnaFte6JxAGiXx5eJRPVYVhDe5ZWntLZ5QCq0sSTEISi+q/tvW/CcVux3+VJQCHSMDdP/zOLJPvZApSaqH7y+/p8oDWKiGUDmu/P1x4p9hwmC2UcJI9olUo5YvlaeJjjzQavOm9PVCIOPrr1OGJiaV8l9ssiiQ73P6GP+dbgqYzf6Lt204M1ln1MFY5di7rI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SG2PR06MB3743.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(366004)(376002)(39860400002)(346002)(451199021)(5660300002)(52116002)(66556008)(2906002)(8936002)(8676002)(66946007)(6916009)(66476007)(54906003)(41300700001)(6486002)(4326008)(1076003)(26005)(6506007)(6512007)(186003)(316002)(83380400001)(38100700002)(2616005)(478600001)(86362001)(36756003)(38350700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kMbLFbefwAna/+pfMMbROVUSozyN0T7qCIYyPj12gy2WzF3xoirSotZtn2QJiQca4Ien6g3pY3SYHc+s6lQF7tU80NXcy2X+tL7cctCqZAAcLPwf0VhVh/hsF3dACvr2zbrHvebq2xgsPGn0Zn6rONbphATt91+i8g+RLVAqYqrhaa0ObFDSQRDwm/f5XQyNu//kuU1dNdj5WaKY68XfMapVbLENPsJ+P2nTxuIqy2vDNi5NaZj2MK2wPft1GlZ+u6gu9WGj1oC6RVCGnD4GOlieN8QJPm8hXEGphA0AwlaNivwiEHxK8Om+OSXahqmyX5hMFpKq9ilw2qXuZJeLiCKGXmDZLLZ6+q7lTvGKOXT9XN478tfY3d7LotHBL0dz9Xnx9BWQl2WCyAfcVGDC9JHo9p6voAWcofIQkfaRnxd+hLZ4QXK0YNh+9/Oqyeb+V3WD6r0m5OqQI/Yko2OFK+74pjn/1xPqYF3dGWZIOLZfkdg8XVzH+EiffJRsCXWok9TSqjpbQvxMnfk67jI6DnD+LkUvPxfJCePH6VIMuWC4P+DZ0DUf5TsGKjpn5FsFVMiPH40G0E2KILaFOidD/dfcSJtoqsJIgyE2MuCodg6A0fvbiK+yDeUy35QrXfeYfudPp4ezX+KpKb2sP1gPtMe1yIgLMfn7uZbb6aX2KDwDNSk1oku91rtzMJvor+J0lV8n/yv2ma8g9t/y1Jy9HRZufcq6u4AGczV8hPAXksRj4ko1Kv4fTpjh74DiwkZZGGb/x2E4UokU0x8dfnjSSm2i7ADjtkvK7YGJxru3p/YScNLKb5cx25ZgeWrKMGeJM9a1oj2KQO9CFq5jFVS7VjJ1gUrfaZHO2m2gFOAnA8UCbWu2lGV6h4cfslxaCJkusbAuSPRH1T1hMQoOnQZLQ09mfkSsN3Rr1Ijii9Q4kqHVsEbzabHZqn9buruSdRLXzHy4osKs2oYS0Wkxs+N0jbSrD5Ls1bQTMHW4v99coMSL36eAnTjsSOSXxrs13Hz6q1t40fnV+NXJrb5TfbIa4GOmuxBa84rcBGcbHABKOW3zj2+aTqwgZuX2eCsHB1yOWlwfuVABEI7BuzDrYqOF6AqKtqBQLdVkJbC3GzmVVnDom0pOhSlY92qrupbO9m7LYaCmuIj6vdNnm9iq3fbeV4Uk0UPq02+adI/H2pD2lT1nNQ2HQHWP8iphQKqzAFgVY8xmMgLD/+k19j4Q2PB3xXVXMXDE77bmD5bKPBWjiINTFOKyKo3h176J5EYcXZYoJ67KqDngucnpnBdTCFXP9ZuG6hEMh5VPasLlYndVDlDLpE1Bwjep7THHk62eGzqw241AOqS8VzXeCJbi+dLDMkZfw5VMY4PwXBr1Z4UkuvpzRhJV5SZ3fxxPUc91c/LPs2+/v6D9nNYKt2uaGfXvnBH/Xu2IDR39vgPFKUVIbc8iwkFav3uKn38zwbSki6GFSaywGuyIUm2oOfv4vKlyx2vqpq2o+6jnjeFTfko4Lo9UDfX8KQS7Cdpn+nh4gcxQtmLbyHLDnt4mCxVfQezQHvm4CWCnHvW8h9lNFTCCvIfhte410o6CDSL1g3r2h6vl X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2195d473-fd7e-47fa-e0be-08db6e755571 X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 14:24:03.1102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: glHAzKNgNt4vsgTCtWgrTcvaq7BQp13OmpTdBH9nUHY51a1gJ/0JCyqGZse3KT1RRq04IFx1/wNFKJqSJNpeCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6098 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org The return value of the ksmbd_vfs_getcasexattr() is long. However, the return value is being assigned to an unsignef long variable 'v_len',so making 'v_len' to long. silence the warning: ./fs/smb/server/vfs.c:WARNING: Unsigned expression compared with zero: v_len > 0 Signed-off-by: Wang Ming Fixes: 53ab6975c12d ("Add linux-next specific files for 20230609") --- This version adds 'Fixes:tag' compared to previous versions. fs/smb/server/vfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c index 23eb1da4b..272bcab1f 100644 --- a/fs/smb/server/vfs.c +++ b/fs/smb/server/vfs.c @@ -400,7 +400,8 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *fp, char *buf, loff_t *pos, { char *stream_buf = NULL, *wbuf; struct mnt_idmap *idmap = file_mnt_idmap(fp->filp); - size_t size, v_len; + size_t size; + ssize_t v_len; int err = 0; ksmbd_debug(VFS, "write stream data pos : %llu, count : %zd\n", @@ -417,9 +418,9 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *fp, char *buf, loff_t *pos, fp->stream.name, fp->stream.size, &stream_buf); - if ((int)v_len < 0) { + if (v_len < 0) { pr_err("not found stream in xattr : %zd\n", v_len); - err = (int)v_len; + err = v_len; goto out; }