diff mbox series

[1/2] cifs: print nosharesock value while dumping mount options

Message ID 20230616103746.87142-1-sprasad@microsoft.com
State New
Headers show
Series [1/2] cifs: print nosharesock value while dumping mount options | expand

Commit Message

Shyam Prasad N June 16, 2023, 10:37 a.m. UTC
We print most other mount options for a mount when dumping
the mount entries. But miss out the nosharesock value.
This change will print that in addition to the other options.

Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
---
 fs/smb/client/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Steve French June 16, 2023, 9:16 p.m. UTC | #1
merged into cifs-2.6.git for-next

Note that nosharesock was being printed before, but only in
/proc/fs/cifs/DebugData not in /proc/mounts



On Fri, Jun 16, 2023 at 5:37 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
>
> We print most other mount options for a mount when dumping
> the mount entries. But miss out the nosharesock value.
> This change will print that in addition to the other options.
>
> Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
> ---
>  fs/smb/client/cifsfs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
> index 43a4d8603db3..86ac620a9615 100644
> --- a/fs/smb/client/cifsfs.c
> +++ b/fs/smb/client/cifsfs.c
> @@ -688,6 +688,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
>                 seq_puts(s, ",noautotune");
>         if (tcon->ses->server->noblocksnd)
>                 seq_puts(s, ",noblocksend");
> +       if (tcon->ses->server->nosharesock)
> +               seq_puts(s, ",nosharesock");
>
>         if (tcon->snapshot_time)
>                 seq_printf(s, ",snapshot=%llu", tcon->snapshot_time);
> --
> 2.34.1
>


--
Thanks,

Steve
Bharath SM June 18, 2023, 5:04 p.m. UTC | #2
> On Fri, Jun 16, 2023 at 5:37 AM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> >
> > We print most other mount options for a mount when dumping
> > the mount entries. But miss out the nosharesock value.
> > This change will print that in addition to the other options.
> >
> > Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
> > ---
> >  fs/smb/client/cifsfs.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
> > index 43a4d8603db3..86ac620a9615 100644
> > --- a/fs/smb/client/cifsfs.c
> > +++ b/fs/smb/client/cifsfs.c
> > @@ -688,6 +688,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
> >                 seq_puts(s, ",noautotune");
> >         if (tcon->ses->server->noblocksnd)
> >                 seq_puts(s, ",noblocksend");
> > +       if (tcon->ses->server->nosharesock)
> > +               seq_puts(s, ",nosharesock");


Reviewed by Bharath.
diff mbox series

Patch

diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c
index 43a4d8603db3..86ac620a9615 100644
--- a/fs/smb/client/cifsfs.c
+++ b/fs/smb/client/cifsfs.c
@@ -688,6 +688,8 @@  cifs_show_options(struct seq_file *s, struct dentry *root)
 		seq_puts(s, ",noautotune");
 	if (tcon->ses->server->noblocksnd)
 		seq_puts(s, ",noblocksend");
+	if (tcon->ses->server->nosharesock)
+		seq_puts(s, ",nosharesock");
 
 	if (tcon->snapshot_time)
 		seq_printf(s, ",snapshot=%llu", tcon->snapshot_time);