diff mbox series

fs: smb: server: Replace the ternary conditional operator with min()

Message ID 20230609050636.27669-1-luhongfei@vivo.com
State New
Headers show
Series fs: smb: server: Replace the ternary conditional operator with min() | expand

Commit Message

Lu Hongfei June 9, 2023, 5:06 a.m. UTC 
It would be better to replace the traditional ternary conditional
operator with min() in compare_sids.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 fs/smb/server/smbacl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Namjae Jeon June 10, 2023, 2:40 p.m. UTC | #1 
2023-06-09 14:06 GMT+09:00, Lu Hongfei <luhongfei@vivo.com>:
> It would be better to replace the traditional ternary conditional
> operator with min() in compare_sids.
>
> Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>

Thanks for your patch!
diff mbox series

Patch

diff --git a/fs/smb/server/smbacl.c b/fs/smb/server/smbacl.c
index 0a5862a61c77..a93ae72fe4ef
--- a/fs/smb/server/smbacl.c
+++ b/fs/smb/server/smbacl.c
@@ -97,7 +97,7 @@  int compare_sids(const struct smb_sid *ctsid, const struct smb_sid *cwsid)
 	/* compare all of the subauth values if any */
 	num_sat = ctsid->num_subauth;
 	num_saw = cwsid->num_subauth;
-	num_subauth = num_sat < num_saw ? num_sat : num_saw;
+	num_subauth = min(num_sat, num_saw);
 	if (num_subauth) {
 		for (i = 0; i < num_subauth; ++i) {
 			if (ctsid->sub_auth[i] != cwsid->sub_auth[i]) {