diff mbox series

cifs-utils: fix probabilistic compiling error

Message ID 20200526035411.102588-1-lizhe67@huawei.com
State New
Headers show
Series cifs-utils: fix probabilistic compiling error | expand

Commit Message

Zhe Li May 26, 2020, 3:54 a.m. UTC
From: lizhe <lizhe67@huawei.com>

When we compile cifs-utils, we may probabilistic
encounter install error like:
cd ***/sbin && ln -sf mount.cifs mount.smb3
***/sbin: No such file or directory

The reason of this problem is that if we compile
cifs-utils using multithreading, target
'install-sbinPROGRAMS' may be built after
target 'install-exec-hook' of the main Makefile.
Target 'install-sbinPROGRAMS' will copy the
executable file 'mount.cifs' to the $(ROOTSBINDIR),
which target 'install-exec-hook' will do the
'ln' command on.

This patch add the dependency of target
'install-exec-hook' to ensure the correct order
of the compiling.

Signed-off-by: lizhe <lizhe67@huawei.com>
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pavel Shilovsky Aug. 29, 2020, 12:22 a.m. UTC | #1
Merged. Thanks!
--
Best regards,
Pavel Shilovsky

пн, 25 мая 2020 г. в 20:54, <lizhe67@huawei.com>:
>
> From: lizhe <lizhe67@huawei.com>
>
> When we compile cifs-utils, we may probabilistic
> encounter install error like:
> cd ***/sbin && ln -sf mount.cifs mount.smb3
> ***/sbin: No such file or directory
>
> The reason of this problem is that if we compile
> cifs-utils using multithreading, target
> 'install-sbinPROGRAMS' may be built after
> target 'install-exec-hook' of the main Makefile.
> Target 'install-sbinPROGRAMS' will copy the
> executable file 'mount.cifs' to the $(ROOTSBINDIR),
> which target 'install-exec-hook' will do the
> 'ln' command on.
>
> This patch add the dependency of target
> 'install-exec-hook' to ensure the correct order
> of the compiling.
>
> Signed-off-by: lizhe <lizhe67@huawei.com>
> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index fe9cd34..f0a69e9 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -118,7 +118,7 @@ endif
>
>  SUBDIRS = contrib
>
> -install-exec-hook:
> +install-exec-hook: install-sbinPROGRAMS
>         (cd $(ROOTSBINDIR) && ln -sf mount.cifs mount.smb3)
>
>  install-data-hook:
> --
> 2.12.3
>
>
diff mbox series

Patch

diff --git a/Makefile.am b/Makefile.am
index fe9cd34..f0a69e9 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -118,7 +118,7 @@  endif
 
 SUBDIRS = contrib
 
-install-exec-hook:
+install-exec-hook: install-sbinPROGRAMS
 	(cd $(ROOTSBINDIR) && ln -sf mount.cifs mount.smb3)
 
 install-data-hook: