From patchwork Tue Jun 1 14:54:51 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 54219 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.samba.org (fn.samba.org [216.83.154.106]) by ozlabs.org (Postfix) with ESMTP id 2C400B7D20 for ; Wed, 2 Jun 2010 00:55:11 +1000 (EST) Received: from fn.samba.org (localhost [127.0.0.1]) by lists.samba.org (Postfix) with ESMTP id 08DEAAD16A; Tue, 1 Jun 2010 08:55:11 -0600 (MDT) X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on fn.samba.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.8 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.2.5 X-Original-To: linux-cifs-client@lists.samba.org Delivered-To: linux-cifs-client@lists.samba.org Received: from cdptpa-omtalb.mail.rr.com (cdptpa-omtalb.mail.rr.com [75.180.132.120]) by lists.samba.org (Postfix) with ESMTP id 9D440AD08A for ; Tue, 1 Jun 2010 08:54:54 -0600 (MDT) X-Authority-Analysis: v=1.1 cv=ndvJlTMTg5nMognaPVD+zUGEYEmwQCx6obUm78I9Gww= c=1 sm=0 a=yWlxY3BjXxEA:10 a=1CvaPgNKC-EA:10 a=ld/erqUjW76FpBUqCqkKeA==:17 a=-TLGCcdKJbuzgiCRoxkA:9 a=i8pOAxV5Zw6BTLdDNf8A:7 a=vsFqbOb7EzwSuNGJaLm56fZ5FvcA:4 a=0kPLrQdw3YYA:10 a=ld/erqUjW76FpBUqCqkKeA==:117 X-Cloudmark-Score: 0 X-Originating-IP: 71.70.153.3 Received: from [71.70.153.3] ([71.70.153.3:56560] helo=mail.poochiereds.net) by cdptpa-oedge02.mail.rr.com (envelope-from ) (ecelerity 2.2.2.39 r()) with ESMTP id 22/37-01646-D3F150C4; Tue, 01 Jun 2010 14:54:53 +0000 Received: by mail.poochiereds.net (Postfix, from userid 4447) id B95EA580CB; Tue, 1 Jun 2010 10:54:52 -0400 (EDT) From: Jeff Layton To: smfrench@gmail.com Date: Tue, 1 Jun 2010 10:54:51 -0400 Message-Id: <1275404092-8400-8-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.6.6.1 In-Reply-To: <1275404092-8400-1-git-send-email-jlayton@redhat.com> References: <1275404092-8400-1-git-send-email-jlayton@redhat.com> Cc: linux-cifs-client@lists.samba.org Subject: [linux-cifs-client] [PATCH 7/8] cifs: don't ignore cifs_posix_open_inode_helper return value X-BeenThere: linux-cifs-client@lists.samba.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: The Linux CIFS VFS client List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-cifs-client-bounces@lists.samba.org Errors-To: linux-cifs-client-bounces@lists.samba.org From: Suresh Jayaraman ...and ensure that we propagate the error back to avoid any surprises. Signed-off-by: Suresh Jayaraman --- fs/cifs/file.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 5b9d1f2..02a2df9 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -277,8 +277,8 @@ int cifs_open(struct inode *inode, struct file *file) goto out; } - cifs_posix_open_inode_helper(inode, file, pCifsInode, - oplock, netfid); + rc = cifs_posix_open_inode_helper(inode, file, + pCifsInode, oplock, netfid); goto out; } else if ((rc == -EINVAL) || (rc == -EOPNOTSUPP)) { if (tcon->ses->serverNOS)