| Message ID | 20230117220041.15905-1-pc@cjr.nz |
|---|---|
| Headers | show |
| Series | dfs fixes | expand |
tentatively merged into cifs-2.6.git for-next pending more review/testing On Tue, Jan 17, 2023 at 4:00 PM Paulo Alcantara <pc@cjr.nz> wrote: > > Hi Steve, > > The most important fix is 1/5 that should fix those random hangs that > we've observed while running dfs tests on buildbot. > > I have run twice 50 dfs tests against Windows 2022 and samba 4.16 with > these mount options > > vers=3.1.1,echo_interval=10,{,hard} > vers=3.0,echo_interval=10,{,hard} > vers=3.0,echo_interval=10,{,sign} > vers=3.0,echo_interval=10,{,seal} > vers=2.1,echo_interval=10,{,hard} > vers=1.0,echo_interval=10,{,hard} > > The only tests which failed (2%) were with SMB1 UNIX extensions > against samba. readdir(2) was getting STATUS_INVALID_LEVEL from > QUERY_PATH_INFO after failover for some reason -- I'll look into that > when time allows. Those failures aren't related to this series, > though. > > I also did some quick tests with kerberos. > > --- > v1 -> v2: add comments in patch 1/5 as suggested by Aurelien > > Paulo Alcantara (5): > cifs: fix potential deadlock in cache_refresh_path() > cifs: avoid re-lookups in dfs_cache_find() > cifs: don't take exclusive lock for updating target hints > cifs: remove duplicate code in __refresh_tcon() > cifs: handle cache lookup errors different than -ENOENT > > fs/cifs/dfs_cache.c | 191 +++++++++++++++++++++++--------------------- > 1 file changed, 100 insertions(+), 91 deletions(-) > > -- > 2.39.0 >
Hi Steve, The most important fix is 1/5 that should fix those random hangs that we've observed while running dfs tests on buildbot. I have run twice 50 dfs tests against Windows 2022 and samba 4.16 with these mount options vers=3.1.1,echo_interval=10,{,hard} vers=3.0,echo_interval=10,{,hard} vers=3.0,echo_interval=10,{,sign} vers=3.0,echo_interval=10,{,seal} vers=2.1,echo_interval=10,{,hard} vers=1.0,echo_interval=10,{,hard} The only tests which failed (2%) were with SMB1 UNIX extensions against samba. readdir(2) was getting STATUS_INVALID_LEVEL from QUERY_PATH_INFO after failover for some reason -- I'll look into that when time allows. Those failures aren't related to this series, though. I also did some quick tests with kerberos. --- v1 -> v2: add comments in patch 1/5 as suggested by Aurelien Paulo Alcantara (5): cifs: fix potential deadlock in cache_refresh_path() cifs: avoid re-lookups in dfs_cache_find() cifs: don't take exclusive lock for updating target hints cifs: remove duplicate code in __refresh_tcon() cifs: handle cache lookup errors different than -ENOENT fs/cifs/dfs_cache.c | 191 +++++++++++++++++++++++--------------------- 1 file changed, 100 insertions(+), 91 deletions(-)