mbox series

[v8,0/3] Fix some bug in FSCTL_VALIDATE_NEGOTIATE_INFO handler

Message ID 20220926033631.926637-1-zhangxiaoxu5@huawei.com
Headers show
Series Fix some bug in FSCTL_VALIDATE_NEGOTIATE_INFO handler | expand

Message

zhangxiaoxu (A) Sept. 26, 2022, 3:36 a.m. UTC
v7->v8: update the commit message and smb2_ioctl just ensure the
	DialectCount in the payload.
v6->v7: squash 2 and 3; use helper function to get the dialect count
v5->v6: use 'static' for 'smbx_neg_dialects'
v4->v5: reorder the patch;
	add check in smb2_ioctl() to ensure no oob read to DialectCount
v3->v4: Fix the wrong sizeof validate_negotiate_info_req in ksmbd
v2->v3: refactor the dialects in struct validate_negotiate_info_req to
	variable array
v1->v2: fix some bug in ksmbd when handle FSCTL_VALIDATE_NEGOTIATE_INFO
	message

Zhang Xiaoxu (3):
  cifs: Fix the error length of VALIDATE_NEGOTIATE_INFO message
  ksmbd: Fix wrong return value and message length check in smb2_ioctl()
  cifs: Refactor dialects in validate_negotiate_info_req to variable
    array

 fs/cifs/smb2pdu.c         | 94 ++++++++++++++++++---------------------
 fs/ksmbd/smb2pdu.c        | 13 ++++--
 fs/smbfs_common/smb2pdu.h |  3 +-
 3 files changed, 54 insertions(+), 56 deletions(-)

Comments

Paulo Alcantara Oct. 4, 2022, 7:15 p.m. UTC | #1
Zhang Xiaoxu <zhangxiaoxu5@huawei.com> writes:

> v7->v8: update the commit message and smb2_ioctl just ensure the
> 	DialectCount in the payload.
> v6->v7: squash 2 and 3; use helper function to get the dialect count
> v5->v6: use 'static' for 'smbx_neg_dialects'
> v4->v5: reorder the patch;
> 	add check in smb2_ioctl() to ensure no oob read to DialectCount
> v3->v4: Fix the wrong sizeof validate_negotiate_info_req in ksmbd
> v2->v3: refactor the dialects in struct validate_negotiate_info_req to
> 	variable array
> v1->v2: fix some bug in ksmbd when handle FSCTL_VALIDATE_NEGOTIATE_INFO
> 	message
>
> Zhang Xiaoxu (3):
>   cifs: Fix the error length of VALIDATE_NEGOTIATE_INFO message
>   ksmbd: Fix wrong return value and message length check in smb2_ioctl()
>   cifs: Refactor dialects in validate_negotiate_info_req to variable
>     array
>
>  fs/cifs/smb2pdu.c         | 94 ++++++++++++++++++---------------------
>  fs/ksmbd/smb2pdu.c        | 13 ++++--
>  fs/smbfs_common/smb2pdu.h |  3 +-
>  3 files changed, 54 insertions(+), 56 deletions(-)

Acked-by: Paulo Alcantara (SUSE) <pc@cjr.nz>