mbox series

[0/7] dfs fixes

Message ID 20210604222533.4760-1-pc@cjr.nz
Headers show
Series dfs fixes | expand

Message

Paulo Alcantara June 4, 2021, 10:25 p.m. UTC
Hi Steve,

Follow a series with dfs fixes and improvements.

  - correctly handle different charsets when passing around DFS paths
    by converting them all to a default enconding in cache (utf8).

  - keep SMB sessions alive as long as dfs mounts are actives in order
    to refresh cached entries by using IPC tcons.

  - set a mininum of 2 minutes for refreshing cached entries

  - fix broken hash of case sensitive DFS paths

  - skip unnecessary tree disconnect of IPCs when shutting down SMB
    sessions (it didn't even work before).

  - do not share tcp servers when mounting dfs shares because they may
    failover to completely different targets (use nosharesock).

Paulo Alcantara (7):
  cifs: do not send tree disconnect to ipc shares
  cifs: get rid of @noreq param in __dfs_cache_find()
  cifs: keep referral server sessions alive
  cifs: handle different charsets in dfs cache
  cifs: fix path comparison and hash calc
  cifs: set a minimum of 2 minutes for refreshing dfs cache
  cifs: do not share tcp servers with dfs mounts

 fs/cifs/cifs_fs_sb.h |    7 +-
 fs/cifs/cifsglob.h   |    3 +-
 fs/cifs/connect.c    |  132 +++---
 fs/cifs/dfs_cache.c  | 1004 +++++++++++++++++-------------------------
 fs/cifs/dfs_cache.h  |   45 +-
 5 files changed, 498 insertions(+), 693 deletions(-)

Comments

Steve French June 5, 2021, 9:05 p.m. UTC | #1
Tentatively merged into for-next (pending testing and more review) six
of the 7 patches in the series - patch 5 wouldn't apply.

On Fri, Jun 4, 2021 at 5:25 PM Paulo Alcantara <pc@cjr.nz> wrote:
>
> Hi Steve,
>
> Follow a series with dfs fixes and improvements.
>
>   - correctly handle different charsets when passing around DFS paths
>     by converting them all to a default enconding in cache (utf8).
>
>   - keep SMB sessions alive as long as dfs mounts are actives in order
>     to refresh cached entries by using IPC tcons.
>
>   - set a mininum of 2 minutes for refreshing cached entries
>
>   - fix broken hash of case sensitive DFS paths
>
>   - skip unnecessary tree disconnect of IPCs when shutting down SMB
>     sessions (it didn't even work before).
>
>   - do not share tcp servers when mounting dfs shares because they may
>     failover to completely different targets (use nosharesock).
>
> Paulo Alcantara (7):
>   cifs: do not send tree disconnect to ipc shares
>   cifs: get rid of @noreq param in __dfs_cache_find()
>   cifs: keep referral server sessions alive
>   cifs: handle different charsets in dfs cache
>   cifs: fix path comparison and hash calc
>   cifs: set a minimum of 2 minutes for refreshing dfs cache
>   cifs: do not share tcp servers with dfs mounts
>
>  fs/cifs/cifs_fs_sb.h |    7 +-
>  fs/cifs/cifsglob.h   |    3 +-
>  fs/cifs/connect.c    |  132 +++---
>  fs/cifs/dfs_cache.c  | 1004 +++++++++++++++++-------------------------
>  fs/cifs/dfs_cache.h  |   45 +-
>  5 files changed, 498 insertions(+), 693 deletions(-)
>
> --
> 2.31.1
>