| Message ID | bd84df92640a05a1a73a8bc775b2d50568a9d0ec.1787239813.git.geert+renesas@glider.be |
|---|---|
| State | New |
| Headers | show |
| Series | clk: Make sure clk_init_data is fully initialized (part two) | expand |
On Fri, Aug 21, 2026 at 10:53 AM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Make sure all members are fully initialized, to avoid such bugs, and to > prevent future breakage when converting drivers to a different method > for specifying the parents. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> OK I trust you on this one: Acked-by: Linus Walleij <linusw@kernel.org> Yours, Linus Walleij
On Fri, Aug 21, 2026 at 11:04 AM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > Make sure all members are fully initialized, to avoid such bugs, and to > prevent future breakage when converting drivers to a different method > for specifying the parents. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Ulf Hansson <ulfh@kernel.org> Kind regards Uffe > --- > Compile-tested only. > --- > drivers/clk/ux500/clk-prcc.c | 2 +- > drivers/clk/ux500/clk-prcmu.c | 4 ++-- > drivers/clk/ux500/clk-sysctrl.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/ux500/clk-prcc.c b/drivers/clk/ux500/clk-prcc.c > index dce235df2576dfb2..dde72d2fd0ac67ae 100644 > --- a/drivers/clk/ux500/clk-prcc.c > +++ b/drivers/clk/ux500/clk-prcc.c > @@ -97,8 +97,8 @@ static struct clk *clk_reg_prcc(const char *name, > unsigned long flags, > const struct clk_ops *clk_prcc_ops) > { > + struct clk_init_data clk_prcc_init = {}; > struct clk_prcc *clk; > - struct clk_init_data clk_prcc_init; > struct clk *clk_reg; > > if (!name) { > diff --git a/drivers/clk/ux500/clk-prcmu.c b/drivers/clk/ux500/clk-prcmu.c > index ac96c46bd1bbf76b..d89f3b634f8bbd26 100644 > --- a/drivers/clk/ux500/clk-prcmu.c > +++ b/drivers/clk/ux500/clk-prcmu.c > @@ -200,8 +200,8 @@ static struct clk_hw *clk_reg_prcmu(const char *name, > unsigned long flags, > const struct clk_ops *clk_prcmu_ops) > { > + struct clk_init_data clk_prcmu_init = {}; > struct clk_prcmu *clk; > - struct clk_init_data clk_prcmu_init; > int ret; > > if (!name) { > @@ -357,8 +357,8 @@ struct clk_hw *clk_reg_prcmu_clkout(const char *name, > u8 source, u8 divider) > > { > + struct clk_init_data clk_prcmu_clkout_init = {}; > struct clk_prcmu_clkout *clk; > - struct clk_init_data clk_prcmu_clkout_init; > u8 clkout_id; > int ret; > > diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c > index ba3258c88d28e101..2127a949e56ccf27 100644 > --- a/drivers/clk/ux500/clk-sysctrl.c > +++ b/drivers/clk/ux500/clk-sysctrl.c > @@ -127,8 +127,8 @@ static struct clk *clk_reg_sysctrl(struct device *dev, > unsigned long flags, > const struct clk_ops *clk_sysctrl_ops) > { > + struct clk_init_data clk_sysctrl_init = {}; > struct clk_sysctrl *clk; > - struct clk_init_data clk_sysctrl_init; > struct clk *clk_reg; > int i; > > -- > 2.43.0 >
diff --git a/drivers/clk/ux500/clk-prcc.c b/drivers/clk/ux500/clk-prcc.c index dce235df2576dfb2..dde72d2fd0ac67ae 100644 --- a/drivers/clk/ux500/clk-prcc.c +++ b/drivers/clk/ux500/clk-prcc.c @@ -97,8 +97,8 @@ static struct clk *clk_reg_prcc(const char *name, unsigned long flags, const struct clk_ops *clk_prcc_ops) { + struct clk_init_data clk_prcc_init = {}; struct clk_prcc *clk; - struct clk_init_data clk_prcc_init; struct clk *clk_reg; if (!name) { diff --git a/drivers/clk/ux500/clk-prcmu.c b/drivers/clk/ux500/clk-prcmu.c index ac96c46bd1bbf76b..d89f3b634f8bbd26 100644 --- a/drivers/clk/ux500/clk-prcmu.c +++ b/drivers/clk/ux500/clk-prcmu.c @@ -200,8 +200,8 @@ static struct clk_hw *clk_reg_prcmu(const char *name, unsigned long flags, const struct clk_ops *clk_prcmu_ops) { + struct clk_init_data clk_prcmu_init = {}; struct clk_prcmu *clk; - struct clk_init_data clk_prcmu_init; int ret; if (!name) { @@ -357,8 +357,8 @@ struct clk_hw *clk_reg_prcmu_clkout(const char *name, u8 source, u8 divider) { + struct clk_init_data clk_prcmu_clkout_init = {}; struct clk_prcmu_clkout *clk; - struct clk_init_data clk_prcmu_clkout_init; u8 clkout_id; int ret; diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c index ba3258c88d28e101..2127a949e56ccf27 100644 --- a/drivers/clk/ux500/clk-sysctrl.c +++ b/drivers/clk/ux500/clk-sysctrl.c @@ -127,8 +127,8 @@ static struct clk *clk_reg_sysctrl(struct device *dev, unsigned long flags, const struct clk_ops *clk_sysctrl_ops) { + struct clk_init_data clk_sysctrl_init = {}; struct clk_sysctrl *clk; - struct clk_init_data clk_sysctrl_init; struct clk *clk_reg; int i;
The clk_init_data structure contains several mutually-exclusive members for different methods to specify the possible parents of a clock, prompting drivers to initialize only the members they need. However, not initializing all members may cause subtle issues, which are only exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is enabled. Make sure all members are fully initialized, to avoid such bugs, and to prevent future breakage when converting drivers to a different method for specifying the parents. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Compile-tested only. --- drivers/clk/ux500/clk-prcc.c | 2 +- drivers/clk/ux500/clk-prcmu.c | 4 ++-- drivers/clk/ux500/clk-sysctrl.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)