diff mbox series

[1/3] dt-bindings: phy: aspeed: Add ASPEED PCIe PHY

Message ID 20261008-aspeed_pcie_phy-v1-1-96764937aef0@aspeedtech.com
State New
Headers show
Series phy: aspeed: Add ASPEED PCIe PHY support | expand

Commit Message

Jacky Chou Oct. 8, 2026, 11:28 a.m. UTC
Introduce device-binding for ASPEED AST2600/2700 PCIe PHY.
The PHY provides the physical layer used by the PCIe
controller when operating in root complex mode.

Describe the compatible strings, register range, clocks and
phy-cells value required by the PHY provider.

Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
 .../bindings/phy/aspeed,ast2600-pcie-phy.yaml      | 49 ++++++++++++++++++++++
 1 file changed, 49 insertions(+)

Comments

Krzysztof Kozlowski Oct. 9, 2026, 10:31 a.m. UTC | #1
On Thu, Oct 08, 2026 at 07:28:19PM +0800, Jacky Chou wrote:
> Introduce device-binding for ASPEED AST2600/2700 PCIe PHY.
> The PHY provides the physical layer used by the PCIe
> controller when operating in root complex mode.
> 
> Describe the compatible strings, register range, clocks and
> phy-cells value required by the PHY provider.
> 
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
>  .../bindings/phy/aspeed,ast2600-pcie-phy.yaml      | 49 ++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/aspeed,ast2600-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/aspeed,ast2600-pcie-phy.yaml
> new file mode 100644
> index 000000000000..686b2e3d9457
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/aspeed,ast2600-pcie-phy.yaml

What? v9 here:
https://lore.kernel.org/all/20260115-upstream_pcie_rc-v9-1-d6c82a1556a7@aspeedtech.com/
from the same person, reviewed, but you ask us to do the same work
second time? Really?

Best regards,
Krzysztof
Jacky Chou Oct. 13, 2026, 5:41 a.m. UTC | #2
Hi Krzysztof

Thank you for your reply.

> > Introduce device-binding for ASPEED AST2600/2700 PCIe PHY.
> > The PHY provides the physical layer used by the PCIe controller when
> > operating in root complex mode.
> >
> > Describe the compatible strings, register range, clocks and phy-cells
> > value required by the PHY provider.
> >
> > Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> > ---
> >  .../bindings/phy/aspeed,ast2600-pcie-phy.yaml      | 49
> ++++++++++++++++++++++
> >  1 file changed, 49 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/phy/aspeed,ast2600-pcie-phy.yaml
> > b/Documentation/devicetree/bindings/phy/aspeed,ast2600-pcie-phy.yaml
> > new file mode 100644
> > index 000000000000..686b2e3d9457
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/aspeed,ast2600-pcie-phy.ya
> > +++ ml
> 
> What? v9 here:
> https://lore.kernel.org/all/20260115-upstream_pcie_rc-v9-1-d6c82a1556a7@a
> speedtech.com/
> from the same person, reviewed, but you ask us to do the same work second
> time? Really?
> 

I'm sorry again for the confusion caused by this submission and for asking reviewers 
to review work that had already been reviewed.

I plan to update this YAML binding in v10. Since the previous version received your 
Reviewed-by tag, could you please clarify what kinds of changes would require me to 
drop the tag and request a fresh review?
I'll document any changes to the binding in the cover letter's changelog.

Thanks,
Jacky
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/aspeed,ast2600-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/aspeed,ast2600-pcie-phy.yaml
new file mode 100644
index 000000000000..686b2e3d9457
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/aspeed,ast2600-pcie-phy.yaml
@@ -0,0 +1,49 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/aspeed,ast2600-pcie-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ASPEED PCIe PHY
+
+maintainers:
+  - Jacky Chou <jacky_chou@aspeedtech.com>
+
+description:
+  The ASPEED PCIe PHY provides the physical layer functionality for PCIe
+  controllers in the SoC.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - aspeed,ast2600-pcie-phy
+          - aspeed,ast2700-pcie-phy
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+    description:
+      Fixed 100MHz reference clock provided on the board.
+
+  "#phy-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    phy@1e6ed200 {
+      compatible = "aspeed,ast2600-pcie-phy";
+      reg = <0x1e6ed200 0x100>;
+      clocks = <&pcie_refclk>;
+      #phy-cells = <0>;
+    };