| Message ID | 20261001-ast27xx-adc-upstream-v2-1-2f9c15cc0064@aspeedtech.com |
|---|---|
| State | New |
| Headers | show |
| Series | iio: adc: aspeed: Fix SCU lookup for multi-SCU AST2700 | expand |
On Thu, Oct 01, 2026 at 05:50:36PM +0800, Billy Tsai wrote: > The ADC's reference-voltage trimming data lives in a System Control > Unit (SCU) register. SoCs with a single SCU instance let the driver > locate it without any additional information, but SoCs such as AST2700 > that expose more than one SCU node need an explicit phandle to > disambiguate which one holds the trimming data. > > Add an "aspeed,trim-syscon" phandle property, and require it for the > AST2700 compatibles since they are the first multi-SCU SoCs supported > by this driver. > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > Assisted-by: Claude:claude-sonnet-5 Your SoB is the last one. With this fixed: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Best regards, Krzysztof
On Fri, 2 Oct 2026 11:03:33 +0200 Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Thu, Oct 01, 2026 at 05:50:36PM +0800, Billy Tsai wrote: > > The ADC's reference-voltage trimming data lives in a System Control > > Unit (SCU) register. SoCs with a single SCU instance let the driver > > locate it without any additional information, but SoCs such as AST2700 > > that expose more than one SCU node need an explicit phandle to > > disambiguate which one holds the trimming data. > > > > Add an "aspeed,trim-syscon" phandle property, and require it for the > > AST2700 compatibles since they are the first multi-SCU SoCs supported > > by this driver. > > > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > > Assisted-by: Claude:claude-sonnet-5 > > Your SoB is the last one. > And the Assisted-by should have just "LLM" instead of "Claude:claude-sonnet-5".
diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed,ast2600-adc.yaml b/Documentation/devicetree/bindings/iio/adc/aspeed,ast2600-adc.yaml index 249101b55cf4e..140d7034e2196 100644 --- a/Documentation/devicetree/bindings/iio/adc/aspeed,ast2600-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/aspeed,ast2600-adc.yaml @@ -67,6 +67,11 @@ properties: description: Inform the driver that last channel will be used to sensor battery. + aspeed,trim-syscon: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the SCU holding the ADC's reference-voltage trimming data. + required: - compatible - reg @@ -74,6 +79,18 @@ required: - resets - "#io-channel-cells" +allOf: + - if: + properties: + compatible: + contains: + enum: + - aspeed,ast2700-adc0 + - aspeed,ast2700-adc1 + then: + required: + - aspeed,trim-syscon + additionalProperties: false examples:
The ADC's reference-voltage trimming data lives in a System Control Unit (SCU) register. SoCs with a single SCU instance let the driver locate it without any additional information, but SoCs such as AST2700 that expose more than one SCU node need an explicit phandle to disambiguate which one holds the trimming data. Add an "aspeed,trim-syscon" phandle property, and require it for the AST2700 compatibles since they are the first multi-SCU SoCs supported by this driver. Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> Assisted-by: Claude:claude-sonnet-5 --- .../devicetree/bindings/iio/adc/aspeed,ast2600-adc.yaml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)