| Message ID | 20230201103359.1742140-2-ryan_chen@aspeedtech.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add ASPEED AST2600 I2C new controller driver | expand |
Hi Ryan, > AST2600 I2C global register controller, add bindings document > to support driver of i2c global register set. [...] > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# Are you sure about this? This particular binding doesn't describe the i2c controller. > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-i2c-global > + > + reg: > + minItems: 1 > + items: > + - description: address offset and range of bus > + - description: address offset and range of bus buffer Seems to be a duplicate here. Cheers, Jeremy
Hello Jeremy > > > AST2600 I2C global register controller, add bindings document to > > support driver of i2c global register set. > > [...] > > > +allOf: > > + - $ref: /schemas/i2c/i2c-controller.yaml# > > Are you sure about this? This particular binding doesn't describe the i2c > controller. Due to this is i2c driver global register setting. I think I will remove this ref: But instead add description for understanding. Is it ok? > > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2600-i2c-global > > + > > + reg: > > + minItems: 1 > > + items: > > + - description: address offset and range of bus > > + - description: address offset and range of bus buffer > > Seems to be a duplicate here. > The same, will remove items, keep minItems:1. Thanks Ryan > > > Jeremy
On 01/02/2023 11:33, Ryan Chen wrote: > AST2600 I2C global register controller, add bindings document > to support driver of i2c global register set. > > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> > --- > .../i2c/aspeed,i2c-ast2600-global.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml > new file mode 100644 > index 000000000000..d92a0878d03b > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/aspeed,i2c-ast2600-global.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AST2600 I2C Global Register on the AST26XX SoCs Device Tree Bindings Drop "Device Tree Bindings" > + > +maintainers: > + - Ryan Chen <ryan_chen@aspeedtech.com> > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-i2c-global Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). I'll stop review till you test the patches before sending. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml new file mode 100644 index 000000000000..d92a0878d03b --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i2c/aspeed,i2c-ast2600-global.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: AST2600 I2C Global Register on the AST26XX SoCs Device Tree Bindings + +maintainers: + - Ryan Chen <ryan_chen@aspeedtech.com> + +allOf: + - $ref: /schemas/i2c/i2c-controller.yaml# + +properties: + compatible: + enum: + - aspeed,ast2600-i2c-global + + reg: + minItems: 1 + items: + - description: address offset and range of bus + - description: address offset and range of bus buffer + + resets: + maxItems: 1 + +required: + - reg + - compatible + - resets + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/ast2600-clock.h> + + i2c_gr: i2c-global-regs@0 { + compatible = "aspeed,ast2600-i2c-global", "syscon"; + reg = <0x0 0x20>; + resets = <&syscon ASPEED_RESET_I2C>; + };
AST2600 I2C global register controller, add bindings document to support driver of i2c global register set. Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com> --- .../i2c/aspeed,i2c-ast2600-global.yaml | 44 +++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml