Message ID | 20220529104928.79636-7-krzysztof.kozlowski@linaro.org |
---|---|
State | Handled Elsewhere, archived |
Headers | show |
Series | [1/7] dt-bindings: vendor-prefixes: document several vendors for Aspeed BMC boards | expand |
On Sun, 29 May 2022 12:49:28 +0200, Krzysztof Kozlowski wrote: > "qualcomm" is not a documented compatible and instead "qcom" should be > used. > > Applied, thanks! [7/7] ARM: dts: aspeed: centriq2400: use qcom compatible https://git.kernel.org/krzk/linux/c/6202c6063145cf9ec22b40aac219122dd702a10f Best regards,
On Wed, 22 Jun 2022 at 10:17, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On Sun, 29 May 2022 12:49:28 +0200, Krzysztof Kozlowski wrote: > > "qualcomm" is not a documented compatible and instead "qcom" should be > > used. > > > > > > Applied, thanks! What tree did you apply this to? Did you get review from the maintainer? This board is unmaintained and unused. I would prefer it removed rather than meaningless fixes be applied. > > [7/7] ARM: dts: aspeed: centriq2400: use qcom compatible > https://git.kernel.org/krzk/linux/c/6202c6063145cf9ec22b40aac219122dd702a10f > > Best regards, > -- > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
On 23/06/2022 07:34, Joel Stanley wrote: > On Wed, 22 Jun 2022 at 10:17, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On Sun, 29 May 2022 12:49:28 +0200, Krzysztof Kozlowski wrote: >>> "qualcomm" is not a documented compatible and instead "qcom" should be >>> used. >>> >>> >> >> Applied, thanks! > > What tree did you apply this to? Did you get review from the maintainer? Tree was mentioned below. > > This board is unmaintained and unused. I would prefer it removed > rather than meaningless fixes be applied. I can drop the patch. I'll send the patch to remove the board. > >> >> [7/7] ARM: dts: aspeed: centriq2400: use qcom compatible >> https://git.kernel.org/krzk/linux/c/6202c6063145cf9ec22b40aac219122dd702a10f >> >> Best regards, >> -- >> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 23/06/2022 09:05, Krzysztof Kozlowski wrote: > On 23/06/2022 07:34, Joel Stanley wrote: >> On Wed, 22 Jun 2022 at 10:17, Krzysztof Kozlowski >> <krzysztof.kozlowski@linaro.org> wrote: >>> >>> On Sun, 29 May 2022 12:49:28 +0200, Krzysztof Kozlowski wrote: >>>> "qualcomm" is not a documented compatible and instead "qcom" should be >>>> used. >>>> >>>> >>> >>> Applied, thanks! >> >> What tree did you apply this to? Did you get review from the maintainer? > > Tree was mentioned below. > >> >> This board is unmaintained and unused. I would prefer it removed >> rather than meaningless fixes be applied. > > I can drop the patch. I'll send the patch to remove the board. Does your answer also means that you are planning to take these? I am going to prepare a pull request to arm-soc so need to know whether to keep these or not. I don't have any particular need of handling these patches by myself, but I want the issues to get fixed. Best regards, Krzysztof
On Sun, 29 May 2022, at 20:19, Krzysztof Kozlowski wrote: > "qualcomm" is not a documented compatible and instead "qcom" should be > used. > > Fixes: 3719a1b13056 ("ARM: dts: aspeed: Add Qualcomm Centriq 2400 REP BMC") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Andrew Jeffery <andrew@aj.id.au>
diff --git a/arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts b/arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts index 3395de96ee11..2e8b87783717 100644 --- a/arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts +++ b/arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts @@ -6,7 +6,7 @@ / { model = "Qualcomm Centriq 2400 REP AST2520"; - compatible = "qualcomm,centriq2400-rep-bmc", "aspeed,ast2500"; + compatible = "qcom,centriq2400-rep-bmc", "aspeed,ast2500"; chosen { stdout-path = &uart5;
"qualcomm" is not a documented compatible and instead "qcom" should be used. Fixes: 3719a1b13056 ("ARM: dts: aspeed: Add Qualcomm Centriq 2400 REP BMC") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)