From patchwork Tue May 8 09:39:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lei YU X-Patchwork-Id: 910078 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40gDwr6pblz9s2k for ; Tue, 8 May 2018 19:39:56 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qv2Pd9lc"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 40gDwr46HVzF1x0 for ; Tue, 8 May 2018 19:39:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qv2Pd9lc"; dkim-atps=neutral X-Original-To: linux-aspeed@lists.ozlabs.org Delivered-To: linux-aspeed@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c01::241; helo=mail-pl0-x241.google.com; envelope-from=mine260309@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qv2Pd9lc"; dkim-atps=neutral Received: from mail-pl0-x241.google.com (mail-pl0-x241.google.com [IPv6:2607:f8b0:400e:c01::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40gDwk6FqSzF1vG for ; Tue, 8 May 2018 19:39:50 +1000 (AEST) Received: by mail-pl0-x241.google.com with SMTP id q18-v6so1902115plr.6 for ; Tue, 08 May 2018 02:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=0ZGdspDLHhPxAuWryLKniB35zER57Q111An0q+sGuME=; b=qv2Pd9lcN7QOeJlql4ZZTh8vpMkLkqxjxcbBgElHz/rqbQpUSMtZ/3NA0iC2V2VfPd iapEqCNLMAvUti2zFZsXyC6GHXpJQfVIb9POeJFOlcySeByYPnf/jx7xWVjQdxRd6w1Y 183N3RFx/WTaAMfQPnU2pP+cGBGjnFBG/hpv0xJCbzQtX7W94gtZhl94jFqyH3BEUQ1K XoUxRik6sYjsc0TOt9B6dT44s7F2eQcXclIb97LRsYIa3kBD6K9b/db3MdwXjU62n9hQ AZKznzbu8lv9EBHeVeAUY+0fl6AlSg/7H2wZ5HfaRJjLk6YB/s/9PJDZDAsSrBaRdf+o oQcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0ZGdspDLHhPxAuWryLKniB35zER57Q111An0q+sGuME=; b=R68KWRQ4XY2R9SkQuTHzo5u2QbCmUVMJ0lxz6ZK9wkrQ9QpHW8qvsoZQNJSznkFOl/ C89oBC61uz/z7YuETSrBYJAqi6+wNrZl3t9EFhMSrVnaywFsuAxjXm0NM5PuwS5E6k/N Ku6dBG8xfvtICcoiovFRwITxbJFfMn7EbLEUxftFzEEX024RKaxJCvdHL4NQT7MQD/g2 l9DS8i0vH2DG/FWZa0tj5M2vo5wFwKWJwTb+aoYc+PK09+xxpNIa9TtF1lHplaUGEE1b jJz2e073xi+eolT7y6mkfWpuwaYpfqSboc7vIWNUVkeO+9Pap9e2GIHqdunnKxJUGYbF W81w== X-Gm-Message-State: ALQs6tDBoqe4vOomSBirNS3dLWvvCbMrykLnNSBFHT5gk1o3bQZEHnap BScxUv7dW/LAMhDV6IDlpK0= X-Google-Smtp-Source: AB8JxZprBByuq6z7wdbhHJts89xIm5IYxkkC0A4HbpHH1bOffrRRmdFZ0epnOnkvAkJHuRNbm7N+Lw== X-Received: by 2002:a17:902:7685:: with SMTP id m5-v6mr9460751pll.340.1525772388708; Tue, 08 May 2018 02:39:48 -0700 (PDT) Received: from localhost (45.62.100.246.16clouds.com. [45.62.100.246]) by smtp.gmail.com with ESMTPSA id u9sm49163851pfj.10.2018.05.08.02.39.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 02:39:47 -0700 (PDT) From: Lei YU To: Jean Delvare , Guenter Roeck , Joel Stanley , Andrew Jeffery , linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: (aspeed-pwm-tacho) Use 24MHz clock Date: Tue, 8 May 2018 17:39:27 +0800 Message-Id: <1525772367-20627-1-git-send-email-mine260309@gmail.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: linux-aspeed@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux ASPEED SoC development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lei YU Errors-To: linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linux-aspeed" The clock source for aspeed pwm is set to 24MHz, so use the hard-coded clock frequency instead of the one in device tree. Otherwise, in case of the clock specified in device tree is not 24MHz, the fan speed will be incorrect. Signed-off-by: Lei YU --- drivers/hwmon/aspeed-pwm-tacho.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c index 693a3d5..e83b8df 100644 --- a/drivers/hwmon/aspeed-pwm-tacho.c +++ b/drivers/hwmon/aspeed-pwm-tacho.c @@ -922,7 +922,6 @@ static int aspeed_pwm_tacho_probe(struct platform_device *pdev) void __iomem *regs; struct resource *res; struct device *hwmon; - struct clk *clk; int ret; np = dev->of_node; @@ -956,12 +955,10 @@ static int aspeed_pwm_tacho_probe(struct platform_device *pdev) regmap_write(priv->regmap, ASPEED_PTCR_TACH_SOURCE, 0); regmap_write(priv->regmap, ASPEED_PTCR_TACH_SOURCE_EXT, 0); - clk = devm_clk_get(dev, NULL); - if (IS_ERR(clk)) - return -ENODEV; - priv->clk_freq = clk_get_rate(clk); aspeed_set_clock_enable(priv->regmap, true); + // The clock source is set to 24MHz aspeed_set_clock_source(priv->regmap, 0); + priv->clk_freq = 24000000; aspeed_create_type(priv);