From patchwork Tue Nov 28 07:52:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quan Nguyen X-Patchwork-Id: 1869146 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.a=rsa-sha256 header.s=selector2 header.b=Ai0FHtEi; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SfZT32n8Tz1yST for ; Tue, 28 Nov 2023 18:53:27 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.a=rsa-sha256 header.s=selector2 header.b=Ai0FHtEi; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SfZT216chz3cLY for ; Tue, 28 Nov 2023 18:53:26 +1100 (AEDT) X-Original-To: linux-aspeed@lists.ozlabs.org Delivered-To: linux-aspeed@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.a=rsa-sha256 header.s=selector2 header.b=Ai0FHtEi; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=os.amperecomputing.com (client-ip=2a01:111:f400:fe5a::71e; helo=nam12-mw2-obe.outbound.protection.outlook.com; envelope-from=quan@os.amperecomputing.com; receiver=lists.ozlabs.org) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2071e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5a::71e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SfZSx5m3Xz3bPM; Tue, 28 Nov 2023 18:53:20 +1100 (AEDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+kr8gDrY7qUeyVN5W6kx/WjHkk63Y+2bc7iL1yxxeVyG+Qm7YTyXe98H/6cDw6VNyxE7qYtg4qzIUCt3j5QQ4n9r4053LWoVFHmhWfWcGpebJfZhqLavkhB/E5exPo9APDD8atUOGwuXOj5QxBgGq45xkFUUdlmteg1dcMpTaTiij64v8gS4iC2lSHwLzqOR1xz6hUETCX11fGdh9eagSxIPoFiJfVcxB+HCR8ybUzAb5yUHfx2KGDYwGOBTILpjukrHDiOpjdTofXU7UDqyjvtJh+zEIkgMgUHiYK2JUAWw/owhFX77ulf4EI1dGTjFoADxnSmb8ICqbYIsI46iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ANZo0Yh6FASvCQick53ES7L5DfKDyCL1c9XKLCL5jPA=; b=FXfc/7QPgdqhjqHdf3R3IMbKterScAq0c53tFWcfI2a8FEWrVjr3bptJ14iTylyG+peou3x4oK7E7RBvRcaRkBbfKSoNXJtlcnKXWkvPxYEqZfeyzPTtc/wmdUyZbA1hHvOJl5+zL46prj7X6ACtIHOqENeOErbDzGxQdxzcuiRhCiPsczL7IvCkNdsP8HEld8++nAGoqXz7vIa2/phmyWxg1Q1TYYe466uULtyq3IAqjW6YMtQKCc57yWXFn6G+r3HMs9lFYNZitjt1eCd7u4RZqp0e9sfK5lfjaYjaDu772oukLctIGeJVi6UQSrMV0eC0/ghXF0Z7ckyHTgJkeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ANZo0Yh6FASvCQick53ES7L5DfKDyCL1c9XKLCL5jPA=; b=Ai0FHtEizM4aujCmScGJcA3B410IdKTdZsdkr2EeSHQlbqBjT7dM99lq7oIjMBf66J1jz5xmbcXXagO0N0nyImWdC5AUUmHfSktYzmDgHaZCTAGgF6Q63hOmzC8QOjL6XSWx32w5GYlQpJzqWmXR8iI/90hCChcj8CFQ0YGj0uU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SN4PR01MB7455.prod.exchangelabs.com (2603:10b6:806:202::11) by PH0PR01MB7895.prod.exchangelabs.com (2603:10b6:510:28a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Tue, 28 Nov 2023 07:52:58 +0000 Received: from SN4PR01MB7455.prod.exchangelabs.com ([fe80::5682:1d84:171a:1d68]) by SN4PR01MB7455.prod.exchangelabs.com ([fe80::5682:1d84:171a:1d68%3]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 07:52:58 +0000 From: Quan Nguyen To: Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Andi Shyti , Andrew Jeffery , Wolfram Sang , Jae Hyun Yoo , Guenter Roeck , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 RESEND 0/2] i2c: aspeed: Late ack Tx done irqs and fix unhandled Tx done with NAK Date: Tue, 28 Nov 2023 14:52:34 +0700 Message-Id: <20231128075236.2724038-1-quan@os.amperecomputing.com> X-Mailer: git-send-email 2.35.1 X-ClientProxiedBy: SI2P153CA0032.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::23) To SN4PR01MB7455.prod.exchangelabs.com (2603:10b6:806:202::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN4PR01MB7455:EE_|PH0PR01MB7895:EE_ X-MS-Office365-Filtering-Correlation-Id: c9a1de63-5b15-4a90-f891-08dbefe70950 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I5BRHLogMh87+oXHmGN+BtXxNKltwX6IXz4CEMy8AcKjCGo78sc27awMku0kuiY8GDpICtZC6WnvdThH9z552SrF2+LkmNsKonnStuosokVAhmMCQRQhdmtsKeVFG3lo+jRyyEnHA1eJSOgpHB1FcZ8xIGAUmIGeVxDQlVK8bQZRBDSIPEg3TS/GqW2fTGTNod7HbcUCKIKGs10soe39KdT+45bDIaC9JJLZ1m89gTPNtgkCuRZgxpoMQT5s/0nQxjg8fGrkLIk5UBGxCs3siwS59oOBLnBBI3sTCyZaWaXmqI2i6Bju77UFWgKCpCRPM0q+5AHOGjthT0JhHl5AzJVp8Ps9r5EtwGbRpYMFNrpxbKwoAyvcAjKHQWxLMw8x5hE1sdtCRGOs8LQTTFOENi1kDcFe13BKp2cq7wRqTUIZ2FpzFdUAi/N55wSwAvRNJrs9jgaxBT2760xtzFFSqioWZVK4rup9lOdqnWpvNCUIIPiterGNjcq8Aimh2eZGFSyxv1+MBC44jFp5Pa0ENAJCP3PCiDLCOO+RNrpGBl+7Hp8eBLffFomXjtScnA8V3sqfTGG1Xz30lzIO/W+b6BJGA/Ot7VeKqxNj1IpF+NJLijx/5Ct93Ro9Vw+2x4Jj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN4PR01MB7455.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(376002)(346002)(136003)(366004)(39850400004)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(4326008)(41300700001)(8936002)(2906002)(8676002)(6512007)(2616005)(6506007)(52116002)(86362001)(107886003)(316002)(66556008)(66476007)(921008)(66946007)(38350700005)(7416002)(54906003)(5660300002)(1076003)(478600001)(6666004)(26005)(6486002)(110136005)(966005)(83380400001)(38100700002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?xqPU1tMys2EQLxcbb316VUiHHSF2?= =?utf-8?q?QkgWH7bLbYArl7AHJgsPmQETNNk8zqO8qipHDVIYuD1oksiHFVosdcKAH+50H+8WG?= =?utf-8?q?LprimaTCUwoo+QoObR6Gy9scTlzzCSkIrD41pDAACsK+HvBkVgnr+/M479IbgfJF7?= =?utf-8?q?c2HrCbOzYHF4V/llUetkXxgHZ6HmKnQ81F9qrwP8fi6kABn0L4BOZrIuZI4FYsnrH?= =?utf-8?q?vmk70dbJWwVuv2fYoFN5maqp+y5lzbx7A7jBwDNm75CAADkDH7LTDIJgNdCmoo3aL?= =?utf-8?q?ZTQEJFAD8Fe195SSpC/BetZVoLjARrnPB0Gg8P5ZgLGKvedhgxx5Cx2jdhwRR+0mq?= =?utf-8?q?tYz/Cf6uS6N8axplIDhyIQQ8Bc7q/qsqUEOdcFlIs2WeyJPgOnf4u58NEtkQkn+jh?= =?utf-8?q?3CXfy5RHHnrtKRJ8qik7ZxRZiEtaH+cz8F062PF3x/cBuUPBZdl2hpjnf1MFmNY40?= =?utf-8?q?KVr8kNIoK4i8TKlDBM/vqmS76m84SwQ5cuxrnRYzL+4O4F/51gjj+1qEYkxUbr3t3?= =?utf-8?q?KSyLCRdtSrIqnlMDznIkC1Zd6nQFrVQVRV229AeldGwS7VlmU2iTpfdwIBvzD8Bwb?= =?utf-8?q?HKi1BmlDq7tplq82KRU7UYD8nYJ3K8L8xE4Nedmz3uasF98C+itXB/Hj0grDJsgPS?= =?utf-8?q?vvnhiNy1QKr7nlrrsxHDliyx5FjBgRDMmEaidE8OLluesWiuBOW1TZ/hFOpY6FIFj?= =?utf-8?q?s1FmytVC/T4EWxLVhFfaY0e7+ixxp42suy4mkjlbaGSy2OSNu9BGX+XCKYROvQFz1?= =?utf-8?q?GJkAZs4psNmH3A36IEmvX8yjN5QuSTyCWEj2U59T5ITCk1kGIZt4rAAqsmzh8gpl6?= =?utf-8?q?zNg6XP9TBtMyXKGCjLsVNUs0h0GNkxEFkOCdBoe7unQLOZFLIIk8mQU/SzZkwBm9S?= =?utf-8?q?LDon4FDGIV+ezVdnlWoxc+lKSRb1mzqmnzqZdEy5XKzIlcOGG3RZBWRtnb+Z6snCb?= =?utf-8?q?mFg67r196F+7G9mrQxPgXBs+tZD+fkFVZLeGXXfa70sD/fgMVxV0ln2UWiLDMlme8?= =?utf-8?q?j3MlDQqeHIAOlCiVIxrPr3QWABsTQ3c9bx/ZejnVxvp6ApPRDzZMCq3MQ19KU0njC?= =?utf-8?q?U3ykQfe0nvZjmAoMtIrHLBbIsAW2+9nBMImijJtSUuYigt8anPt/7knfX2mBQ3EmL?= =?utf-8?q?FpchDg8I+w5XImu+8WwhyYrMA5OnzjwcPrZOuaBM2bzydVqPOkEVNMoQw/PpXz3W5?= =?utf-8?q?sHQvIDHBy13ws3AZMjjTxuGOmmlojRkzfAOz87M+YDo1rIi0pjkYFGJnN5BmsX5OJ?= =?utf-8?q?BYr9RF2I8pHWwt5+mP0Lga+kBlQ+OArRV41Rrfjywcl49M0/SdOYt2Xa2dLhafVpd?= =?utf-8?q?3p2zJdKOSiHUOaQ13+nIp2+fpwun0M/QZhjChn71bLec8UyJjlcCbmf1osyamvvYI?= =?utf-8?q?ZsHTFVOHYJFtpgCJeLcnxy9zXm9rAp+1moiN8BS0vJ/F8E61KaEHaQI7Y8GQAdBM9?= =?utf-8?q?QCNqdJs0QrZPH6JNFUU6zIH+Oac8/IHnkTIoAC/OMUsMYVREj10c+/C/9+6vK90s7?= =?utf-8?q?/n469kFnPxMIIRPpA9lTS/bgNS3TmXekxoNJuPI0PObz8XFTbt0s7HE=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9a1de63-5b15-4a90-f891-08dbefe70950 X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 07:52:58.0507 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xXWCxb/6gOoZy7TCGE+RliTSmEbv2+paS6ikLgBY2O/rmYGuufU7+hkcvsMxRx0OYZq6LBcZjUk8UsK2UT++hme76QPEfJchVucpnqZeBdQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB7895 X-BeenThere: linux-aspeed@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux ASPEED SoC development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cosmo Chou , Open Source Submission , "Thang Q . Nguyen" , Phong Vo Errors-To: linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linux-aspeed" Rebase on the v6.7-rc3 and resend the series as per discussion at https://lore.kernel.org/all/d0773df55a6fe8a5c9b1a3d7c8dd2e1343643272.camel@codeconstruct.com.au/ The prior discussion could be found at https://lore.kernel.org/all/20210616031046.2317-1-quan@os.amperecomputing.com/ This series consists of two patches to fix the below issues observed when testing with slave mode: + Unhandled Tx done with NAK + Early ack'ed of Tx done (ACK and NAK) causing "Unexpected Ack on read request". v2: + Split these patches to separate series [Joel] + Added the Fixes lines [Joel] + Fixed multiline comment [Joel] + Refactor irq clearing code [Joel, Guenter] + Revised commit message [Joel, Quan] v1: + These patches are first introduced from this disscusstion https://lore.kernel.org/all/20210519074934.20712-1-quan@os.amperecomputing.com/ Quan Nguyen (2): i2c: aspeed: Fix unhandled Tx done with NAK i2c: aspeed: Acknowledge Tx done with and without ACK irq late drivers/i2c/busses/i2c-aspeed.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-)