mbox series

[0/4] Update Facebook Bletchley BMC DTS

Message ID 20220613095150.21917-1-potin.lai.pt@gmail.com
Headers show
Series Update Facebook Bletchley BMC DTS | expand

Message

Potin Lai June 13, 2022, 9:51 a.m. UTC 
Update below items for Facebook Bletchley BMC devicetree.

Potin Lai (4):
  ARM: dts: aspeed: bletchley: change LED sys_log_id to active low
  ARM: dts: aspeed: bletchley: disable GPIOV2 pull-down
  ARM: dts: aspeed: bletchley: bind presence-sledX pins via gpio-keys
  ARM: dts: aspeed: bletchley: update fusb302 nodes

 .../dts/aspeed-bmc-facebook-bletchley.dts     | 197 +++++++++++++-----
 1 file changed, 148 insertions(+), 49 deletions(-)

Comments

Patrick Williams June 13, 2022, 4:54 p.m. UTC | #1 
On Mon, Jun 13, 2022 at 05:51:46PM +0800, Potin Lai wrote:
> Update below items for Facebook Bletchley BMC devicetree.
> 
> Potin Lai (4):
>   ARM: dts: aspeed: bletchley: change LED sys_log_id to active low
>   ARM: dts: aspeed: bletchley: disable GPIOV2 pull-down
>   ARM: dts: aspeed: bletchley: bind presence-sledX pins via gpio-keys
>   ARM: dts: aspeed: bletchley: update fusb302 nodes
> 
>  .../dts/aspeed-bmc-facebook-bletchley.dts     | 197 +++++++++++++-----
>  1 file changed, 148 insertions(+), 49 deletions(-)

The whole patch set looks good to me as the closest domain expert to the
Bletchley system after Potin.

Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
Potin Lai June 22, 2022, 2:36 p.m. UTC | #2 
Patrick Williams 於 6/14/2022 12:54 AM 寫道:
> On Mon, Jun 13, 2022 at 05:51:46PM +0800, Potin Lai wrote:
>> Update below items for Facebook Bletchley BMC devicetree.
>>
>> Potin Lai (4):
>>   ARM: dts: aspeed: bletchley: change LED sys_log_id to active low
>>   ARM: dts: aspeed: bletchley: disable GPIOV2 pull-down
>>   ARM: dts: aspeed: bletchley: bind presence-sledX pins via gpio-keys
>>   ARM: dts: aspeed: bletchley: update fusb302 nodes
>>
>>  .../dts/aspeed-bmc-facebook-bletchley.dts     | 197 +++++++++++++-----
>>  1 file changed, 148 insertions(+), 49 deletions(-)
Hi Joel,
Could you help me review this patch series?
Could you also backport this to linux-aspeed 5.15 if everything looks good to you?
Thank you.

Potin
> The whole patch set looks good to me as the closest domain expert to the
> Bletchley system after Potin.
>
> Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
>