mbox series

[v4,0/4] gpio: aspeed: Fixes and support for sharing with co-processor

Message ID 20180629041119.5132-1-benh@kernel.crashing.org
Headers show
Series gpio: aspeed: Fixes and support for sharing with co-processor | expand

Message

Benjamin Herrenschmidt June 29, 2018, 4:11 a.m. UTC
This series cleans up the register accessors a bit, adds missing ones,
fixes the access to the write latch and finally adds an interface
that a co-processor driver can use to change the owner of some of
the GPIO lines and arbitrate access to shared GPIO banks.

v2: - Address Joel comments
v3: - Adds Reviewed-by tags
v4: - Document the reason for including gpiolob.h
    - Expose GPIO offsets & bit number so coprocessor firmware doesn't
      have to hard-code them (allows multi-system generic firwmare
      that gets "configure" by the copro driver)

Please consider putting this in a topic branch so I can pull it
back into dependent series and point the reviewers to dependencies

Comments

Linus Walleij July 2, 2018, 2:13 p.m. UTC | #1
On Fri, Jun 29, 2018 at 6:11 AM Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:

> This series cleans up the register accessors a bit, adds missing ones,
> fixes the access to the write latch and finally adds an interface
> that a co-processor driver can use to change the owner of some of
> the GPIO lines and arbitrate access to shared GPIO banks.
>
> v2: - Address Joel comments
> v3: - Adds Reviewed-by tags
> v4: - Document the reason for including gpiolob.h
>     - Expose GPIO offsets & bit number so coprocessor firmware doesn't
>       have to hard-code them (allows multi-system generic firwmare
>       that gets "configure" by the copro driver)

I've applied the v4 to the "ib-apeed" driver and merged that for
devel, I will push to linux-next once the build servers confirm
they are happy as well.

The immutable branch is here:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=ib-aspeed

Yours,
Linus Walleij
Benjamin Herrenschmidt July 3, 2018, 12:59 a.m. UTC | #2
On Mon, 2018-07-02 at 16:13 +0200, Linus Walleij wrote:
> On Fri, Jun 29, 2018 at 6:11 AM Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
> 
> > This series cleans up the register accessors a bit, adds missing ones,
> > fixes the access to the write latch and finally adds an interface
> > that a co-processor driver can use to change the owner of some of
> > the GPIO lines and arbitrate access to shared GPIO banks.
> > 
> > v2: - Address Joel comments
> > v3: - Adds Reviewed-by tags
> > v4: - Document the reason for including gpiolob.h
> >     - Expose GPIO offsets & bit number so coprocessor firmware doesn't
> >       have to hard-code them (allows multi-system generic firwmare
> >       that gets "configure" by the copro driver)
> 
> I've applied the v4 to the "ib-apeed" driver and merged that for
> devel, I will push to linux-next once the build servers confirm
> they are happy as well.
> 
> The immutable branch is here:
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=ib-aspeed

Thanks. I'll pull it into the fsi tree so I can start laying out some
of the dependent stuff on top.

Cheers,
Ben.