Message ID | 20180514145330.4857-1-peda@axentia.se |
---|---|
Headers | show
Return-Path: <linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40m5fw5lHJz9s0y for <incoming@patchwork.ozlabs.org>; Wed, 16 May 2018 17:29:44 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=axentia.se Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axentia.se header.i=@axentia.se header.b="uARgiBiT"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 40m5fw4JHkzF1Rg for <incoming@patchwork.ozlabs.org>; Wed, 16 May 2018 17:29:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=axentia.se Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axentia.se header.i=@axentia.se header.b="uARgiBiT"; dkim-atps=neutral X-Original-To: linux-aspeed@lists.ozlabs.org Delivered-To: linux-aspeed@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=axentia.se (client-ip=40.107.2.116; helo=eur02-ve1-obe.outbound.protection.outlook.com; envelope-from=peda@axentia.se; receiver=<UNKNOWN>) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=axentia.se Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axentia.se header.i=@axentia.se header.b="uARgiBiT"; dkim-atps=neutral Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20116.outbound.protection.outlook.com [40.107.2.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40l3cr1P4mzF2fB; Tue, 15 May 2018 00:54:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axentia.se; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OVUkWDJ6V8c7ip6B4dMegMwsWV5hE029JkFMbU82zJ8=; b=uARgiBiTuB3lDYCfODEf1NBym0Nt0A4sGhP1XO0LL2CaflCha/kxs/nCX8Y7RmZ4uFzOxxQSpasKb+A+rvu7qh5/Wg1bAuCIpGeVgYt27VaeWaE6yPp90MNCHAMhOrK1JYpK59qx6zFBF4Q75QmSOdiIZM7Pj/8sNBEENB1XrT0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Received: from orc.pedanet (85.226.244.23) by VI1PR0202MB2782.eurprd02.prod.outlook.com (2603:10a6:800:db::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Mon, 14 May 2018 14:54:03 +0000 From: Peter Rosin <peda@axentia.se> To: linux-kernel@vger.kernel.org Subject: [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg Date: Mon, 14 May 2018 16:53:09 +0200 Message-Id: <20180514145330.4857-1-peda@axentia.se> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [85.226.244.23] X-ClientProxiedBy: HE1PR08CA0043.eurprd08.prod.outlook.com (2603:10a6:7:2a::14) To VI1PR0202MB2782.eurprd02.prod.outlook.com (2603:10a6:800:db::7) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(7021125)(5600026)(4534165)(7022125)(4603075)(4627221)(201702281549075)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(7193020); SRVR:VI1PR0202MB2782; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0202MB2782; 3:onxGpKCqLI+MviHVI4Dp40l6MiTRk/j3o0JuRI6nf2I+4ylvFqW4XyYGbgHd9PAnKusxA17CtnnCgJO4hXCAWp0F17VXe5QszMavJRuLOvXudXd3gnH9JApDwQvYtWtnKsjaVIKYupfj0HOM2ZBe9NB3qlC2Eu6w8Z2+30yd1GGqgVPQbmloO8cakVuac5eALHZXF6U6N+aQWtREpFWXb18JeXgJxxEGbwowku29Cj2pJtMCb74jhpezcbpMu4xd; 25:p6oht5xsYNKjKiWCadzltBX1WxdvqByUIBKftRE7Gd2wu2F0PKcAdlJ/+XGlTLoR5kEhKMqyRcv5NLlrtpvvZlBmA8figx1yOT7F5AOfrpqfDKnSV7ny5rFe/xucGIlRljenE0taMbAAPJUa0MUU5x4k5IuQay1mMHZ36ihxHL2YDoG6XIjSEJ2qz0/bdnos1EItiOklPeDehAeLlXp0bj7snvLedZ1duhhjjrdwv8/C2FuEJANyMEGPfNJRc3p4dcTUrP45nLpCcE3dPQwHrKUWLEstOy/6Ib62+jPAP2Lum+EJmrPjdLQixnqmxylIX0iawJI/XEF/RFngEjM5xg==; 31:UF3rQrwvFsATTfyo5rjM2w/+kLOxm57syvei4IICHsd0zXw/IP971F74w75CgfvBY5YR79ToLXYHpQdqTslEOoscwI+LJsJOlcSc44Sf/vTwwCpC3u4XfVEaRYZ5BtZcjXUM2t5qvC1CATwXQTIPBE+FD+t0hIlk/8J/dpqx/n1OO0whdnDNCZwKcmkYc4zy3YDkTME39neWoOBm0gjZq4cEEhDKrovdKgG2J2WzCZA= X-MS-TrafficTypeDiagnostic: VI1PR0202MB2782: X-Microsoft-Antispam-PRVS: <VI1PR0202MB2782AE45E6E4B3452CD22C76BC9C0@VI1PR0202MB2782.eurprd02.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(2016111802025)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(6043046)(201708071742011); SRVR:VI1PR0202MB2782; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0202MB2782; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0202MB2782; 4:pdB4sUl14LJed7ghkTodmhQMp1IzqCCzw25IvEhuiBs43GvhJDhVlQN4IdTaYrf0vaNDPxJt/HmxstHeHd1bWvs/zmwXF1W72V5dnRCLDmSRs7daMDfH5YB+fo7IebAAphrHT3gW4/Fd3sR4aYDKXZcplz6l0BgLXgO4RBQH/G1TxLI15HM2whHl/TK/5jre5dpePPzXY3dhMGQqeFAZorTh4mSFy6HdqGp9J/1Q82h13Js0TkbeA7LBLlFhf3kgdrzIpdOgmO1BzdLvUxbyYA== X-Forefront-PRVS: 067270ECAF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(366004)(39380400002)(396003)(376002)(39830400003)(346002)(189003)(199004)(48376002)(6116002)(97736004)(68736007)(478600001)(4326008)(5660300001)(1076002)(2906002)(53936002)(16586007)(3846002)(66066001)(6916009)(316002)(15760500003)(47776003)(50466002)(54906003)(6486002)(50226002)(7416002)(186003)(16526019)(476003)(81166006)(25786009)(6512007)(105586002)(7736002)(956004)(106356001)(2616005)(6506007)(36756003)(386003)(2351001)(305945005)(486006)(52116002)(51416003)(26005)(8676002)(81156014)(74482002)(86362001)(2361001)(8936002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR0202MB2782; H:orc.pedanet; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: axentia.se does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0202MB2782; 23:3dMrWKx7mN5ubLPo27TbblEUMOZDW7mYICuvvAL?= k3uuLj4QkaWpcA2WcevtDE32JDHEx+tTXxRvjiL6bQyRZ+yg/h+cDpzXWnyILqSTgqMO0+ZK8FeWjMonxkCXvt9ME8Xlf5VAxHNIp3sU1xUaDqY6nVZ6Zzyh6FZSStSUeiK5pvA7p7JLHVMx/Qnz43xmfeSdz08Su9t5AzAPAO7kxy5YQcABehMO0A9+Z9hoOxDIjNCcX9y2mhRrc51UDjysAr6Q6+GSHjmVEdeZEhQPo84m0+z0h6EJPMUCsckwXDc9I22cbrcwScsR/mYSLdcd87xktVBNr44+b4nlVLvmQ2unpiCupkKYDBuCJicBq84qi54c7/UJeJYcJv4bG1oQhyf0COFeT7AGec0WybEJG0p3FpGOhDrEQidKVHZVHiGhFvw4LNKEbhbtLqKkv/Xlg85H0WZBG/OVVgpj3dS8x1is0lSvEEzj4QDWh5gTjNeImCmeDlcjX3nRLKl0FftI0H5JAnTEXJ7rMVPo36Z/Lu3E369e7wHNP3iPk3YY4MLnouKF3mZpovyoFkOJLX2JPWJxgf86uPDKyjF8742VPfnjUImL7wTl8FQPGsA2/z8bTRoules5lJMUovCu37EFZ/qLhE3+NbDCskrUfu0Oi8CXZN94/5kRNmW61Gjdr7Lq2PkIUBbkdNxIF3gCP2eIStbga6qDV7/h4oRkgBXIqKo7ooE5yJwt0B51rPAUmeo4Duj+I/V/kNVt54UdHc6Y4X+UO2si9M3exAjBgmvyglKBErAcYm0aqXpFhqk0VJkZYF+aZVSWEDj9iQ6QwWe+XfH6x5Gj7FavABOpGUiNZU+FCdqYg9U1yeJC5Zm9jfNZTnQybhI0pQj392qdKXGTpvvcRwFnnd8Oa3pOP65b4ddqe+KK7epQQ0QyNGJS7VWuNTYS8JaAQsJnH3jOlRPNrjcTUHzSAuV9RSxZJVUiv6Xxap6ISpy5vL079cSeI6q0MnNqdQ2Q83sGib60zmLBdWBfEx20oRqhAUk6z+IZkWGXWACfKSXKGRehIfegmGm3b6oiMt6kixLBg6f9wJUxTRnW/xLtf61jsIe6miyVt97klfiWHuckdO7VgAeA7Pgx9iLVw7sO3Ve98w8J0lIptCu9/cFxA7Wjriho7YrZHoD4RxdajZ0sbviGEb0vfy3A8VjNcKoPWnUdz8uAPnEJ4YKhRX1Mw6fTKwcxX4Tk1ot2l+x7g6lK4q0CC1OJMdpEyanRQ80ZPxxEpPJnUkB87 X-Microsoft-Antispam-Message-Info: 2h5KKwVOdY9Lt3Y7/uvTQo2MlSTJHcxr6SvpL3W9XYBd9JjgkTFuFWb1OyCDycfkh683qvcoD5dcgwMPfTk+ju58NP9xc4grhneAe0gokZq9mgY+IPgglG8WkoptChUo1pjMbeoqD1hhAzJZeQr5a0Uuyzho6raFawDdRxkMitZwJzz0rDBzqOpDzh4aQBfK X-Microsoft-Exchange-Diagnostics: 1; VI1PR0202MB2782; 6:NlvOgwV5H3DafF25Wb0/KQe1DX4i35e0zPT4n5GTCafBGjMvUgv0HlqSLks3mAfVtwq0j1QGY/Eo/0ad535/s5wvNItYy9YB26PRm0M2tECLos5Dvyzd/zslyn0p3iwA1pGyDEjARqiyYk95dHAz5JwMRT4MNcQ8kvaQQimtTt6YZTLD7SeuakatxRnbFo7auEmjCm3wia06DiK/47Gnz/prrpUe7BooNG6StT4GJ2dwa1uuJOcq6kXOJvE6c6w1g+rHcPxxdtasyARac2/o29VFQvMdzaqtPJBWLUuZukX31sgh5Xe+8hoCehgqzwjAMdf7WERGETxjCC7kNI5BlUrCXhdvSrGpvhD07MF3FVz+PmgtvHaMJ7h0sJk1+FkNCBlXEif1Au7b/YlEjEqkwibyYD+zVfAiCPIpwWxD17veK/967OwQNGv0cLP4J58OC9a1iCwTG9Rzhlk1SIiEhw==; 5:0yqIfMDSRA+H8HY5wYR9Glq8Hegkq/VoDbMH2rCqFrR9b5lgQQjYR6G3D9L0DAJe3530x4dWJ+tHZd55pRI0p0wI/PP2iVEBbfh6sUwwRcQlhYp2ta4cusvNC5TIs86u1e290uPqZtjUEmE60IfCuXW+zIuGZsQ3igNdu+cDMp8=; 24:PHjlWi8Qk8iW1vKDSR0hTSzpeqSS0RpllNS8DS9vURPCyK0/IEQqrVaScCRG6vxtyq/0xKOE4zA1qdC/7WITFOTSrj8nthNfvdWwl4FAim8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0202MB2782; 7:tRgwux/qTWNGqo2CL26Qq1dhEP/Ol9DYLkVgvVOws6hRHvvhfrw2+jWKCHogkQ4KQEj9qlFA2OvgUcQwIg+HNXTfPa44fZqunx3ZrpeqhPZZlPIo8RO9HNDgWisb27DZVp7DVf1b8fdnu2A0ky6d3Iwmuuyaff2u+y9Sb0DN00uVpaSlZeBSx+ecFVNLd2bV7aHoLFa5GOFSyN9/hZb8gkrnh/ZbM1EaXfZzh1Y+HMM4JNRLu0jy41YF5tH2JdNw X-MS-Office365-Filtering-Correlation-Id: 402292d4-5387-4ba6-648f-08d5b9aa89ee X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2018 14:54:03.8411 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 402292d4-5387-4ba6-648f-08d5b9aa89ee X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2782 X-Mailman-Approved-At: Wed, 16 May 2018 17:28:00 +1000 X-BeenThere: linux-aspeed@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux ASPEED SoC development <linux-aspeed.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/linux-aspeed>, <mailto:linux-aspeed-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/linux-aspeed/> List-Post: <mailto:linux-aspeed@lists.ozlabs.org> List-Help: <mailto:linux-aspeed-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/linux-aspeed>, <mailto:linux-aspeed-request@lists.ozlabs.org?subject=subscribe> Cc: linux-arm-kernel@lists.infradead.org, linux-soc@vger.kernel.org, linux-aspeed@lists.ozlabs.org, David Brown <david.brown@linaro.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Linus Walleij <linus.walleij@linaro.org>, Brendan Higgins <brendanhiggins@google.com>, linux-arm-msm@vger.kernel.org, openbmc@lists.ozlabs.org, Wolfram Sang <wsa+renesas@sang-engineering.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, Andy Gross <andy.gross@linaro.org>, Peter Korsgaard <jacmet@sunsite.dk>, linuxppc-dev@lists.ozlabs.org, Peter Rosin <peda@axentia.se>, Guenter Roeck <linux@roeck-us.net>, linux-i2c@vger.kernel.org Errors-To: linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linux-aspeed" <linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> |
Series |
i2c: make use of i2c_8bit_addr_from_msg
|
expand
|
On 2018-05-14 18:11, Joe Perches wrote: > On Mon, 2018-05-14 at 16:53 +0200, Peter Rosin wrote: >> Hi! >> >> The nice little inline i2c_8bit_addr_from_msg is not getting >> enough use. This series improves the situation and drops a >> bunch of lines in the process. > > Perhaps the inline should test for I2C_M_REV_DIR_ADDR > as there is at least one use like > > - addr = msg->addr << 1; > - if (flags & I2C_M_RD) > - addr |= 1; > + addr = i2c_8bit_addr_from_msg(msg); > if (flags & I2C_M_REV_DIR_ADDR) > addr ^= 1; > > which look odd I say no, because the driver has to also indicate support with I2C_FUNC_PROTOCOL_MANGLING and I don't see a sane way to check that part of the contract. But what do I know. Seems orthogonal. > Do any of these changes now no longer need > the temporary flags variable? Right, I thought I had made any obvious further simplification made possible by these changes, but I overlooked that one. The flags variable is certainly over-engineered in i2c-algo-pcf.c and would be a good candidate for removal. But that's only patch 3/21. I'll wait for a bit with an update, and Wolfram can adjust this on the way in if he feels like it. Cheers, Peter