| Message ID | 20230714173949.4038981-1-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | arc: Explicitly include correct DT includes | expand |
On Fri, Jul 14, 2023 at 11:39:49AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > arch/arc/plat-axs10x/axs10x.c | 1 - > 1 file changed, 1 deletion(-) Ping! > > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c > index b821df7b0089..1feb990a56bc 100644 > --- a/arch/arc/plat-axs10x/axs10x.c > +++ b/arch/arc/plat-axs10x/axs10x.c > @@ -6,7 +6,6 @@ > */ > > #include <linux/of_fdt.h> > -#include <linux/of_platform.h> > #include <linux/libfdt.h> > > #include <asm/asm-offsets.h> > -- > 2.40.1 >
Hi Rob, > On Fri, Jul 14, 2023 at 11:39:49AM -0600, Rob Herring wrote: > > The DT of_device.h and of_platform.h date back to the separate > > of_platform_bus_type before it as merged into the regular platform bus. > > As part of that merge prepping Arm DT support 13 years ago, they > > "temporarily" include each other. They also include platform_device.h > > and of.h. As a result, there's a pretty much random mix of those include > > files used throughout the tree. In order to detangle these headers and > > replace the implicit includes with struct declarations, users need to > > explicitly include the correct includes. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > arch/arc/plat-axs10x/axs10x.c | 1 - > > 1 file changed, 1 deletion(-) > > Ping! Thanks for the enhancement! Tested-by: Alexey Brodkin <abrodkin@synopsys.com> > > > > > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c > > index b821df7b0089..1feb990a56bc 100644 > > --- a/arch/arc/plat-axs10x/axs10x.c > > +++ b/arch/arc/plat-axs10x/axs10x.c > > @@ -6,7 +6,6 @@ > > */ > > > > #include <linux/of_fdt.h> > > -#include <linux/of_platform.h> > > #include <linux/libfdt.h> > > > > #include <asm/asm-offsets.h> > > -- > > 2.40.1 > >
On 8/23/23 10:00, Rob Herring wrote: > On Fri, Jul 14, 2023 at 11:39:49AM -0600, Rob Herring wrote: >> The DT of_device.h and of_platform.h date back to the separate >> of_platform_bus_type before it as merged into the regular platform bus. >> As part of that merge prepping Arm DT support 13 years ago, they >> "temporarily" include each other. They also include platform_device.h >> and of.h. As a result, there's a pretty much random mix of those include >> files used throughout the tree. In order to detangle these headers and >> replace the implicit includes with struct declarations, users need to >> explicitly include the correct includes. >> >> Signed-off-by: Rob Herring <robh@kernel.org> >> --- >> arch/arc/plat-axs10x/axs10x.c | 1 - >> 1 file changed, 1 deletion(-) > Ping! Sorry this fell through cracks, added to for-curr now ! Thx, -Vineet
diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c index b821df7b0089..1feb990a56bc 100644 --- a/arch/arc/plat-axs10x/axs10x.c +++ b/arch/arc/plat-axs10x/axs10x.c @@ -6,7 +6,6 @@ */ #include <linux/of_fdt.h> -#include <linux/of_platform.h> #include <linux/libfdt.h> #include <asm/asm-offsets.h>
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring <robh@kernel.org> --- arch/arc/plat-axs10x/axs10x.c | 1 - 1 file changed, 1 deletion(-)