| Message ID | 20180913074110.6431-1-abrodkin@synopsys.com |
|---|---|
| State | New |
| Headers | show |
| Series | [ARC] Fix generation of specs | expand |
The patch is missing the entry change log. Otherwise is ok. I'll push it with the mentioned changes. Thank you, Claudiu > -----Original Message----- > From: Alexey Brodkin [mailto:abrodkin@synopsys.com] > Sent: Thursday, September 13, 2018 9:41 AM > To: gcc-patches@gcc.gnu.org > Cc: linux-snps-arc@lists.infradead.org; Alexey Brodkin > <abrodkin@synopsys.com>; Andrew Burgess > <andrew.burgess@embecosm.com>; Claudiu Zissulescu > <claziss@synopsys.com> > Subject: [PATCH] [ARC] Fix generation of specs > > With no trailing space in LINK_EH_SPEC linker spec gets generated as: > ------------------------>8--------------------- > %{!r:--build-id} --eh-frame-hdr%{h*} ... > ------------------------>8--------------------- > > or even worse if hash style is added: > ------------------------>8--------------------- > %{!r:--build-id} --eh-frame-hdr--hash-style=sysv %{h*} ... > ------------------------>8--------------------- > > Now if that spec is really used by LD then it fails inevitably > saying that it doesn't know option "--eh-frame-hdr--hash-style=sysv". > > Cc: Andrew Burgess <andrew.burgess@embecosm.com> > Cc: Claudiu Zissulescu <claziss@synopsys.com> > --- > gcc/config/arc/linux.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/arc/linux.h b/gcc/config/arc/linux.h > index 96d548eae341..62ebe4de0fc7 100644 > --- a/gcc/config/arc/linux.h > +++ b/gcc/config/arc/linux.h > @@ -98,7 +98,7 @@ along with GCC; see the file COPYING3. If not see > Signalize that because we have fde-glibc, we don't need all C shared libs > linked against -lgcc_s. */ > #undef LINK_EH_SPEC > -#define LINK_EH_SPEC "--eh-frame-hdr" > +#define LINK_EH_SPEC "--eh-frame-hdr " > #endif > > #undef SUBTARGET_CPP_SPEC > -- > 2.17.1
Hi Claus,
On Thu, 2018-09-13 at 09:59 +0200, Claudiu Zissulescu wrote:
> The patch is missing the entry change log. Otherwise is ok. I'll push it with the mentioned changes.
Thanks for taking care.
Also may we have it back-ported to 8.x branch so it will be a part of 8.3 release later?
-Alexey
diff --git a/gcc/config/arc/linux.h b/gcc/config/arc/linux.h index 96d548eae341..62ebe4de0fc7 100644 --- a/gcc/config/arc/linux.h +++ b/gcc/config/arc/linux.h @@ -98,7 +98,7 @@ along with GCC; see the file COPYING3. If not see Signalize that because we have fde-glibc, we don't need all C shared libs linked against -lgcc_s. */ #undef LINK_EH_SPEC -#define LINK_EH_SPEC "--eh-frame-hdr" +#define LINK_EH_SPEC "--eh-frame-hdr " #endif #undef SUBTARGET_CPP_SPEC
With no trailing space in LINK_EH_SPEC linker spec gets generated as: ------------------------>8--------------------- %{!r:--build-id} --eh-frame-hdr%{h*} ... ------------------------>8--------------------- or even worse if hash style is added: ------------------------>8--------------------- %{!r:--build-id} --eh-frame-hdr--hash-style=sysv %{h*} ... ------------------------>8--------------------- Now if that spec is really used by LD then it fails inevitably saying that it doesn't know option "--eh-frame-hdr--hash-style=sysv". Cc: Andrew Burgess <andrew.burgess@embecosm.com> Cc: Claudiu Zissulescu <claziss@synopsys.com> --- gcc/config/arc/linux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)