From patchwork Thu Dec 3 12:41:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vineet Gupta X-Patchwork-Id: 552233 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id EF31E1402C0 for ; Thu, 3 Dec 2015 23:42:17 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a4TDE-0003ou-M8; Thu, 03 Dec 2015 12:42:16 +0000 Received: from smtprelay.synopsys.com ([198.182.60.111]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a4TDC-0003ko-9x for linux-snps-arc@lists.infradead.org; Thu, 03 Dec 2015 12:42:14 +0000 Received: from dc8secmta2.synopsys.com (dc8secmta2.synopsys.com [10.13.218.202]) by smtprelay.synopsys.com (Postfix) with ESMTP id 4611A10C081A; Thu, 3 Dec 2015 04:41:55 -0800 (PST) Received: from dc8secmta2.internal.synopsys.com (dc8secmta2.internal.synopsys.com [127.0.0.1]) by dc8secmta2.internal.synopsys.com (Service) with ESMTP id 3AE6FA4114; Thu, 3 Dec 2015 04:41:55 -0800 (PST) Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by dc8secmta2.internal.synopsys.com (Service) with ESMTP id F33C6A4102; Thu, 3 Dec 2015 04:41:54 -0800 (PST) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id E362BDF3; Thu, 3 Dec 2015 04:41:54 -0800 (PST) Received: from us01wehtc1.internal.synopsys.com (us01wehtc1-vip.internal.synopsys.com [10.12.239.236]) by mailhost.synopsys.com (Postfix) with ESMTP id D3B8BDF2; Thu, 3 Dec 2015 04:41:54 -0800 (PST) Received: from IN01WEHTCB.internal.synopsys.com (10.144.199.106) by us01wehtc1.internal.synopsys.com (10.12.239.231) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 3 Dec 2015 04:41:54 -0800 Received: from IN01WEHTCA.internal.synopsys.com (10.144.199.103) by IN01WEHTCB.internal.synopsys.com (10.144.199.105) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 3 Dec 2015 18:11:52 +0530 Received: from vineetg-E7440.internal.synopsys.com (10.12.197.182) by IN01WEHTCA.internal.synopsys.com (10.144.199.243) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 3 Dec 2015 18:11:51 +0530 From: Vineet Gupta To: Subject: [PATCH 04/17] ARC: dw2 unwind: Remove FP based unwinding Date: Thu, 3 Dec 2015 18:11:02 +0530 Message-ID: <1449146475-15335-5-git-send-email-vgupta@synopsys.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1449146475-15335-1-git-send-email-vgupta@synopsys.com> References: <1449146475-15335-1-git-send-email-vgupta@synopsys.com> MIME-Version: 1.0 X-Originating-IP: [10.12.197.182] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151203_044214_376964_EB0F81E1 X-CRM114-Status: GOOD ( 11.63 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [198.182.60.111 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [198.182.60.111 listed in list.dnswl.org] -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vineet Gupta , Alexey.Brodkin@synopsys.com, linux-kernel@vger.kernel.org, JBeulich@suse.com Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org FP is disabled for ARC and even if it was enabled, it won't help with unwinding given ARC ABI so remove it. Typical ABI would - save BLINK (return address) on stack - save FP on stack - anchor FP for this frame - save any callee-regs and/or carve frame for local vars Thus FP remains fixed for frame and can be used to determine BLINK. ARC ABI historically required saving callee-regs before anchoring FP, thus rendering it useless for finding BLINK. Signed-off-by: Vineet Gupta --- arch/arc/include/asm/unwind.h | 11 +---------- arch/arc/kernel/unwind.c | 45 ++----------------------------------------- 2 files changed, 3 insertions(+), 53 deletions(-) diff --git a/arch/arc/include/asm/unwind.h b/arch/arc/include/asm/unwind.h index 559ef55abce1..03ace2cc8bc5 100644 --- a/arch/arc/include/asm/unwind.h +++ b/arch/arc/include/asm/unwind.h @@ -58,17 +58,7 @@ struct unwind_frame_info { #define UNW_PC(frame) ((frame)->regs.r63) #define UNW_SP(frame) ((frame)->regs.r28) #define UNW_BLINK(frame) ((frame)->regs.r31) - -/* Rajesh FIXME */ -#ifdef CONFIG_FRAME_POINTER #define UNW_FP(frame) ((frame)->regs.r27) -#define FRAME_RETADDR_OFFSET 4 -#define FRAME_LINK_OFFSET 0 -#define STACK_BOTTOM_UNW(tsk) STACK_LIMIT((tsk)->thread.ksp) -#define STACK_TOP_UNW(tsk) ((tsk)->thread.ksp) -#else -#define UNW_FP(frame) ((void)(frame), 0) -#endif #define STACK_LIMIT(ptr) (((ptr) - 1) & ~(THREAD_SIZE - 1)) @@ -128,6 +118,7 @@ extern void unwind_remove_table(void *handle, int init_only); #define UNW_PC(frame) ((void)(frame), 0) #define UNW_SP(frame) ((void)(frame), 0) #define UNW_FP(frame) ((void)(frame), 0) +#define UNW_FP(frame) ((void)(frame), 0) static inline void arc_unwind_init(void) { diff --git a/arch/arc/kernel/unwind.c b/arch/arc/kernel/unwind.c index 2f4a67f5a863..0993a81e112b 100644 --- a/arch/arc/kernel/unwind.c +++ b/arch/arc/kernel/unwind.c @@ -1057,50 +1057,9 @@ int arc_unwind(struct unwind_frame_info *frame) fde = NULL; } } - if (cie == NULL || fde == NULL) { -#ifdef CONFIG_FRAME_POINTER - unsigned long top, bottom; - - top = STACK_TOP_UNW(frame->task); - bottom = STACK_BOTTOM_UNW(frame->task); -#if FRAME_RETADDR_OFFSET < 0 - if (UNW_SP(frame) < top && UNW_FP(frame) <= UNW_SP(frame) - && bottom < UNW_FP(frame) -#else - if (UNW_SP(frame) > top && UNW_FP(frame) >= UNW_SP(frame) - && bottom > UNW_FP(frame) -#endif - && !((UNW_SP(frame) | UNW_FP(frame)) - & (sizeof(unsigned long) - 1))) { - unsigned long link; - - if (!__get_user(link, (unsigned long *) - (UNW_FP(frame) + FRAME_LINK_OFFSET)) -#if FRAME_RETADDR_OFFSET < 0 - && link > bottom && link < UNW_FP(frame) -#else - && link > UNW_FP(frame) && link < bottom -#endif - && !(link & (sizeof(link) - 1)) - && !__get_user(UNW_PC(frame), - (unsigned long *)(UNW_FP(frame) - + FRAME_RETADDR_OFFSET))) - { - UNW_SP(frame) = - UNW_FP(frame) + FRAME_RETADDR_OFFSET -#if FRAME_RETADDR_OFFSET < 0 - - -#else - + -#endif - sizeof(UNW_PC(frame)); - UNW_FP(frame) = link; - return 0; - } - } -#endif + if (cie == NULL || fde == NULL) return -ENXIO; - } + state.org = startLoc; memcpy(&state.cfa, &badCFA, sizeof(state.cfa));