mbox series

[v2,0/2] MTD: spi-nor: add support for sst26wf016, sst26wf032

Message ID 20180910114628.19156-1-Eugeniy.Paltsev@synopsys.com
Headers show
Series MTD: spi-nor: add support for sst26wf016, sst26wf032 | expand

Message

Eugeniy Paltsev Sept. 10, 2018, 11:46 a.m. UTC
Add support for the SST sst26wf016 and sst26wf032 flash IC:

sst26wf*** flash series block protection implementation differs from other
SST series, so we add implementation for sst26wf*** lock/unlock/is_locked
functions.

Add sst26wf016 and sst26wf032 flash IC info to spi_flash_ids list.

NOTE:
these patches is basically following mine u-boot commits port:
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=3d4fed87a5fa3ffedf64ff2811cd95c5ac4503ac
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=a19e97157c3721ef9c4b15c68c1773467a3b4a98

Changes v1->v2:
 * Check return value of {read | write}_reg callbacks.

Eugeniy Paltsev (2):
  mtd: spi-nor: Add support of sst26wf* flash ICs protection ops
  mtd: spi-nor: add support for sst26wf016, sst26wf032

 drivers/mtd/spi-nor/spi-nor.c | 179 ++++++++++++++++++++++++++++++++++++++++++
 include/linux/mtd/spi-nor.h   |   4 +
 2 files changed, 183 insertions(+)

Comments

Eugeniy Paltsev Oct. 22, 2018, 1:47 p.m. UTC | #1
Hi!

Maybe you have any comments or remarks about this patch?And if you don't could you please apply it. Thanks!

On Mon, 2018-09-10 at 14:46 +0300, Eugeniy Paltsev wrote:
> Add support for the SST sst26wf016 and sst26wf032 flash IC:
> 
> sst26wf*** flash series block protection implementation differs from other
> SST series, so we add implementation for sst26wf*** lock/unlock/is_locked
> functions.
> 
> Add sst26wf016 and sst26wf032 flash IC info to spi_flash_ids list.
> 
> NOTE:
> these patches is basically following mine u-boot commits port:
> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=3d4fed87a5fa3ffedf64ff2811cd95c5ac4503ac
> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=a19e97157c3721ef9c4b15c68c1773467a3b4a98
> 
> Changes v1->v2:
>  * Check return value of {read | write}_reg callbacks.
> 
> Eugeniy Paltsev (2):
>   mtd: spi-nor: Add support of sst26wf* flash ICs protection ops
>   mtd: spi-nor: add support for sst26wf016, sst26wf032
> 
>  drivers/mtd/spi-nor/spi-nor.c | 179 ++++++++++++++++++++++++++++++++++++++++++
>  include/linux/mtd/spi-nor.h   |   4 +
>  2 files changed, 183 insertions(+)
>
Boris Brezillon Oct. 22, 2018, 1:56 p.m. UTC | #2
+Tudor

Hi Eugeniy,

On Mon, 22 Oct 2018 13:47:09 +0000
Eugeniy Paltsev <eugeniy.paltsev@synopsys.com> wrote:

> Hi!
> 
> Maybe you have any comments or remarks about this patch?And if you don't could you please apply it. Thanks!

Sorry, it's already too late for 4.20, and I won't apply patches to the
spi-nor/next branch before 4.20-rc1 is out.

Tudor, Marek, can I have a Reviewed-by/Acked-by on this patchset?

Thanks,

Boris

> 
> On Mon, 2018-09-10 at 14:46 +0300, Eugeniy Paltsev wrote:
> > Add support for the SST sst26wf016 and sst26wf032 flash IC:
> > 
> > sst26wf*** flash series block protection implementation differs from other
> > SST series, so we add implementation for sst26wf*** lock/unlock/is_locked
> > functions.
> > 
> > Add sst26wf016 and sst26wf032 flash IC info to spi_flash_ids list.
> > 
> > NOTE:
> > these patches is basically following mine u-boot commits port:
> > http://git.denx.de/?p=u-boot.git;a=commitdiff;h=3d4fed87a5fa3ffedf64ff2811cd95c5ac4503ac
> > http://git.denx.de/?p=u-boot.git;a=commitdiff;h=a19e97157c3721ef9c4b15c68c1773467a3b4a98
> > 
> > Changes v1->v2:
> >  * Check return value of {read | write}_reg callbacks.
> > 
> > Eugeniy Paltsev (2):
> >   mtd: spi-nor: Add support of sst26wf* flash ICs protection ops
> >   mtd: spi-nor: add support for sst26wf016, sst26wf032
> > 
> >  drivers/mtd/spi-nor/spi-nor.c | 179 ++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/mtd/spi-nor.h   |   4 +
> >  2 files changed, 183 insertions(+)
> >
Eugeniy Paltsev Nov. 19, 2018, 3:25 p.m. UTC | #3
Hi Boris,

As 4.20-rc1 is already out I guess you can pick this patches to spi-nor/next?

Thanks.

On Mon, 2018-10-22 at 15:56 +0200, Boris Brezillon wrote:
> +Tudor
> 
> Hi Eugeniy,
> 
> Sorry, it's already too late for 4.20, and I won't apply patches to the
> spi-nor/next branch before 4.20-rc1 is out.
> 
> Tudor, Marek, can I have a Reviewed-by/Acked-by on this patchset?
> 
> Thanks,
> 
> Boris
> 
> > 
> > On Mon, 2018-09-10 at 14:46 +0300, Eugeniy Paltsev wrote:
> > > Add support for the SST sst26wf016 and sst26wf032 flash IC:
> > > 
> > > sst26wf*** flash series block protection implementation differs from other
> > > SST series, so we add implementation for sst26wf*** lock/unlock/is_locked
> > > functions.
> > > 
> > > Add sst26wf016 and sst26wf032 flash IC info to spi_flash_ids list.
> > > 
> > > Eugeniy Paltsev (2):
> > >   mtd: spi-nor: Add support of sst26wf* flash ICs protection ops
> > >   mtd: spi-nor: add support for sst26wf016, sst26wf032
> > > 
> > >  drivers/mtd/spi-nor/spi-nor.c | 179 ++++++++++++++++++++++++++++++++++++++++++
> > >  include/linux/mtd/spi-nor.h   |   4 +
> > >  2 files changed, 183 insertions(+)
> > >   
> 
>
Tudor Ambarus Nov. 22, 2018, 5:45 p.m. UTC | #4
Hi, Eugeniy,

This is just to let you know that I'm getting familiar with the individual block
lock support. You'll have my review in the first part of next week.

Thank you for your patience,
ta

On 11/19/2018 05:25 PM, Eugeniy Paltsev wrote:
> Hi Boris,
> 
> As 4.20-rc1 is already out I guess you can pick this patches to spi-nor/next?
> 
> Thanks.
> 
> On Mon, 2018-10-22 at 15:56 +0200, Boris Brezillon wrote:
>> +Tudor
>>
>> Hi Eugeniy,
>>
>> Sorry, it's already too late for 4.20, and I won't apply patches to the
>> spi-nor/next branch before 4.20-rc1 is out.
>>
>> Tudor, Marek, can I have a Reviewed-by/Acked-by on this patchset?
>>
>> Thanks,
>>
>> Boris
>>
>>>
>>> On Mon, 2018-09-10 at 14:46 +0300, Eugeniy Paltsev wrote:
>>>> Add support for the SST sst26wf016 and sst26wf032 flash IC:
>>>>
>>>> sst26wf*** flash series block protection implementation differs from other
>>>> SST series, so we add implementation for sst26wf*** lock/unlock/is_locked
>>>> functions.
>>>>
>>>> Add sst26wf016 and sst26wf032 flash IC info to spi_flash_ids list.
>>>>
>>>> Eugeniy Paltsev (2):
>>>>   mtd: spi-nor: Add support of sst26wf* flash ICs protection ops
>>>>   mtd: spi-nor: add support for sst26wf016, sst26wf032
>>>>
>>>>  drivers/mtd/spi-nor/spi-nor.c | 179 ++++++++++++++++++++++++++++++++++++++++++
>>>>  include/linux/mtd/spi-nor.h   |   4 +
>>>>  2 files changed, 183 insertions(+)
>>>>   
>>
>>