Message ID | 20180224175950.10907-1-kabel@blackhole.sk |
---|---|
State | Superseded |
Delegated to: | John Crispin |
Headers | show |
Series | [LEDE-DEV] ramips: fix mt7620 sdhci OF match variable name | expand |
On 24/02/18 18:59, Marek BehĂșn wrote: > The variable rt288x_wdt_match is not event present in the file the > patch is creating, 4 lines above the variable is called > mt7620_sdhci_match instead. Seems like someone forgot to change > name of the variable when copying the OF definition code from watchdog > driver. > > Signed-off-by: Marek Behun <kabel@blackhole.sk> oh dear, you found a real nice copy pasta gem there :-D > --- > .../patches-4.14/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch | 2 +- > .../patches-4.9/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/linux/ramips/patches-4.14/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch b/target/linux/ramips/patches-4.14/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch > index d3a088b736..b0d635f87f 100644 > --- a/target/linux/ramips/patches-4.14/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch > +++ b/target/linux/ramips/patches-4.14/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch > @@ -4748,7 +4748,7 @@ Signed-off-by: John Crispin <blogic@openwrt.org> > + { .compatible = "ralink,mt7620-sdhci" }, > + {}, > +}; > -+MODULE_DEVICE_TABLE(of, rt288x_wdt_match); > ++MODULE_DEVICE_TABLE(of, mt7620_sdhci_match); > + > +static struct platform_driver mt_msdc_driver = { > + .probe = msdc_drv_probe, > diff --git a/target/linux/ramips/patches-4.9/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch b/target/linux/ramips/patches-4.9/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch > index 004ac239db..5559ed8eab 100644 > --- a/target/linux/ramips/patches-4.9/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch > +++ b/target/linux/ramips/patches-4.9/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch > @@ -4748,7 +4748,7 @@ Signed-off-by: John Crispin <blogic@openwrt.org> > + { .compatible = "ralink,mt7620-sdhci" }, > + {}, > +}; > -+MODULE_DEVICE_TABLE(of, rt288x_wdt_match); > ++MODULE_DEVICE_TABLE(of, mt7620_sdhci_match); > + > +static struct platform_driver mt_msdc_driver = { > + .probe = msdc_drv_probe,
diff --git a/target/linux/ramips/patches-4.14/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch b/target/linux/ramips/patches-4.14/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch index d3a088b736..b0d635f87f 100644 --- a/target/linux/ramips/patches-4.14/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch +++ b/target/linux/ramips/patches-4.14/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch @@ -4748,7 +4748,7 @@ Signed-off-by: John Crispin <blogic@openwrt.org> + { .compatible = "ralink,mt7620-sdhci" }, + {}, +}; -+MODULE_DEVICE_TABLE(of, rt288x_wdt_match); ++MODULE_DEVICE_TABLE(of, mt7620_sdhci_match); + +static struct platform_driver mt_msdc_driver = { + .probe = msdc_drv_probe, diff --git a/target/linux/ramips/patches-4.9/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch b/target/linux/ramips/patches-4.9/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch index 004ac239db..5559ed8eab 100644 --- a/target/linux/ramips/patches-4.9/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch +++ b/target/linux/ramips/patches-4.9/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch @@ -4748,7 +4748,7 @@ Signed-off-by: John Crispin <blogic@openwrt.org> + { .compatible = "ralink,mt7620-sdhci" }, + {}, +}; -+MODULE_DEVICE_TABLE(of, rt288x_wdt_match); ++MODULE_DEVICE_TABLE(of, mt7620_sdhci_match); + +static struct platform_driver mt_msdc_driver = { + .probe = msdc_drv_probe,
The variable rt288x_wdt_match is not event present in the file the patch is creating, 4 lines above the variable is called mt7620_sdhci_match instead. Seems like someone forgot to change name of the variable when copying the OF definition code from watchdog driver. Signed-off-by: Marek Behun <kabel@blackhole.sk> --- .../patches-4.14/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch | 2 +- .../patches-4.9/0046-mmc-MIPS-ralink-add-sdhci-for-mt7620a-SoC.patch | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)