| Message ID | 20180101155833.24131-1-hauke@hauke-m.de |
|---|---|
| State | Accepted |
| Delegated to: | John Crispin |
| Headers | show |
| Series | [LEDE-DEV] layerscape: activate fpu feature | expand |
Hi Yangbo Lu, Can you please test this patch on your hardware. I send a mail to yangbo.lu@nxp.com who is listed as the current layerscape maintainer, but it was rejected by your mail server: <cyangbo.lu@nxp.com>: host nxp-com.mail.protection.outlook.com[213.199.154.170] said: 550 5.4.1 [cyangbo.lu@nxp.com]: Recipient address rejected: Access denied [DB5EUR01FT058.eop-EUR01.prod.protection.outlook.com] (in reply to RCPT TO command) Are you the current maintainer? If so can you please send a patch to fix this please. Hauke On 01/01/2018 04:58 PM, Hauke Mehrtens wrote: > The CPU sub type was set to a CPU version with FPU, but the FPU feature > was not activated before, so a soft float toolchain was created. > Activate also the FPU feature to create the correct toolchain. > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > --- > > This probably fixes a problem, but I do not have any layerscape > hardware, could someone please test this on real hardware and report > back if it still works. > > A complete rebuild incl. toolchain is needed. > > target/linux/layerscape/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/linux/layerscape/Makefile b/target/linux/layerscape/Makefile > index 67da8449aa..bd91556ef4 100644 > --- a/target/linux/layerscape/Makefile > +++ b/target/linux/layerscape/Makefile > @@ -10,7 +10,7 @@ BOARD:=layerscape > BOARDNAME:=NXP Layerscape > DEVICE_TYPE:=developerboard > KERNEL_PATCHVER:=4.9 > -FEATURES:=squashfs nand usb pcie gpio > +FEATURES:=squashfs nand usb pcie gpio fpu > SUBTARGETS:=armv8_64b armv8_32b > MAINTAINER:=Yangbo Lu <yangbo.lu@nxp.com> > >
On 2/1/18 2:58 am, Hauke Mehrtens wrote: > The CPU sub type was set to a CPU version with FPU, but the FPU feature > was not activated before, so a soft float toolchain was created. > Activate also the FPU feature to create the correct toolchain. > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > --- > > This probably fixes a problem, but I do not have any layerscape > hardware, could someone please test this on real hardware and report > back if it still works. > > A complete rebuild incl. toolchain is needed. > > target/linux/layerscape/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Hi Hauke, Tested on the LS1043 and it is working fine. Regards, Matt
Hi Hauke, The layerscape maintainer info should be no problem. You just sent wrong email address to me. (cyangbo.lu@nxp.com) MAINTAINER:=Yangbo Lu <yangbo.lu@nxp.com> I will cherry-pick this patch to our internal LEDE git tree. Test team will test all devices, and we will have a release on our github by end of January. https://github.com/qoriq-open-source/LEDE-source I will send related patches to community after release. Thanks a lot. Best regards, Yangbo Lu > -----Original Message----- > From: Hauke Mehrtens [mailto:hauke@hauke-m.de] > Sent: 2018年1月2日 0:04 > To: lede-dev@lists.infradead.org; Y.b. Lu <yangbo.lu@nxp.com> > Subject: Re: [PATCH] layerscape: activate fpu feature > > Hi Yangbo Lu, > > Can you please test this patch on your hardware. > > > I send a mail to yangbo.lu@nxp.com who is listed as the current layerscape > maintainer, but it was rejected by your mail server: > > <cyangbo.lu@nxp.com>: host > nxp-com.mail.protection.outlook.com[213.199.154.170] said: 550 5.4.1 > [cyangbo.lu@nxp.com]: Recipient address rejected: Access denied > [DB5EUR01FT058.eop-EUR01.prod.protection.outlook.com] (in reply to RCPT > TO command) > > Are you the current maintainer? If so can you please send a patch to fix this > please. > > Hauke > > > On 01/01/2018 04:58 PM, Hauke Mehrtens wrote: > > The CPU sub type was set to a CPU version with FPU, but the FPU > > feature was not activated before, so a soft float toolchain was created. > > Activate also the FPU feature to create the correct toolchain. > > > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > > --- > > > > This probably fixes a problem, but I do not have any layerscape > > hardware, could someone please test this on real hardware and report > > back if it still works. > > > > A complete rebuild incl. toolchain is needed. > > > > target/linux/layerscape/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/target/linux/layerscape/Makefile > > b/target/linux/layerscape/Makefile > > index 67da8449aa..bd91556ef4 100644 > > --- a/target/linux/layerscape/Makefile > > +++ b/target/linux/layerscape/Makefile > > @@ -10,7 +10,7 @@ BOARD:=layerscape > > BOARDNAME:=NXP Layerscape > > DEVICE_TYPE:=developerboard > > KERNEL_PATCHVER:=4.9 > > -FEATURES:=squashfs nand usb pcie gpio > > +FEATURES:=squashfs nand usb pcie gpio fpu > > SUBTARGETS:=armv8_64b armv8_32b > > MAINTAINER:=Yangbo Lu <yangbo.lu@nxp.com> > > > >
On 01/03/2018 04:21 AM, Y.b. Lu wrote: > Hi Hauke, > > The layerscape maintainer info should be no problem. You just sent wrong email address to me. (cyangbo.lu@nxp.com) > MAINTAINER:=Yangbo Lu <yangbo.lu@nxp.com> Will you send a patch to update the Maintainer? > I will cherry-pick this patch to our internal LEDE git tree. Test team will test all devices, and we will have a release on our github by end of January. > https://github.com/qoriq-open-source/LEDE-source John already merged this patch, see here: https://git.lede-project.org/?p=openwrt/openwrt.git;a=commitdiff;h=597de6904c39e02a8aa008f50ff19c6793117194 Mathew McBride also tested this on his LS1043 board and did not notice any problems. Hauke > > I will send related patches to community after release. > Thanks a lot. > > > Best regards, > Yangbo Lu > > >> -----Original Message----- >> From: Hauke Mehrtens [mailto:hauke@hauke-m.de] >> Sent: 2018年1月2日 0:04 >> To: lede-dev@lists.infradead.org; Y.b. Lu <yangbo.lu@nxp.com> >> Subject: Re: [PATCH] layerscape: activate fpu feature >> >> Hi Yangbo Lu, >> >> Can you please test this patch on your hardware. >> >> >> I send a mail to yangbo.lu@nxp.com who is listed as the current layerscape >> maintainer, but it was rejected by your mail server: >> >> <cyangbo.lu@nxp.com>: host >> nxp-com.mail.protection.outlook.com[213.199.154.170] said: 550 5.4.1 >> [cyangbo.lu@nxp.com]: Recipient address rejected: Access denied >> [DB5EUR01FT058.eop-EUR01.prod.protection.outlook.com] (in reply to RCPT >> TO command) >> >> Are you the current maintainer? If so can you please send a patch to fix this >> please. >> >> Hauke >> >> >> On 01/01/2018 04:58 PM, Hauke Mehrtens wrote: >>> The CPU sub type was set to a CPU version with FPU, but the FPU >>> feature was not activated before, so a soft float toolchain was created. >>> Activate also the FPU feature to create the correct toolchain. >>> >>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> >>> --- >>> >>> This probably fixes a problem, but I do not have any layerscape >>> hardware, could someone please test this on real hardware and report >>> back if it still works. >>> >>> A complete rebuild incl. toolchain is needed. >>> >>> target/linux/layerscape/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/target/linux/layerscape/Makefile >>> b/target/linux/layerscape/Makefile >>> index 67da8449aa..bd91556ef4 100644 >>> --- a/target/linux/layerscape/Makefile >>> +++ b/target/linux/layerscape/Makefile >>> @@ -10,7 +10,7 @@ BOARD:=layerscape >>> BOARDNAME:=NXP Layerscape >>> DEVICE_TYPE:=developerboard >>> KERNEL_PATCHVER:=4.9 >>> -FEATURES:=squashfs nand usb pcie gpio >>> +FEATURES:=squashfs nand usb pcie gpio fpu >>> SUBTARGETS:=armv8_64b armv8_32b >>> MAINTAINER:=Yangbo Lu <yangbo.lu@nxp.com> >>> >>> >
Hi Hauke, > -----Original Message----- > From: Hauke Mehrtens [mailto:hauke@hauke-m.de] > Sent: 2018年1月4日 4:47 > To: Y.b. Lu <yangbo.lu@nxp.com>; lede-dev@lists.infradead.org > Subject: Re: [PATCH] layerscape: activate fpu feature > > On 01/03/2018 04:21 AM, Y.b. Lu wrote: > > Hi Hauke, > > > > The layerscape maintainer info should be no problem. You just sent > > wrong email address to me. (cyangbo.lu@nxp.com) MAINTAINER:=Yangbo Lu > > <yangbo.lu@nxp.com> > > Will you send a patch to update the Maintainer? [Y.b. Lu] I meant the maintainer was correct. You just sent email with wrong address :) > > > I will cherry-pick this patch to our internal LEDE git tree. Test team will test all > devices, and we will have a release on our github by end of January. > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit > > > hub.com%2Fqoriq-open-source%2FLEDE-source&data=02%7C01%7Cyangbo.lu > %40n > > > xp.com%7Ce1ecb397ca55445aaea408d552eb1e83%7C686ea1d3bc2b4c6fa92c > d99c5c > > > 301635%7C0%7C1%7C636506092143122970&sdata=7ZtgG18hvx24ocAc6iIn > 86j9P1hk > > HCksRkbOoQQnJnk%3D&reserved=0 > > John already merged this patch, see here: > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.le > de-project.org%2F%3Fp%3Dopenwrt%2Fopenwrt.git%3Ba%3Dcommitdiff%3Bh > %3D597de6904c39e02a8aa008f50ff19c6793117194&data=02%7C01%7Cyang > bo.lu%40nxp.com%7Ce1ecb397ca55445aaea408d552eb1e83%7C686ea1d3bc > 2b4c6fa92cd99c5c301635%7C0%7C1%7C636506092143122970&sdata=W3D > 0mjILpqw6yQwa%2FOd3xGbj%2BsA7GLMeVv3fJ1wvbEI%3D&reserved=0 > > Mathew McBride also tested this on his LS1043 board and did not notice any > problems. [Y.b. Lu] That's great. I will use the latest source code for our next release and will test all boards. > > Hauke > > > > > I will send related patches to community after release. > > Thanks a lot. > > > > > > Best regards, > > Yangbo Lu > > > > > >> -----Original Message----- > >> From: Hauke Mehrtens [mailto:hauke@hauke-m.de] > >> Sent: 2018年1月2日 0:04 > >> To: lede-dev@lists.infradead.org; Y.b. Lu <yangbo.lu@nxp.com> > >> Subject: Re: [PATCH] layerscape: activate fpu feature > >> > >> Hi Yangbo Lu, > >> > >> Can you please test this patch on your hardware. > >> > >> > >> I send a mail to yangbo.lu@nxp.com who is listed as the current > >> layerscape maintainer, but it was rejected by your mail server: > >> > >> <cyangbo.lu@nxp.com>: host > >> nxp-com.mail.protection.outlook.com[213.199.154.170] said: 550 5.4.1 > >> [cyangbo.lu@nxp.com]: Recipient address rejected: Access denied > >> [DB5EUR01FT058.eop-EUR01.prod.protection.outlook.com] (in reply to > >> RCPT TO command) > >> > >> Are you the current maintainer? If so can you please send a patch to > >> fix this please. > >> > >> Hauke > >> > >> > >> On 01/01/2018 04:58 PM, Hauke Mehrtens wrote: > >>> The CPU sub type was set to a CPU version with FPU, but the FPU > >>> feature was not activated before, so a soft float toolchain was created. > >>> Activate also the FPU feature to create the correct toolchain. > >>> > >>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > >>> --- > >>> > >>> This probably fixes a problem, but I do not have any layerscape > >>> hardware, could someone please test this on real hardware and report > >>> back if it still works. > >>> > >>> A complete rebuild incl. toolchain is needed. > >>> > >>> target/linux/layerscape/Makefile | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/target/linux/layerscape/Makefile > >>> b/target/linux/layerscape/Makefile > >>> index 67da8449aa..bd91556ef4 100644 > >>> --- a/target/linux/layerscape/Makefile > >>> +++ b/target/linux/layerscape/Makefile > >>> @@ -10,7 +10,7 @@ BOARD:=layerscape > >>> BOARDNAME:=NXP Layerscape > >>> DEVICE_TYPE:=developerboard > >>> KERNEL_PATCHVER:=4.9 > >>> -FEATURES:=squashfs nand usb pcie gpio > >>> +FEATURES:=squashfs nand usb pcie gpio fpu > >>> SUBTARGETS:=armv8_64b armv8_32b > >>> MAINTAINER:=Yangbo Lu <yangbo.lu@nxp.com> > >>> > >>> > >
diff --git a/target/linux/layerscape/Makefile b/target/linux/layerscape/Makefile index 67da8449aa..bd91556ef4 100644 --- a/target/linux/layerscape/Makefile +++ b/target/linux/layerscape/Makefile @@ -10,7 +10,7 @@ BOARD:=layerscape BOARDNAME:=NXP Layerscape DEVICE_TYPE:=developerboard KERNEL_PATCHVER:=4.9 -FEATURES:=squashfs nand usb pcie gpio +FEATURES:=squashfs nand usb pcie gpio fpu SUBTARGETS:=armv8_64b armv8_32b MAINTAINER:=Yangbo Lu <yangbo.lu@nxp.com>
The CPU sub type was set to a CPU version with FPU, but the FPU feature was not activated before, so a soft float toolchain was created. Activate also the FPU feature to create the correct toolchain. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- This probably fixes a problem, but I do not have any layerscape hardware, could someone please test this on real hardware and report back if it still works. A complete rebuild incl. toolchain is needed. target/linux/layerscape/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)