diff mbox series

[LEDE-DEV,1/3] busybox: enable flock by default

Message ID 20171214215350.4776-1-roman@advem.lv
State Changes Requested
Headers show
Series protect init scripts from races | expand

Commit Message

Roman Yeryomin Dec. 14, 2017, 9:53 p.m. UTC 
Signed-off-by: Roman Yeryomin <roman@advem.lv>
---
 package/utils/busybox/Config-defaults.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hauke Mehrtens Dec. 16, 2017, 12:52 p.m. UTC | #1 
On 12/14/2017 10:53 PM, Roman Yeryomin wrote:
> Signed-off-by: Roman Yeryomin <roman@advem.lv>

Please extend your description, why you need flock and also do a small
size comparison on one target between a busybox with the default config
and the one with your patch applied.

Hauke

> ---
>  package/utils/busybox/Config-defaults.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in
> index 2a8d9dd397..6fc5093055 100644
> --- a/package/utils/busybox/Config-defaults.in
> +++ b/package/utils/busybox/Config-defaults.in
> @@ -1497,7 +1497,7 @@ config BUSYBOX_DEFAULT_FINDFS
>  	default n
>  config BUSYBOX_DEFAULT_FLOCK
>  	bool
> -	default n
> +	default y
>  config BUSYBOX_DEFAULT_FDFLUSH
>  	bool
>  	default n
>
diff mbox series

Patch

diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in
index 2a8d9dd397..6fc5093055 100644
--- a/package/utils/busybox/Config-defaults.in
+++ b/package/utils/busybox/Config-defaults.in
@@ -1497,7 +1497,7 @@  config BUSYBOX_DEFAULT_FINDFS
 	default n
 config BUSYBOX_DEFAULT_FLOCK
 	bool
-	default n
+	default y
 config BUSYBOX_DEFAULT_FDFLUSH
 	bool
 	default n