| Message ID | 20171209014443.5992-1-moritzwarning@web.de |
|---|---|
| State | Accepted |
| Delegated to: | Mathias Kresin |
| Headers | show |
| Series | [LEDE-DEV] brcm47xx: proper region code in image name | expand |
Didn't you want to use 'us' as image identifier? In your patch it is still north america just shortened to 2 letters. kind regards txt.file Moritz Warning: > Replace 'north-america' by 'us' and remove 'other-regions' in image files for Netgear WGR614 v10. > > Signed-off-by: Moritz Warning <moritzwarning@web.de> > --- > target/linux/brcm47xx/image/Makefile | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/target/linux/brcm47xx/image/Makefile b/target/linux/brcm47xx/image/Makefile > index 8c681ac345..ccd6f4dc44 100644 > --- a/target/linux/brcm47xx/image/Makefile > +++ b/target/linux/brcm47xx/image/Makefile > @@ -806,21 +806,21 @@ define Device/linksys-e4200-v1 > endef > TARGET_DEVICES += linksys-e4200-v1 > > -define Device/netgear-wgr614-v10_north-america > +define Device/netgear-wgr614-v10-na > DEVICE_TITLE := Netgear WGR614 v10 North America > $(Device/netgear) > NETGEAR_BOARD_ID := U12H139T01_NETGEAR > NETGEAR_REGION := 2 > endef > -TARGET_DEVICES += netgear-wgr614-v10_north-america > +TARGET_DEVICES += netgear-wgr614-v10-na > > -define Device/netgear-wgr614-v10_other-regions > - DEVICE_TITLE := Netgear WGR614 v10 Other Regions > +define Device/netgear-wgr614-v10 > + DEVICE_TITLE := Netgear WGR614 v10 > $(Device/netgear) > NETGEAR_BOARD_ID := U12H139T01_NETGEAR > NETGEAR_REGION := 1 > endef > -TARGET_DEVICES += netgear-wgr614-v10_other-regions > +TARGET_DEVICES += netgear-wgr614-v10 > > define Device/netgear-wn2500rp-v1 > DEVICE_TITLE := Netgear WN2500RP v1 > @@ -910,23 +910,23 @@ define Device/netgear-wnr2000v2 > endef > TARGET_DEVICES += netgear-wnr2000v2 > > -define Device/netgear-wnr3500l-v1-north-america > +define Device/netgear-wnr3500l-v1-na > DEVICE_TITLE := Netgear WNR3500L v1 North America > DEVICE_PACKAGES := kmod-b43 $(USB2_PACKAGES) > $(Device/netgear) > NETGEAR_BOARD_ID := U12H136T99_NETGEAR > NETGEAR_REGION := 2 > endef > -TARGET_DEVICES += netgear-wnr3500l-v1-north-america > +TARGET_DEVICES += netgear-wnr3500l-v1-na > > -define Device/netgear-wnr3500l-v1-other-regions > +define Device/netgear-wnr3500l-v1 > DEVICE_TITLE := Netgear WNR3500L v1 Other Regions > DEVICE_PACKAGES := kmod-b43 $(USB2_PACKAGES) > $(Device/netgear) > NETGEAR_BOARD_ID := U12H136T99_NETGEAR > NETGEAR_REGION := 1 > endef > -TARGET_DEVICES += netgear-wnr3500l-v1-other-regions > +TARGET_DEVICES += netgear-wnr3500l-v1 > > define Device/netgear-wnr3500l-v2 > DEVICE_TITLE := Netgear WNR3500L v2 >
11.12.2017 20:37, txt.file: > Didn't you want to use 'us' as image identifier? In your patch it is > still north america just shortened to 2 letters. > > kind regards > txt.file Please don't top-post. The way it was done is correct. North america != us. I fixed the commit message before I merged the patch. Mathias > > Moritz Warning: >> Replace 'north-america' by 'us' and remove 'other-regions' in image files for Netgear WGR614 v10. >> >> Signed-off-by: Moritz Warning <moritzwarning@web.de> >> --- >> target/linux/brcm47xx/image/Makefile | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/target/linux/brcm47xx/image/Makefile b/target/linux/brcm47xx/image/Makefile >> index 8c681ac345..ccd6f4dc44 100644 >> --- a/target/linux/brcm47xx/image/Makefile >> +++ b/target/linux/brcm47xx/image/Makefile >> @@ -806,21 +806,21 @@ define Device/linksys-e4200-v1 >> endef >> TARGET_DEVICES += linksys-e4200-v1 >> >> -define Device/netgear-wgr614-v10_north-america >> +define Device/netgear-wgr614-v10-na >> DEVICE_TITLE := Netgear WGR614 v10 North America >> $(Device/netgear) >> NETGEAR_BOARD_ID := U12H139T01_NETGEAR >> NETGEAR_REGION := 2 >> endef >> -TARGET_DEVICES += netgear-wgr614-v10_north-america >> +TARGET_DEVICES += netgear-wgr614-v10-na >> >> -define Device/netgear-wgr614-v10_other-regions >> - DEVICE_TITLE := Netgear WGR614 v10 Other Regions >> +define Device/netgear-wgr614-v10 >> + DEVICE_TITLE := Netgear WGR614 v10 >> $(Device/netgear) >> NETGEAR_BOARD_ID := U12H139T01_NETGEAR >> NETGEAR_REGION := 1 >> endef >> -TARGET_DEVICES += netgear-wgr614-v10_other-regions >> +TARGET_DEVICES += netgear-wgr614-v10 >> >> define Device/netgear-wn2500rp-v1 >> DEVICE_TITLE := Netgear WN2500RP v1 >> @@ -910,23 +910,23 @@ define Device/netgear-wnr2000v2 >> endef >> TARGET_DEVICES += netgear-wnr2000v2 >> >> -define Device/netgear-wnr3500l-v1-north-america >> +define Device/netgear-wnr3500l-v1-na >> DEVICE_TITLE := Netgear WNR3500L v1 North America >> DEVICE_PACKAGES := kmod-b43 $(USB2_PACKAGES) >> $(Device/netgear) >> NETGEAR_BOARD_ID := U12H136T99_NETGEAR >> NETGEAR_REGION := 2 >> endef >> -TARGET_DEVICES += netgear-wnr3500l-v1-north-america >> +TARGET_DEVICES += netgear-wnr3500l-v1-na >> >> -define Device/netgear-wnr3500l-v1-other-regions >> +define Device/netgear-wnr3500l-v1 >> DEVICE_TITLE := Netgear WNR3500L v1 Other Regions >> DEVICE_PACKAGES := kmod-b43 $(USB2_PACKAGES) >> $(Device/netgear) >> NETGEAR_BOARD_ID := U12H136T99_NETGEAR >> NETGEAR_REGION := 1 >> endef >> -TARGET_DEVICES += netgear-wnr3500l-v1-other-regions >> +TARGET_DEVICES += netgear-wnr3500l-v1 >> >> define Device/netgear-wnr3500l-v2 >> DEVICE_TITLE := Netgear WNR3500L v2 >> > > > > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev >
diff --git a/target/linux/brcm47xx/image/Makefile b/target/linux/brcm47xx/image/Makefile index 8c681ac345..ccd6f4dc44 100644 --- a/target/linux/brcm47xx/image/Makefile +++ b/target/linux/brcm47xx/image/Makefile @@ -806,21 +806,21 @@ define Device/linksys-e4200-v1 endef TARGET_DEVICES += linksys-e4200-v1 -define Device/netgear-wgr614-v10_north-america +define Device/netgear-wgr614-v10-na DEVICE_TITLE := Netgear WGR614 v10 North America $(Device/netgear) NETGEAR_BOARD_ID := U12H139T01_NETGEAR NETGEAR_REGION := 2 endef -TARGET_DEVICES += netgear-wgr614-v10_north-america +TARGET_DEVICES += netgear-wgr614-v10-na -define Device/netgear-wgr614-v10_other-regions - DEVICE_TITLE := Netgear WGR614 v10 Other Regions +define Device/netgear-wgr614-v10 + DEVICE_TITLE := Netgear WGR614 v10 $(Device/netgear) NETGEAR_BOARD_ID := U12H139T01_NETGEAR NETGEAR_REGION := 1 endef -TARGET_DEVICES += netgear-wgr614-v10_other-regions +TARGET_DEVICES += netgear-wgr614-v10 define Device/netgear-wn2500rp-v1 DEVICE_TITLE := Netgear WN2500RP v1 @@ -910,23 +910,23 @@ define Device/netgear-wnr2000v2 endef TARGET_DEVICES += netgear-wnr2000v2 -define Device/netgear-wnr3500l-v1-north-america +define Device/netgear-wnr3500l-v1-na DEVICE_TITLE := Netgear WNR3500L v1 North America DEVICE_PACKAGES := kmod-b43 $(USB2_PACKAGES) $(Device/netgear) NETGEAR_BOARD_ID := U12H136T99_NETGEAR NETGEAR_REGION := 2 endef -TARGET_DEVICES += netgear-wnr3500l-v1-north-america +TARGET_DEVICES += netgear-wnr3500l-v1-na -define Device/netgear-wnr3500l-v1-other-regions +define Device/netgear-wnr3500l-v1 DEVICE_TITLE := Netgear WNR3500L v1 Other Regions DEVICE_PACKAGES := kmod-b43 $(USB2_PACKAGES) $(Device/netgear) NETGEAR_BOARD_ID := U12H136T99_NETGEAR NETGEAR_REGION := 1 endef -TARGET_DEVICES += netgear-wnr3500l-v1-other-regions +TARGET_DEVICES += netgear-wnr3500l-v1 define Device/netgear-wnr3500l-v2 DEVICE_TITLE := Netgear WNR3500L v2
Replace 'north-america' by 'us' and remove 'other-regions' in image files for Netgear WGR614 v10. Signed-off-by: Moritz Warning <moritzwarning@web.de> --- target/linux/brcm47xx/image/Makefile | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)