| Message ID | 20170930115655.29896-1-hauke@hauke-m.de |
|---|---|
| State | Accepted |
| Delegated to: | Hauke Mehrtens |
| Headers | show |
| Series | [LEDE-DEV] base-files: create /etc/config/ directory | expand |
On 30-09-17 14:56, Hauke Mehrtens wrote: > The /bin/config_generate script and some other scripts are assuming the > /etc/config directory exists in the image. This is true in case for > example the package firewall, dropbear or dnsmasq are included, which > are adding the files under /etc/config/. Without any of these package > the system will not boot up fully because the /etc/config/ directory is > missing and some init scripts just fail. > > Make sure all images with the base-files contain a /etc/config/ > directory. > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > --- > package/base-files/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/base-files/Makefile b/package/base-files/Makefile > index 0c0c1cee30..33092a77cc 100644 > --- a/package/base-files/Makefile > +++ b/package/base-files/Makefile > @@ -149,6 +149,7 @@ define Package/base-files/install > mkdir -p $(1)/CONTROL > mkdir -p $(1)/dev > mkdir -p $(1)/etc/crontabs > + mkdir -p $(1)/etc/config Minor nit: config comes before crontabs in the alphabet ;-) Stijn
On 30/09/17 13:56, Hauke Mehrtens wrote: > The /bin/config_generate script and some other scripts are assuming the > /etc/config directory exists in the image. This is true in case for > example the package firewall, dropbear or dnsmasq are included, which > are adding the files under /etc/config/. Without any of these package > the system will not boot up fully because the /etc/config/ directory is > missing and some init scripts just fail. > > Make sure all images with the base-files contain a /etc/config/ > directory. > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> Acked-by: John Crispin <john@phrozen.org> > --- > package/base-files/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/base-files/Makefile b/package/base-files/Makefile > index 0c0c1cee30..33092a77cc 100644 > --- a/package/base-files/Makefile > +++ b/package/base-files/Makefile > @@ -149,6 +149,7 @@ define Package/base-files/install > mkdir -p $(1)/CONTROL > mkdir -p $(1)/dev > mkdir -p $(1)/etc/crontabs > + mkdir -p $(1)/etc/config > mkdir -p $(1)/etc/rc.d > mkdir -p $(1)/overlay > mkdir -p $(1)/lib/firmware
diff --git a/package/base-files/Makefile b/package/base-files/Makefile index 0c0c1cee30..33092a77cc 100644 --- a/package/base-files/Makefile +++ b/package/base-files/Makefile @@ -149,6 +149,7 @@ define Package/base-files/install mkdir -p $(1)/CONTROL mkdir -p $(1)/dev mkdir -p $(1)/etc/crontabs + mkdir -p $(1)/etc/config mkdir -p $(1)/etc/rc.d mkdir -p $(1)/overlay mkdir -p $(1)/lib/firmware
The /bin/config_generate script and some other scripts are assuming the /etc/config directory exists in the image. This is true in case for example the package firewall, dropbear or dnsmasq are included, which are adding the files under /etc/config/. Without any of these package the system will not boot up fully because the /etc/config/ directory is missing and some init scripts just fail. Make sure all images with the base-files contain a /etc/config/ directory. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- package/base-files/Makefile | 1 + 1 file changed, 1 insertion(+)