diff mbox series

[LEDE-DEV] brcm47xx: Fix sysupgrade with E1200v1

Message ID 20170915230919.7466-1-rosenp@gmail.com
State Accepted
Delegated to: Hauke Mehrtens
Headers show
Series [LEDE-DEV] brcm47xx: Fix sysupgrade with E1200v1 | expand

Commit Message

Rosen Penev Sept. 15, 2017, 11:09 p.m. UTC
Entry was missing for some reason.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 target/linux/brcm47xx/base-files/lib/upgrade/platform.sh | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Lippers-Hollmann Sept. 24, 2017, 10:45 p.m. UTC | #1
Hi

On 2017-09-15, Rosen Penev wrote:
[...]
> --- a/target/linux/brcm47xx/base-files/lib/upgrade/platform.sh
> +++ b/target/linux/brcm47xx/base-files/lib/upgrade/platform.sh
> @@ -34,6 +34,7 @@ platform_expected_image() {
>  		"Linksys E1000 V1")	echo "cybertan E100"; return;;
>  		"Linksys E1000 V2")	echo "cybertan E100"; return;;
>  		"Linksys E1000 V2.1")	echo "cybertan E100"; return;;
> +		"Linksys E1200 V1")	echo "cybetran E120"; return;;

Spelled as "cybetran", as committed in
	https://git.lede-project.org/?p=source.git;a=commitdiff;h=31e9445b7e614f54daa0caf3148e223d088311ab
looks an awful lot like a typo, are you sure that this is correct and
passes testing on an actual device.

Regards
	Stefan Lippers-Hollmann
Hauke Mehrtens Sept. 25, 2017, 9:31 p.m. UTC | #2
On 09/25/2017 12:45 AM, Stefan Lippers-Hollmann wrote:
> Hi
> 
> On 2017-09-15, Rosen Penev wrote:
> [...]
>> --- a/target/linux/brcm47xx/base-files/lib/upgrade/platform.sh
>> +++ b/target/linux/brcm47xx/base-files/lib/upgrade/platform.sh
>> @@ -34,6 +34,7 @@ platform_expected_image() {
>>  		"Linksys E1000 V1")	echo "cybertan E100"; return;;
>>  		"Linksys E1000 V2")	echo "cybertan E100"; return;;
>>  		"Linksys E1000 V2.1")	echo "cybertan E100"; return;;
>> +		"Linksys E1200 V1")	echo "cybetran E120"; return;;
> 
> Spelled as "cybetran", as committed in
> 	https://git.lede-project.org/?p=source.git;a=commitdiff;h=31e9445b7e614f54daa0caf3148e223d088311ab
> looks an awful lot like a typo, are you sure that this is correct and
> passes testing on an actual device.
> 
> Regards
> 	Stefan Lippers-Hollmann

Hi,

I reverted that commit, The arch code is not even able to detect a
device named "Linksys E1200 V1".

@Rosen please also ad code to detect this device to arch/mips/brcm47xx/
in the Linux kernel.

Hauke
diff mbox series

Patch

diff --git a/target/linux/brcm47xx/base-files/lib/upgrade/platform.sh b/target/linux/brcm47xx/base-files/lib/upgrade/platform.sh
index dfd4e97ed2..f64e19b213 100644
--- a/target/linux/brcm47xx/base-files/lib/upgrade/platform.sh
+++ b/target/linux/brcm47xx/base-files/lib/upgrade/platform.sh
@@ -34,6 +34,7 @@  platform_expected_image() {
 		"Linksys E1000 V1")	echo "cybertan E100"; return;;
 		"Linksys E1000 V2")	echo "cybertan E100"; return;;
 		"Linksys E1000 V2.1")	echo "cybertan E100"; return;;
+		"Linksys E1200 V1")	echo "cybetran E120"; return;;
 		"Linksys E1200 V2")	echo "cybertan E122"; return;;
 		"Linksys E2000 V1")	echo "cybertan 32XN"; return;;
 		"Linksys E3000 V1")	echo "cybertan 61XN"; return;;