| Message ID | 20170717221044.6714-4-hauke@hauke-m.de |
|---|---|
| State | Superseded |
| Delegated to: | Hauke Mehrtens |
| Headers | show |
On 18 July 2017 at 06:10, Hauke Mehrtens <hauke@hauke-m.de> wrote: > U-Boot 2017.07 complains if HOSTCPPFLAGS is referenced once too often. > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > --- > include/u-boot.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/u-boot.mk b/include/u-boot.mk > index 4b3ff69d6b..5fe3b42ba9 100644 > --- a/include/u-boot.mk > +++ b/include/u-boot.mk > @@ -42,7 +42,7 @@ TARGET_DEP = TARGET_$(BUILD_TARGET)$(if $(BUILD_SUBTARGET),_$(BUILD_SUBTARGET)) > > UBOOT_MAKE_FLAGS = \ > HOSTCC="$(HOSTCC)" \ > - HOSTCFLAGS='$(HOST_CFLAGS) $$$$(HOSTCPPFLAGS)' \ > + HOSTCFLAGS='$(HOST_CFLAGS) $$$(HOSTCPPFLAGS)' \ > HOSTLDFLAGS="" > Is it possible that the HOSTCPPFLAGS is actually a typo and can be removed? I cannot find other references to it both in the lede and u-boot repo. yousong > define Build/U-Boot/Target > -- > 2.11.0 > > > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev
On 07/18/2017 12:10 AM, Hauke Mehrtens wrote: > U-Boot 2017.07 complains if HOSTCPPFLAGS is referenced once too often. > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > --- > include/u-boot.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/u-boot.mk b/include/u-boot.mk > index 4b3ff69d6b..5fe3b42ba9 100644 > --- a/include/u-boot.mk > +++ b/include/u-boot.mk > @@ -42,7 +42,7 @@ TARGET_DEP = TARGET_$(BUILD_TARGET)$(if $(BUILD_SUBTARGET),_$(BUILD_SUBTARGET)) > > UBOOT_MAKE_FLAGS = \ > HOSTCC="$(HOSTCC)" \ > - HOSTCFLAGS='$(HOST_CFLAGS) $$$$(HOSTCPPFLAGS)' \ > + HOSTCFLAGS='$(HOST_CFLAGS) $$$(HOSTCPPFLAGS)' \ > HOSTLDFLAGS="" > > define Build/U-Boot/Target > Without this patch I am getting these warnings when building the sunxi u-boot: touch /home/hauke/openwrt/lede/build_dir/target-arm_cortex-a8+vfpv3_musl_eabi/u-boot-A10-OLinuXino-Lime/u-boot-2016.03/.built_check make -C /home/hauke/openwrt/lede/build_dir/target-arm_cortex-a8+vfpv3_musl_eabi/u-boot-A10-OLinuXino-Lime/u-boot-2016.03 CROSS_COMPILE=arm-openwrt-linux-muslgnueabi- DTC="/home/hauke/openwrt/lede/build_dir/target-arm_cortex-a8+vfpv3_musl_eabi/linux-sunxi/linux-4.4.74/scripts/dtc/dtc" HOSTCC="gcc" HOSTCFLAGS='-O2 -I/home/hauke/openwrt/lede/staging_dir/host/include -I/home/hauke/openwrt/lede/staging_dir/host/usr/include -I/home/hauke/openwrt/lede/staging_dir/hostpkg/include -I/home/hauke/openwrt/lede/staging_dir/target-arm_cortex-a8+vfpv3_musl_eabi/host/include $$(HOSTCPPFLAGS)' HOSTLDFLAGS="" make[3]: Entering directory '/home/hauke/openwrt/lede/build_dir/target-arm_cortex-a8+vfpv3_musl_eabi/u-boot-A10-OLinuXino-Lime/u-boot-2016.03' HOSTCC scripts/basic/fixdep /bin/sh: 1: HOSTCPPFLAGS: not found /bin/sh: 1: HOSTCPPFLAGS: not found With my patch it looks like this: touch /home/hauke/openwrt/lede/build_dir/target-arm_cortex-a8+vfpv3_musl_eabi/u-boot-A10-OLinuXino-Lime/u-boot-2016.03/.built_check make -C /home/hauke/openwrt/lede/build_dir/target-arm_cortex-a8+vfpv3_musl_eabi/u-boot-A10-OLinuXino-Lime/u-boot-2016.03 CROSS_COMPILE=arm-openwrt-linux-muslgnueabi- DTC="/home/hauke/openwrt/lede/build_dir/target-arm_cortex-a8+vfpv3_musl_eabi/linux-sunxi/linux-4.4.74/scripts/dtc/dtc" HOSTCC="gcc" HOSTCFLAGS='-O2 -I/home/hauke/openwrt/lede/staging_dir/host/include -I/home/hauke/openwrt/lede/staging_dir/host/usr/include -I/home/hauke/openwrt/lede/staging_dir/hostpkg/include -I/home/hauke/openwrt/lede/staging_dir/target-arm_cortex-a8+vfpv3_musl_eabi/host/include $' HOSTLDFLAGS="" make[3]: Entering directory '/home/hauke/openwrt/lede/build_dir/target-arm_cortex-a8+vfpv3_musl_eabi/u-boot-A10-OLinuXino-Lime/u-boot-2016.03' HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o This is not so much better. This code was introduced in this commit: https://git.lede-project.org/68139cc0e819b5f654c4f78468049eef035d28f7 Felix do you know what is wrong here? Like Yousong pointed out HOSTCPPFLAGS is not used in LEDE, but HOST_CPPFLAGS is. Hauke
diff --git a/include/u-boot.mk b/include/u-boot.mk index 4b3ff69d6b..5fe3b42ba9 100644 --- a/include/u-boot.mk +++ b/include/u-boot.mk @@ -42,7 +42,7 @@ TARGET_DEP = TARGET_$(BUILD_TARGET)$(if $(BUILD_SUBTARGET),_$(BUILD_SUBTARGET)) UBOOT_MAKE_FLAGS = \ HOSTCC="$(HOSTCC)" \ - HOSTCFLAGS='$(HOST_CFLAGS) $$$$(HOSTCPPFLAGS)' \ + HOSTCFLAGS='$(HOST_CFLAGS) $$$(HOSTCPPFLAGS)' \ HOSTLDFLAGS="" define Build/U-Boot/Target
U-Boot 2017.07 complains if HOSTCPPFLAGS is referenced once too often. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- include/u-boot.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)