diff mbox

[LEDE-DEV] brcm2708: bcm2710: do not activate neon-vfpv4 manually

Message ID 20170717220158.5024-1-hauke@hauke-m.de
State Accepted
Delegated to: Hauke Mehrtens
Headers show

Commit Message

Hauke Mehrtens July 17, 2017, 10:01 p.m. UTC
Neon and vfpv4 support are activated by GCC on all ARMv8 CPUs because
this is not a mandatory part of the architecture. There is not need to
activate is manually.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 target/linux/brcm2708/bcm2710/target.mk | 1 -
 1 file changed, 1 deletion(-)

Comments

Florian Fainelli July 17, 2017, 10:03 p.m. UTC | #1
On 07/17/2017 03:01 PM, Hauke Mehrtens wrote:
> Neon and vfpv4 support are activated by GCC on all ARMv8 CPUs because
> this is not a mandatory part of the architecture. There is not need to
> activate is manually.

You mean this is "now a mandatory part of the architecture", right?

LGTM

> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>  target/linux/brcm2708/bcm2710/target.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/linux/brcm2708/bcm2710/target.mk b/target/linux/brcm2708/bcm2710/target.mk
> index 2b155ad277..72b34306ca 100644
> --- a/target/linux/brcm2708/bcm2710/target.mk
> +++ b/target/linux/brcm2708/bcm2710/target.mk
> @@ -7,7 +7,6 @@ ARCH:=aarch64
>  SUBTARGET:=bcm2710
>  BOARDNAME:=BCM2710 64 bit based boards
>  CPU_TYPE:=cortex-a53
> -CPU_SUBTYPE:=neon-vfpv4
>  
>  define Target/Description
>  	Build firmware image for Broadcom BCM2710 64 bit SoC devices.
>
Hauke Mehrtens July 17, 2017, 10:11 p.m. UTC | #2
On 07/18/2017 12:03 AM, Florian Fainelli wrote:
> On 07/17/2017 03:01 PM, Hauke Mehrtens wrote:
>> Neon and vfpv4 support are activated by GCC on all ARMv8 CPUs because
>> this is not a mandatory part of the architecture. There is not need to
>> activate is manually.
> 
> You mean this is "now a mandatory part of the architecture", right?

Yes, sorry will fix the text.


> LGTM
> 
>>
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>> ---
>>  target/linux/brcm2708/bcm2710/target.mk | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/target/linux/brcm2708/bcm2710/target.mk b/target/linux/brcm2708/bcm2710/target.mk
>> index 2b155ad277..72b34306ca 100644
>> --- a/target/linux/brcm2708/bcm2710/target.mk
>> +++ b/target/linux/brcm2708/bcm2710/target.mk
>> @@ -7,7 +7,6 @@ ARCH:=aarch64
>>  SUBTARGET:=bcm2710
>>  BOARDNAME:=BCM2710 64 bit based boards
>>  CPU_TYPE:=cortex-a53
>> -CPU_SUBTYPE:=neon-vfpv4
>>  
>>  define Target/Description
>>  	Build firmware image for Broadcom BCM2710 64 bit SoC devices.
>>
> 
>
diff mbox

Patch

diff --git a/target/linux/brcm2708/bcm2710/target.mk b/target/linux/brcm2708/bcm2710/target.mk
index 2b155ad277..72b34306ca 100644
--- a/target/linux/brcm2708/bcm2710/target.mk
+++ b/target/linux/brcm2708/bcm2710/target.mk
@@ -7,7 +7,6 @@  ARCH:=aarch64
 SUBTARGET:=bcm2710
 BOARDNAME:=BCM2710 64 bit based boards
 CPU_TYPE:=cortex-a53
-CPU_SUBTYPE:=neon-vfpv4
 
 define Target/Description
 	Build firmware image for Broadcom BCM2710 64 bit SoC devices.