diff mbox

[LEDE-DEV,mdns] Add simple "Fall through" comment to the announce_timer function switch

Message ID 20170208142042.7989-1-zajec5@gmail.com
State Accepted
Headers show

Commit Message

Rafał Miłecki Feb. 8, 2017, 2:20 p.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

It's a common practice to add such comments to make it clear break
instruction was skipped on purpose.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 announce.c | 1 +
 1 file changed, 1 insertion(+)

Comments

John Crispin Feb. 8, 2017, 3:22 p.m. UTC | #1 
On 08/02/2017 15:20, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> It's a common practice to add such comments to make it clear break
> instruction was skipped on purpose.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: John Crispin <john@phrozen.org>

feel free to push the changes to the repo

> ---
>  announce.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/announce.c b/announce.c
> index d1aca5b..03c7b8f 100644
> --- a/announce.c
> +++ b/announce.c
> @@ -62,6 +62,7 @@ announce_timer(struct uloop_timeout *timeout)
>  				return;
>  			}
>  			iface->announce_state++;
> +			/* Fall through */
>  
>  		case STATE_ANNOUNCE:
>  			service_announce(iface, announce_ttl);
>
diff mbox

Patch

diff --git a/announce.c b/announce.c
index d1aca5b..03c7b8f 100644
--- a/announce.c
+++ b/announce.c
@@ -62,6 +62,7 @@  announce_timer(struct uloop_timeout *timeout)
 				return;
 			}
 			iface->announce_state++;
+			/* Fall through */
 
 		case STATE_ANNOUNCE:
 			service_announce(iface, announce_ttl);