diff mbox

[LEDE-DEV] kernel: add TI tmp102 and tmp103 temperature sensors

Message ID 20161207214508.27536-1-hauke@hauke-m.de
State Accepted
Delegated to: Hauke Mehrtens
Headers show

Commit Message

Hauke Mehrtens Dec. 7, 2016, 9:45 p.m. UTC
This just adds the kmods for these kernel modules.
This is found on some Lantiq / Intel reference boards.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 package/kernel/linux/modules/hwmon.mk | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

Comments

Rafał Miłecki Dec. 7, 2016, 9:59 p.m. UTC | #1
On 7 December 2016 at 22:45, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> This just adds the kmods for these kernel modules.
> This is found on some Lantiq / Intel reference boards.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>  package/kernel/linux/modules/hwmon.mk | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/package/kernel/linux/modules/hwmon.mk b/package/kernel/linux/modules/hwmon.mk
> index 56cd0ec..f7f1101 100644
> --- a/package/kernel/linux/modules/hwmon.mk
> +++ b/package/kernel/linux/modules/hwmon.mk
> @@ -328,6 +328,36 @@ endef
>  $(eval $(call KernelPackage,hwmon-gsc))
>
>
> +define KernelPackage/hwmon-tmp102
> +  TITLE:=Texas Instruments TMP102 monitoring support
> +  KCONFIG:=CONFIG_SENSORS_TMP102
> +  FILES:=$(LINUX_DIR)/drivers/hwmon/tmp102.ko
> +  AUTOLOAD:=$(call AutoLoad,60,tmp102)
> +  $(call AddDepends/hwmon,+kmod-i2c-core)
> +endef

Do we have any policy on AutoLoad vs. AutoProbe? I guess AutoLoad is
still used in many places, just wondering if new code should be using
AutoProbe maybe?
John Crispin Dec. 8, 2016, 1 p.m. UTC | #2
On 07/12/2016 22:45, Hauke Mehrtens wrote:
> This just adds the kmods for these kernel modules.
> This is found on some Lantiq / Intel reference boards.
> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>  package/kernel/linux/modules/hwmon.mk | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/package/kernel/linux/modules/hwmon.mk b/package/kernel/linux/modules/hwmon.mk
> index 56cd0ec..f7f1101 100644
> --- a/package/kernel/linux/modules/hwmon.mk
> +++ b/package/kernel/linux/modules/hwmon.mk
> @@ -328,6 +328,36 @@ endef
>  $(eval $(call KernelPackage,hwmon-gsc))
>  
>  
> +define KernelPackage/hwmon-tmp102
> +  TITLE:=Texas Instruments TMP102 monitoring support
> +  KCONFIG:=CONFIG_SENSORS_TMP102
> +  FILES:=$(LINUX_DIR)/drivers/hwmon/tmp102.ko
> +  AUTOLOAD:=$(call AutoLoad,60,tmp102)

is there a reason why you are not using AutoProbe here ?

	John

> +  $(call AddDepends/hwmon,+kmod-i2c-core)
> +endef
> +
> +define KernelPackage/hwmon-tmp102/description
> + Kernel module for Texas Instruments TMP102 temperature sensors chip
> +endef
> +
> +$(eval $(call KernelPackage,hwmon-tmp102))
> +
> +
> +define KernelPackage/hwmon-tmp103
> +  TITLE:=Texas Instruments TMP103 monitoring support
> +  KCONFIG:=CONFIG_SENSORS_TMP103
> +  FILES:=$(LINUX_DIR)/drivers/hwmon/tmp103.ko
> +  AUTOLOAD:=$(call AutoLoad,60,tmp103)
> +  $(call AddDepends/hwmon,+kmod-i2c-core +kmod-regmap)
> +endef
> +
> +define KernelPackage/hwmon-tmp103/description
> + Kernel module for Texas Instruments TMP103 temperature sensors chip
> +endef
> +
> +$(eval $(call KernelPackage,hwmon-tmp103))
> +
> +
>  define KernelPackage/hwmon-tmp421
>    TITLE:=TI TMP421 and compatible monitoring support
>    KCONFIG:=CONFIG_SENSORS_TMP421
>
Hauke Mehrtens Dec. 8, 2016, 11:18 p.m. UTC | #3
On 12/08/2016 02:00 PM, John Crispin wrote:
> 
> 
> On 07/12/2016 22:45, Hauke Mehrtens wrote:
>> This just adds the kmods for these kernel modules.
>> This is found on some Lantiq / Intel reference boards.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>> ---
>>  package/kernel/linux/modules/hwmon.mk | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>
>> diff --git a/package/kernel/linux/modules/hwmon.mk b/package/kernel/linux/modules/hwmon.mk
>> index 56cd0ec..f7f1101 100644
>> --- a/package/kernel/linux/modules/hwmon.mk
>> +++ b/package/kernel/linux/modules/hwmon.mk
>> @@ -328,6 +328,36 @@ endef
>>  $(eval $(call KernelPackage,hwmon-gsc))
>>  
>>  
>> +define KernelPackage/hwmon-tmp102
>> +  TITLE:=Texas Instruments TMP102 monitoring support
>> +  KCONFIG:=CONFIG_SENSORS_TMP102
>> +  FILES:=$(LINUX_DIR)/drivers/hwmon/tmp102.ko
>> +  AUTOLOAD:=$(call AutoLoad,60,tmp102)
> 
> is there a reason why you are not using AutoProbe here ?

The only reason is that this is an older patch from one Lantiq SDK and
it was done a long time ago. I will use AutoProbe here.

Hauke
diff mbox

Patch

diff --git a/package/kernel/linux/modules/hwmon.mk b/package/kernel/linux/modules/hwmon.mk
index 56cd0ec..f7f1101 100644
--- a/package/kernel/linux/modules/hwmon.mk
+++ b/package/kernel/linux/modules/hwmon.mk
@@ -328,6 +328,36 @@  endef
 $(eval $(call KernelPackage,hwmon-gsc))
 
 
+define KernelPackage/hwmon-tmp102
+  TITLE:=Texas Instruments TMP102 monitoring support
+  KCONFIG:=CONFIG_SENSORS_TMP102
+  FILES:=$(LINUX_DIR)/drivers/hwmon/tmp102.ko
+  AUTOLOAD:=$(call AutoLoad,60,tmp102)
+  $(call AddDepends/hwmon,+kmod-i2c-core)
+endef
+
+define KernelPackage/hwmon-tmp102/description
+ Kernel module for Texas Instruments TMP102 temperature sensors chip
+endef
+
+$(eval $(call KernelPackage,hwmon-tmp102))
+
+
+define KernelPackage/hwmon-tmp103
+  TITLE:=Texas Instruments TMP103 monitoring support
+  KCONFIG:=CONFIG_SENSORS_TMP103
+  FILES:=$(LINUX_DIR)/drivers/hwmon/tmp103.ko
+  AUTOLOAD:=$(call AutoLoad,60,tmp103)
+  $(call AddDepends/hwmon,+kmod-i2c-core +kmod-regmap)
+endef
+
+define KernelPackage/hwmon-tmp103/description
+ Kernel module for Texas Instruments TMP103 temperature sensors chip
+endef
+
+$(eval $(call KernelPackage,hwmon-tmp103))
+
+
 define KernelPackage/hwmon-tmp421
   TITLE:=TI TMP421 and compatible monitoring support
   KCONFIG:=CONFIG_SENSORS_TMP421