From patchwork Mon May 14 18:14:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 913175 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ceteIjDV"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KzMGpkS3"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40l8471Nwwz9s1R for ; Tue, 15 May 2018 04:14:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=+uKyINmhnUQpOqvBWZX739ZcaXDQmmqxxx5Y1gDYTXA=; b=ceteIjDVvQXTtvToskj/KXj7ZL 00Pgnxx22OzVrTtcWWwwOYSe6dr4vm9ulZbd+JeW+/Jxhu1O7/EM4fUDD/d9Xcwgq99rG95DNeiWL 64rguILfX3G0noB3V5Sdb3yS6rK89rZOGMYjv+TbSnzUC5djZ5qM2F+H5yZ69Zom6XMSIZizQNk/y aj3Y6drAXy4qpbvYRp3kB6gRI7W9MaK3ADzN5oou+sKbpq9wHEd1NoCidF3DXiHqZxL0OPz47TfLj uT3M4y4vIwe4yJ/XbAbEsl5c3fY7h142FQG/8gfswcGoknYRYefdQ3RmkWszVtJ32XIjrON8Xmjtg dHNGpVKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIHze-0004he-Kl; Mon, 14 May 2018 18:14:42 +0000 Received: from mail-pl0-x241.google.com ([2607:f8b0:400e:c01::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fIHza-0004g5-Uq for lede-dev@lists.infradead.org; Mon, 14 May 2018 18:14:40 +0000 Received: by mail-pl0-x241.google.com with SMTP id ay10-v6so7831562plb.1 for ; Mon, 14 May 2018 11:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=rGpVIQ7ew5TiVJdS8rYMUnkBptIyECfHbJFBLYgShAI=; b=KzMGpkS3KkP7vtte0cX8oXgiZLQT8AFeAGIKMJWzUEyZa2jROdz4aL83YrokFMxcVG icQjq4IhUbF7IpfQMNSbE+6Gu5G5LqBvAZSQrf3DTjePlREYvi3RqWtFn2S90D60toY8 kDhUmz5QstUy4/3eiZG4uRP73ww/UBFHpAimJ0oBuVxEOETfouLIiD5I/ejYcvP8HixG GXQuppDnFlacG2dCzMYlL1EMjWXhis3VGfIdUkdlInoo82TuM6MQ/qkc5xVn92qnxYdb IkO8DOOX+f3+Th/sxmzIpclkrduW2l5/UlVCWHMnhc+gjq81IijFZOjMUZZBh39u0nzs +bxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=rGpVIQ7ew5TiVJdS8rYMUnkBptIyECfHbJFBLYgShAI=; b=tb0J9BNXqnGX2IuSOq5eEX2LAIPDVulZ/T0U/zlPz7QkJ2HVtucVqbntFvMvqnspDD 8prunT3LHTiih2K8XFmbTdKSzoF4cr92G/9PVsYV87z7t0Je3Ib9ZE4SnKJH7wNuEjGi k9+N7LNtzyakj38aQq9kCW4lCCRnrlR4Lnh4SfoQI/rpDh6bQua/bKxdSEC7zJnseCHx 3AfaPs1vxAuEL6ubaazAzj98LMDwZxa4VbLEUe0HTyB8Rln83SbPpeUhfmhFCJG8L+uW LsuORzeDGnTxWmD8Tsd8g9TKWMeFAWsLc2RyF8h3okHxvbTUE/OsUMnclDDlH+CpSovy HFjQ== X-Gm-Message-State: ALKqPwdgXcCptL/eXPqcVHhK2xrOaudvqY4xmSwqbFyVdwUzWeiLVEBU DU4fLGfBeo+9HxsBJNwjiuIfIz8e X-Google-Smtp-Source: AB8JxZrMUDEO+jPZGt0PCV5jEfzCMzao04i9Bv8XSFD67k2C33cZ64eWYy8XPQ2pibknkX942es2Og== X-Received: by 2002:a17:902:2a43:: with SMTP id i61-v6mr11202843plb.54.1526321668358; Mon, 14 May 2018 11:14:28 -0700 (PDT) Received: from DESKTOP-CEH0M93.lan (astound-69-42-5-101.ca.astound.net. [69.42.5.101]) by smtp.gmail.com with ESMTPSA id h23-v6sm16558468pfi.175.2018.05.14.11.14.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 May 2018 11:14:27 -0700 (PDT) From: Rosen Penev To: lede-dev@lists.infradead.org Date: Mon, 14 May 2018 11:14:23 -0700 Message-Id: <1526321665-1506-3-git-send-email-rosenp@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1526321665-1506-1-git-send-email-rosenp@gmail.com> References: <1526321665-1506-1-git-send-email-rosenp@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180514_111439_012648_D0C97117 X-CRM114-Status: GOOD ( 14.17 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c01:0:0:0:241 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Subject: [LEDE-DEV] [PATCH 3/5] staging: mt7621-eth: fix return value check in mtk_probe() X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Wei Yongjun In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: e3cbf478f846 ("staging: mt7621-eth: add the drivers core files") Signed-off-by: Wei Yongjun Signed-off-by: Greg Kroah-Hartman --- .../linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c index d0d88b9..c806e28 100644 --- a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -1513,7 +1513,7 @@ static int fe_probe(struct platform_device *pdev) soc->reg_table = fe_reg_table; fe_base = devm_ioremap_resource(&pdev->dev, res); - if (!fe_base) { + if (IS_ERR(fe_base)) { err = -EADDRNOTAVAIL; goto err_out; }