From patchwork Wed Dec 27 11:00:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathias Kresin X-Patchwork-Id: 853126 X-Patchwork-Delegate: openwrt@kresin.me Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H/C4lJzs"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kresin-me.20150623.gappssmtp.com header.i=@kresin-me.20150623.gappssmtp.com header.b="FcNmPaGs"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z691H6X2Vz9rxm for ; Wed, 27 Dec 2017 22:02:43 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qV8KPBdrG0oTarK+1nfeEvUtY5ZxmKqI6XdcT9tGvq8=; b=H/C4lJzspLyUBs Qx+8PDWLHNAuUv14HZ9WkdQkQ52r6JWRipyh1NMmwUVBUItEddbkNapwjQ3fA/hZvpTaXTumsESUb EmYh4U4bC41Xl7uSr2ZWja95PuZgKrfpCPaCXmQXsyUn78twwoizR/YNGrX95QaI4uz90T/QfNvMi mCnZCTq9aLrEZXjr6b8zMnWCKPaS/MSvJbzBWS6Lztuddgw41uDr92CfIVvQriAMX0+IFYZmG3rtO 4ZzYO7bBN07JEHxT8GfvOogD2DF+v2DHw5RY3JgQkGu/qa/tAoeT38p8DtV7C2DgesIqs3wRbFg3g lFE07onJN3I4KbQZcN1g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eU9Tj-0003FH-Qv; Wed, 27 Dec 2017 11:02:31 +0000 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eU9Sm-00033n-G2 for lede-dev@lists.infradead.org; Wed, 27 Dec 2017 11:01:34 +0000 Received: by mail-wr0-x242.google.com with SMTP id g17so27231810wrd.13 for ; Wed, 27 Dec 2017 03:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kresin-me.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NZyHhhuT8Y6NEM0qHTZVNaNubLHVwOUg81J7XcGD0YM=; b=FcNmPaGs6HhEojwlt+T2WQknA9zxJf0/+ed3vxoBRBCTxjqT73jB4pUJG5+6j7+Lm7 ODQpcbT1aTl+JsG97BIh665CDbu27s0rNEy7WRoLWDFSQZexi+eF8WzJymW8mH/LjMOX D8rjfP0UDtl5y/uixo8sv9eqNhEeV9NmlhqP+r+CTyd+c+DJ6SVtlB5x5KF5ekWLpWdI n+3dwPCsDvkTHCpnvQIayUngRxUHXI9wIHrCGOGdaS4UNjcMOZjPmIOsEDnyPr3gXZMg DAxyE66CUiKmBpavc1aQKNDsDyu2eKNd0zeUfvYbDarwB2Uvcn3yRsZu7xhwiV3NGfGM SjjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NZyHhhuT8Y6NEM0qHTZVNaNubLHVwOUg81J7XcGD0YM=; b=e+XsFw3PW8v4xurMhvf/nn+xAuTk2IEwbP9+f4BXvxupLeggpQkcdyTv2Mzs0O9p+T 5V4GEHr97b9j1GUOCJ6jCXr5yUBXAJ7GAK/M15rVmm6PTrHHZbmLXiLUmspkl/UdKZM2 8LgUAlsLl0yibM75t7RYsY4EgzrToD+hXoxMp0cxRG0QlZIjwb8hyBwHrLpeg6SeRbPt yzgT003fSJpNqev9kjwWMRIZ2/pxMiXaxXoTdnxmaPp4J6HB9yFQmfw5X3Wi/5W9mgfo S3KhfsvkIxdjzgR5nRIC7GOW9Ighec7Z9FhaUcLLXaPVIpLQaEgBC0jXLC81cu1fxXIC iumg== X-Gm-Message-State: AKGB3mJ3JGBj3jWGVTenLIG0N5bYLcMcsNxRnv9lKrS9hlmeAJmNphkx X495WyNL63Dav3iN5KlaXdW8sO6s X-Google-Smtp-Source: ACJfBost22uktLhgjwWEvTqJsvTX73epmk77d1dw8SsNXW96qKBcKkBlV/Tft5ZDnyyBtUNe+TH2bg== X-Received: by 10.223.183.33 with SMTP id l33mr27427579wre.175.1514372480327; Wed, 27 Dec 2017 03:01:20 -0800 (PST) Received: from desktop.wvd.kresin.me (p2003008C2F241F10F1354A3912861EA1.dip0.t-ipconnect.de. [2003:8c:2f24:1f10:f135:4a39:1286:1ea1]) by smtp.gmail.com with ESMTPSA id e20sm29723661wre.6.2017.12.27.03.01.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 27 Dec 2017 03:01:19 -0800 (PST) From: Mathias Kresin To: lede-dev@lists.infradead.org Date: Wed, 27 Dec 2017 12:00:21 +0100 Message-Id: <1514372421-12338-2-git-send-email-dev@kresin.me> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514372421-12338-1-git-send-email-dev@kresin.me> References: <1514372421-12338-1-git-send-email-dev@kresin.me> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171227_030132_557270_288983F8 X-CRM114-Status: UNSURE ( 8.51 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:400c:c0c:0:0:0:242 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid Subject: [LEDE-DEV] [PATCH 2/2] base-files: gpio switch: set output value with direction X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lars Kruse MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Use the "low" and "high" values to configure the GPIO as an output with that initial value. It ensures that the gpio doesn't have a unwanted value during the time the direction is set to ouput and the actual value is applied. We don't need to take care of the GPIO polarity for now, since our exported GPIOs are always active low. Cc: Lars Kruse Signed-off-by: Mathias Kresin --- package/base-files/Makefile | 2 +- package/base-files/files/etc/init.d/gpio_switch | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/package/base-files/Makefile b/package/base-files/Makefile index 728d787..d0c9d6b 100644 --- a/package/base-files/Makefile +++ b/package/base-files/Makefile @@ -12,7 +12,7 @@ include $(INCLUDE_DIR)/version.mk include $(INCLUDE_DIR)/feeds.mk PKG_NAME:=base-files -PKG_RELEASE:=179 +PKG_RELEASE:=180 PKG_FLAGS:=nonshared PKG_FILE_DEPENDS:=$(PLATFORM_DIR)/ $(GENERIC_PLATFORM_DIR)/base-files/ diff --git a/package/base-files/files/etc/init.d/gpio_switch b/package/base-files/files/etc/init.d/gpio_switch index 5a62be9..b67950a 100755 --- a/package/base-files/files/etc/init.d/gpio_switch +++ b/package/base-files/files/etc/init.d/gpio_switch @@ -22,10 +22,9 @@ load_gpio_switch() echo "$gpio_pin" >/sys/class/gpio/export # we need to wait a bit until the GPIO appears [ -d "$gpio_path" ] || sleep 1 - echo out >"$gpio_path/direction" } - # write 0 or 1 to the "value" field - { [ "$value" = "0" ] && echo "0" || echo "1"; } >"$gpio_path/value" + # set the pin to output with high or low pin value + { [ "$value" = "0" ] && echo "high" || echo "low"; } >"$gpio_path/direction" } service_triggers()