From patchwork Mon May 29 09:58:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Koen Vandeputte X-Patchwork-Id: 768117 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wbsgb2S5kz9s2P for ; Mon, 29 May 2017 20:00:43 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fGnEqcSu"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ncentric.com header.i=@ncentric.com header.b="FGhwIp1f"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=FcxYG/Xu7bPyc0zLKb2trxO0hcOqodvb2wodHz1ARMs=; b=fGnEqcSuY+diJY Vv+pybhVEzDuQn6islsnnYyMDLcgtH9qwOTFKT22gGg3o4VtZdr6dm+jdUozr3s1EObwtjy4y8vj0 Uv9Au6MflNgtpbc7675B5clQtLa5rFJ6ade6BgIuXfTV65LejgrbGN0I+mOATy+UDnaKcnzju2hwC QlJoCvw08L8/kqAimHzL4xoDxkF2rbb7/Beoh1yCMqcr9Lbw877OJPT0s9NqazRtde+gl0cqGLrGe rkrpNhUjsKsMSkPRSZKFscAAL1KUrxhn7XdQBV8TvLEsCRFz6NjktsrBHHE2Lln49U/G5abgI/mOj tH46x6/R1YW2/8un2Evw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dFHTY-0006zZ-A4; Mon, 29 May 2017 10:00:36 +0000 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dFHTT-0006xA-Mo for lede-dev@lists.infradead.org; Mon, 29 May 2017 10:00:34 +0000 Received: by mail-wm0-x22b.google.com with SMTP id 7so49252290wmo.1 for ; Mon, 29 May 2017 03:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ncentric.com; s=google; h=from:to:cc:subject:date:message-id; bh=BgarJdEiPWaCZDl2WPHrva93lAQ6Xq+3pBLUH6IB3Zc=; b=FGhwIp1ff/2wFt+5nC9uO17xxXuHWNhPxX+mpDrXbGyRuLfqcJeH3RBNZpE1Vh6Nh8 rJMD3cgGffZxvQldRAPXS8pBEg+IulTvjyeG8cNfvj0wQbk8KDNNnxuHBRJOTSMJiqdb T7ct6RKtABYahf42WNL3Q4uTteYK9DxcpVruA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=BgarJdEiPWaCZDl2WPHrva93lAQ6Xq+3pBLUH6IB3Zc=; b=dplJ3swSQNSSQd7jv/9+CWVhqEzhha2wnGjDgRs5oQdwmh6CiECUYCTg0/lHCsRvFV TPiiagkFbQAq9ED/r75MX0QdayOZLZbudJRMl92G/z1Ss9jIlHFsf7w9/Dpng4LncmED pRjN4QQgFSo1RV78LHoXBsOEJDEOj+s0hmTOhweLIVeuoeNZxkCoD7rn6ngHGVo+hMnF hpkZt4JvFqo356AQSUj0QTEQ1B3v18Iv34EjsidsTA+2SDuOLwwLM+4XNP/sbHxjOUQs PwMp265xw3tCjbAxVuJOKh7naeJvm6sdbREUzlClJWg6O4a7PlSDhiumkdNQQV+9b3Da gZxg== X-Gm-Message-State: AODbwcAjUVt57Ec6fDfqUuoh+fk85hZvKkFAiYbsbcFuv/Bx9gEEMVJt oW8yGdP2Q+T1WsGZ+88= X-Received: by 10.80.130.36 with SMTP id 33mr12102970edf.154.1496052008546; Mon, 29 May 2017 03:00:08 -0700 (PDT) Received: from localhost.localdomain (d515300d8.static.telenet.be. [81.83.0.216]) by smtp.googlemail.com with ESMTPSA id g24sm3787197edh.20.2017.05.29.03.00.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 29 May 2017 03:00:08 -0700 (PDT) From: Koen Vandeputte To: lede-dev@lists.infradead.org Date: Mon, 29 May 2017 11:58:01 +0200 Message-Id: <1496051881-8662-1-git-send-email-koen.vandeputte@ncentric.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170529_030032_095204_C9532D11 X-CRM114-Status: GOOD ( 11.14 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:22b listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Subject: [LEDE-DEV] [PATCH v2] imx6: disable UART dma X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tharvey@gateworks.com, john@phrozen.org, Koen Vandeputte , nbd@nbd.name MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Fixes these prints on boot: [ 13.785600] imx-uart 2020000.serial: DMA transaction error. [ 13.793134] imx-uart 2020000.serial: DMA transaction error. [ 13.798721] imx-uart 2020000.serial: DMA transaction error. Based on following upstream patch by Tim Harvey (Gateworks): https://github.com/Gateworks/openwrt/commit/80a01b6582f94c4547f39d3a25e0a1e9b6eb9877 TX complete DMA messages are getting missed. This is also currently an issue in mainline. For now we will disable DMA in serial/imx.c. This resolves an issue encountered with RS485 transmit. Signed-off-by: Koen Vandeputte --- .../imx6/patches-4.9/210-disable-uart-dma.patch | 23 ++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 target/linux/imx6/patches-4.9/210-disable-uart-dma.patch diff --git a/target/linux/imx6/patches-4.9/210-disable-uart-dma.patch b/target/linux/imx6/patches-4.9/210-disable-uart-dma.patch new file mode 100644 index 0000000..6abbb93 --- /dev/null +++ b/target/linux/imx6/patches-4.9/210-disable-uart-dma.patch @@ -0,0 +1,23 @@ +Based on following upstream patch by Tim Harvey (Gateworks): + +https://github.com/Gateworks/openwrt/commit/80a01b6582f94c4547f39d3a25e0a1e9b6eb9877 + +TX complete DMA messages are getting missed. +This is also currently an issue in mainline. +For now we will disable DMA in serial/imx.c. + +This resolves an issue encountered with RS485 transmit. + +--- a/drivers/tty/serial/imx.c ++++ b/drivers/tty/serial/imx.c +@@ -1268,10 +1268,6 @@ static int imx_startup(struct uart_port + + writel(temp & ~UCR4_DREN, sport->port.membase + UCR4); + +- /* Can we enable the DMA support? */ +- if (!uart_console(port) && !sport->dma_is_inited) +- imx_uart_dma_init(sport); +- + spin_lock_irqsave(&sport->port.lock, flags); + /* Reset fifo's and state machines */ + i = 100;