| Message ID | 1487609330-112559-1-git-send-email-thomas@reifferscheid.org |
|---|---|
| State | Accepted |
| Headers | show |
On 20 February 2017 at 17:48, Thomas Reifferscheid <thomas@reifferscheid.org> wrote: > The @ sign in front of the "mv" command was significantly suppressing > output to stdout. When reviewing the make/build logs it was tricking > me a whole lot and it mad me lose time. Removing the @ sign will get > stdout and logs right about what happened when. > > Signed-off-by: Thomas Reifferscheid <thomas@reifferscheid.org> Looks good to me.
diff --git a/include/image-commands.mk b/include/image-commands.mk index 49e4389..c513f19 100644 --- a/include/image-commands.mk +++ b/include/image-commands.mk @@ -8,7 +8,7 @@ define Build/uImage -O linux -T kernel \ -C $(1) -a $(KERNEL_LOADADDR) -e $(if $(KERNEL_ENTRY),$(KERNEL_ENTRY),$(KERNEL_LOADADDR)) \ -n '$(if $(UIMAGE_NAME),$(UIMAGE_NAME),$(call toupper,$(LINUX_KARCH)) LEDE Linux-$(LINUX_VERSION))' -d $@ $@.new - @mv $@.new $@ + mv $@.new $@ endef define Build/buffalo-enc
The @ sign in front of the "mv" command was significantly suppressing output to stdout. When reviewing the make/build logs it was tricking me a whole lot and it mad me lose time. Removing the @ sign will get stdout and logs right about what happened when. Signed-off-by: Thomas Reifferscheid <thomas@reifferscheid.org> --- include/image-commands.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)