From patchwork Fri Mar 13 05:08:31 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 2210332 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=jsPjp26y; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=RMCXqo8V; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4fXCFc6bp6z1yKc for ; Fri, 13 Mar 2026 16:09:03 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SrsZ9ZzY6ojhR4yhi+OHDxp+kA7xjySrs5uW2SHveq4=; b=jsPjp26yx2ZaYS 2DqVAfYS0lhcLe4dNoxgZavwf/Bd0jaLQOCdJ6LLiwJNDus0WacxlqsXGe4mQRTre5czihz2osw+1 374vk/YgUL3m1Nnam9wYET/zq0X0ygly2rPRU3iyWKQxJn0Z1kU3cn1gtbOBI6OfS5XlJ22jXDAzG cjn/xaHpDPvcs2D8q4J2eYRoOsMA4DpjrfwXgvm4+O4FLG+IB4BGfpPdhXSguGPG5+VjCctDBX/+s F/GIabZ7lMd0GAcaAjNMNHu+OpNByl9kxt32fsjVKptvh+XotCTyrxwdoGnpcK44iyhZYvaUIlF+d Hoz+gF8B5VLj965nO+7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0uli-0000000GZdo-1B6Z; Fri, 13 Mar 2026 05:09:02 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0ulb-0000000GZa8-1gm7 for kvm-riscv@lists.infradead.org; Fri, 13 Mar 2026 05:09:01 +0000 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-c739d32b72cso1142503a12.2 for ; Thu, 12 Mar 2026 22:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773378534; x=1773983334; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xafO+FHn/tcABOfSsYiI8MAh86pKbUb1BqbY4MczeRI=; b=RMCXqo8VrWD7mbb9DHE8bFOY+SkFSuwfrlRm7peS5U3CHDJWiQH06my/JKFxsADEYh 2sYoEMpluSy0RNbY9tE3E7MYa6fLW5BdmYnHEhsfmGQq+r/VQjU+NhVEzyX7O3dFdqI5 7WiA7MZSqTE3rvKBJuNmkKZcfwtKcAXoplHfeRMD9xm72lJjxhM8CBq5NDLR1fa4SEBg DxJdruKAnqDluWPx7OrwSL62ECecZLYhiwO75G7z5i7Tr4v0HI3dexyzVKpigCpHxV8y PXVAXn22HOcrEs7tZFXfNGx1IpYPZdjgfeR/ns17DOVJv4vS2IcLRpIqnTjL/sRtzKUN Drjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773378534; x=1773983334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xafO+FHn/tcABOfSsYiI8MAh86pKbUb1BqbY4MczeRI=; b=e18Gtxntd9i6FObDubdutQMEpUqQvbpKcHT/k7rF6MQC2ehtenPnBuo/MH7yn64UTy WF1fDOdCBxGRxkpVldj00E6XfNzo35/pG7w33AjGqpQlx6PjZ5qI8Ccwg9nAQBQ2V5Q4 eQYnNoY4xPSGgwVzpwdXDcVf3S2ujx7lV+wXF3S/Fp/Ro5Tz4yFAUNfw8Nam+VTcP1bY 6mnMrU0cCErjaVVtxbipI1cnrzaaw584dy34HlN7CA+4JSXvtM6Pz4EIVxRM+m5+GGe7 bC8eqy8qPCdMWBaX9J8jpwbsheSc/ETmoaFiOgbtCRC8skKBnTiC4wibDFPsnYlzTRgv Sddw== X-Forwarded-Encrypted: i=1; AJvYcCW4YoBR/NKqIDOCi2IsKoCDxlnxMhF9gB6A3SkipATaYTOehd2jIA8AV+kx3OUFbsknE9QYpvfKSck=@lists.infradead.org X-Gm-Message-State: AOJu0Yztp77SOtYxcNOKXn9YrojstzVf5zu++olQ22EKrqcKjeVmGUXB Wx7bCdpAyfJUh6HIWtjEcrRH9RhnwifnuDzTNl1/BDIxuBy6+2wnF4NX X-Gm-Gg: ATEYQzzJw5LzLSuoJZAOVN8Fv8O7BJkalBhp/SWA8M8FJZS8Il5yPuggYExa92RJ2fT eyhzeSju6orTP7M2z7wc4NG7yZ88VvH6GzvFxjXlx3oB/i7HPHKM++NJlTIWdnQAPGWHcqyKcVf lw/W4TejNMpSviIQuhpwOPD1aX49TPtYLPDSI0nBENb1WgMAK7CdUivD9Te3nC+/3qXzlqsUhfN lpzxvkniLFAvcTsM7behI86eXht2s1f3N36WQ0GrBUgnPUzzAIBI2F0nD3YWzeqZWmPfiL9VEQ5 7G3xEYDR3OIrQEc2pDzsaglgYIwcWY7yS0Ttbz7qxdGhLcPajI/7HCuY/3TJdsMsKutmh1PUnOj q7L6Nn87qbtJ7cdL2hporms0EFpZuDyUCaESL0Xwl86/rZL95vXY9+1CiXTht82ayr5ya/FZ3V9 3o5ng5K/rRh8y4cb/rnciRIBgJAJ1+73OFVjI3EBaKRfqMVtnC4iq0rWhNZUoUSvsprCdd X-Received: by 2002:a05:6a21:6190:b0:398:8766:4d0a with SMTP id adf61e73a8af0-398eca9db12mr1654088637.19.1773378534287; Thu, 12 Mar 2026 22:08:54 -0700 (PDT) Received: from lima-default (103.95.112.190.qld.leaptel.network. [103.95.112.190]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73eb97a1d7sm676221a12.6.2026.03.12.22.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 22:08:53 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, opensbi@lists.infradead.org Subject: [kvm-unit-tests PATCH 2/2] riscv: dbtr: Add initial API corner case / error handling tests Date: Fri, 13 Mar 2026 15:08:31 +1000 Message-ID: <20260313050831.4016944-2-npiggin@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260313050831.4016944-1-npiggin@gmail.com> References: <20260313050831.4016944-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260312_220855_489519_54E0A9A0 X-CRM114-Status: GOOD ( 15.64 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The SBI DBTR specification has quite detailed API requirements that are easy to get wrong. This implements the beginning of testing some corner cases, not with trigger behaviour but with API behaviour [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:52f listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The SBI DBTR specification has quite detailed API requirements that are easy to get wrong. This implements the beginning of testing some corner cases, not with trigger behaviour but with API behaviour. Signed-off-by: Nicholas Piggin --- These tests expose a bunch of major and minor errors in OpenSBI handling, for which I will post patches to the opensbi list. As well as possibly a bug in the SBI spec, reported here. https://github.com/riscv-non-isa/riscv-sbi-doc/issues/257 Thanks, Nick --- --- riscv/sbi-dbtr.c | 314 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 314 insertions(+) diff --git a/riscv/sbi-dbtr.c b/riscv/sbi-dbtr.c index 489242b0..156b743b 100644 --- a/riscv/sbi-dbtr.c +++ b/riscv/sbi-dbtr.c @@ -423,6 +423,318 @@ static enum McontrolType dbtr_test_type(unsigned long *num_trig) return SBI_DBTR_TDATA1_TYPE_NONE; } +static struct sbiret dbtr_test_api(unsigned long trig_max) +{ + /* + 1 so overflow can be tested */ + static struct sbi_dbtr_shmem_entry shmem[RV_MAX_TRIGGERS + 1] = {}; + static unsigned long test[RV_MAX_TRIGGERS + 1]; + unsigned long tdata1; + unsigned long trig_type; + struct sbiret ret; + int i; + + /* + * This set of tests is to test API response, not hardware/trigger + * behaviour, which is left to later tests. + * + * Notably absent from these API tests at the moment are: + * - Enable/disable tests. + * - trig_state verification. + * - Testing more valid and invalid tdata1/2/3 values. + */ + + trig_type = dbtr_test_type(&trig_max); + tdata1 = gen_tdata1(trig_type, VALUE_LOAD | VALUE_STORE, MODE_S); + + /* + 1, so overflow can be tested */ + memset(shmem, 0, sizeof(shmem)); + for (i = 0; i < RV_MAX_TRIGGERS + 1; i++) { + shmem[i].data.tdata1 = tdata1; + shmem[i].data.tdata2 = (unsigned long)&test[i]; + } + + report_prefix_push("api"); + + report_prefix_push("no_shmem"); + ret = sbi_debug_read_triggers(0, 0); + sbiret_report_error(&ret, SBI_ERR_NO_SHMEM, "sbi_debug_read_triggers"); + report(ret.value == 0, "read return value"); + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_ERR_NO_SHMEM, "sbi_debug_install_triggers"); + report(ret.value == 0, "install return value"); + ret = sbi_debug_update_triggers(1); + sbiret_report_error(&ret, SBI_ERR_NO_SHMEM, "sbi_debug_update_triggers"); + report(ret.value == 0, "update return value"); + report_prefix_pop(); + + report_prefix_push("shmem"); + ret = sbi_debug_set_shmem_raw(1, 0, 0); + sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_set_shmem unaligned"); + ret = sbi_debug_set_shmem_raw(0, -1, 0); + sbiret_report_error(&ret, SBI_ERR_INVALID_ADDRESS, "sbi_debug_set_shmem bad address"); + ret = sbi_debug_set_shmem(shmem); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_set_shmem"); + ret = sbi_debug_read_triggers(0, 1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_read_triggers"); + ret = sbi_debug_set_shmem_raw(-1, -1, 0); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_set_shmem unset"); + ret = sbi_debug_read_triggers(0, 1); + sbiret_report_error(&ret, SBI_ERR_NO_SHMEM, "sbi_debug_read_triggers"); + report_prefix_pop(); + + ret = sbi_debug_set_shmem(shmem); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_set_shmem"); + + report_prefix_push("read triggers"); + ret = sbi_debug_read_triggers(0, 0); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_read_triggers 0, 0"); + ret = sbi_debug_read_triggers(0, 1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_read_triggers 0, 1"); + ret = sbi_debug_read_triggers(trig_max - 1, 0); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_read_triggers trig_max - 1, 0"); + ret = sbi_debug_read_triggers(trig_max - 1, 1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_read_triggers trig_max - 1, 1"); + ret = sbi_debug_read_triggers(trig_max, 0); + sbiret_report_error(&ret, SBI_ERR_BAD_RANGE, "sbi_debug_read_triggers trig_max, 0"); + ret = sbi_debug_read_triggers(trig_max, 1); + sbiret_report_error(&ret, SBI_ERR_BAD_RANGE, "sbi_debug_read_triggers trig_max, 1"); + ret = sbi_debug_read_triggers(0, trig_max); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_read_triggers 0, trig_max"); + ret = sbi_debug_read_triggers(1, trig_max); + sbiret_report_error(&ret, SBI_ERR_BAD_RANGE, "sbi_debug_read_triggers 1, trig_max"); + ret = sbi_debug_read_triggers(0, 1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_read_triggers 1"); + ret = sbi_debug_read_triggers(0, trig_max); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_read_triggers trig_max"); + report_prefix_pop(); + + report_prefix_push("install triggers"); + ret = sbi_debug_install_triggers(0); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 0"); + ret = sbi_debug_install_triggers(trig_max + 1); + sbiret_report_error(&ret, SBI_ERR_BAD_RANGE, "sbi_debug_install_triggers 0"); + + shmem[0].data.tdata1 = gen_tdata1(trig_type, VALUE_LOAD, MODE_M); + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_install_triggers 1 invalid"); + report(ret.value == 0, "error index 0"); + shmem[0].data.tdata1 = tdata1; + + if (trig_max > 1) { + shmem[1].data.tdata1 = gen_tdata1(trig_type, VALUE_LOAD, MODE_M); + ret = sbi_debug_install_triggers(2); + sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_install_triggers 2 invalid"); + report(ret.value == 1, "error index 1"); + shmem[1].data.tdata1 = tdata1; + } + + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 1"); + report(shmem[0].data.tstate == 0, "install index 0"); + ret = sbi_debug_install_triggers(trig_max); + sbiret_report_error(&ret, SBI_ERR_FAILURE, "sbi_debug_install_triggers trig_max"); + report(ret.value == trig_max - 1, "error index trig_max - 1"); + if (trig_max > 1) { + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 1"); + report(shmem[0].data.tstate == 1, "install index 1"); + + ret = sbi_debug_uninstall_triggers(0, 1); + if (!sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 0 1")) { + report_prefix_pop(); + goto out; + } + + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 1"); + report(shmem[0].data.tstate == 0, "install index 0"); + + ret = sbi_debug_uninstall_triggers(1, 1); + if (!sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 1 1")) { + report_prefix_pop(); + goto out; + } + } + ret = sbi_debug_uninstall_triggers(0, 1); + if (!sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 0 1")) { + report_prefix_pop(); + goto out; + } + + ret = sbi_debug_install_triggers(trig_max); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers trig_max"); + ret = sbi_debug_uninstall_triggers(0, (1UL << trig_max) - 1); + if (!sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 0 (1ULL << trig_max) - 1")) { + report_prefix_pop(); + goto out; + } + + /* Try to detect overrun by looking at the return value */ + report_prefix_push("overrun"); + shmem[trig_max].data.tdata1 = gen_tdata1(trig_type, VALUE_LOAD | VALUE_STORE, MODE_M); + ret = sbi_debug_install_triggers(trig_max + 1); + sbiret_report_error(&ret, SBI_ERR_BAD_RANGE, "sbi_debug_install_triggers trig_max"); + report(ret.value == 0, "value overrun check"); + shmem[trig_max].data.tdata1 = tdata1; /* restore valid */ + report_prefix_pop(); + + report_prefix_pop(); + + report_prefix_push("update triggers"); + ret = sbi_debug_update_triggers(0); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_update_triggers 0"); + ret = sbi_debug_update_triggers(trig_max + 1); + sbiret_report_error(&ret, SBI_ERR_BAD_RANGE, "sbi_debug_update_triggers 0"); + + shmem[0].data.tstate = 0; + ret = sbi_debug_update_triggers(1); + sbiret_report_error(&ret, SBI_ERR_FAILURE, "sbi_debug_update_triggers 1 not mapped"); + report(ret.value == 0, "error index 0"); + + shmem[0].data.tstate = trig_max; + ret = sbi_debug_update_triggers(1); + sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_update_triggers 1 idx == trig_max"); + report(ret.value == 0, "error index 0"); + + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 1"); + + shmem[0].data.tstate = 0; + ret = sbi_debug_update_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_update_triggers 1"); + + /* Update 2 both with same index */ + shmem[1].data.tstate = 0; + ret = sbi_debug_update_triggers(2); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_update_triggers 2"); + + shmem[0].data.tstate = 1; + ret = sbi_debug_update_triggers(1); + sbiret_report_error(&ret, SBI_ERR_FAILURE, "sbi_debug_update_triggers 1 not mapped"); + report(ret.value == 0, "error index 0"); + + shmem[0].data.tstate = 0; + shmem[1].data.tstate = 1; + ret = sbi_debug_update_triggers(2); + sbiret_report_error(&ret, SBI_ERR_FAILURE, "sbi_debug_update_triggers 2 not mapped"); + report(ret.value == 1, "error index 1"); + + shmem[0].data.tstate = 0; + shmem[0].data.tdata1 = gen_tdata1(trig_type, VALUE_LOAD, MODE_M); + ret = sbi_debug_update_triggers(1); + sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_update_triggers 1 invalid"); + report(ret.value == 0, "error index 0"); + shmem[0].data.tdata1 = tdata1; + if (trig_max > 1) { + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 1"); + report(shmem[0].data.tstate == 1, "install index 1"); + + shmem[0].data.tstate = 1; + ret = sbi_debug_update_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_update_triggers 1"); + + shmem[0].data.tstate = 0; + shmem[1].data.tstate = 1; + ret = sbi_debug_update_triggers(2); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_update_triggers 2"); + + ret = sbi_debug_uninstall_triggers(1, 1); + if (!sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 1 1")) { + report_prefix_pop(); + goto out; + } + } + ret = sbi_debug_uninstall_triggers(0, 1); + if (!sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 0 1")) { + report_prefix_pop(); + goto out; + } + + /* Try to detect overrun by looking at the return value */ + report_prefix_push("overrun"); + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers trig_max"); + + for (i = 0; i <= trig_max; i++) + shmem[trig_max].data.tstate = 0; + shmem[trig_max].data.tdata1 = gen_tdata1(trig_type, VALUE_LOAD | VALUE_STORE, MODE_M); + ret = sbi_debug_update_triggers(trig_max + 1); + sbiret_report_error(&ret, SBI_ERR_BAD_RANGE, "sbi_debug_install_triggers trig_max"); + report(ret.value == 0, "value overrun check"); + shmem[trig_max].data.tdata1 = tdata1; /* restore valid */ + + ret = sbi_debug_uninstall_triggers(0, 1); + if (!sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 0 1")) { + report_prefix_pop(); + goto out; + } + report_prefix_pop(); + + report_prefix_pop(); + + report_prefix_push("uninstall triggers"); + ret = sbi_debug_uninstall_triggers(0, 0); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 0 0"); + ret = sbi_debug_uninstall_triggers(trig_max, 0); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers trig_max 0"); + ret = sbi_debug_uninstall_triggers(0, 1); + sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_uninstall_triggers 0 1"); + ret = sbi_debug_uninstall_triggers(trig_max, 1); + sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_uninstall_triggers trig_max 1"); + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 1"); + report(shmem[0].data.tstate == 0, "install index 0"); + ret = sbi_debug_uninstall_triggers(0, 2); + sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_uninstall_triggers 0 2"); + ret = sbi_debug_uninstall_triggers(0, 3); + sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_uninstall_triggers 0 3"); + ret = sbi_debug_uninstall_triggers(0, 1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 0 1"); + if (trig_max > 1) { + ret = sbi_debug_install_triggers(2); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 2"); + report(shmem[0].data.tstate == 0, "install index 0"); + report(shmem[1].data.tstate == 1, "install index 1"); + ret = sbi_debug_uninstall_triggers(0, 1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 0 1"); + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 1"); + report(shmem[0].data.tstate == 0, "install index 0"); + ret = sbi_debug_uninstall_triggers(1, 1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 1 1"); + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 1"); + report(shmem[1].data.tstate == 1, "install index 1"); + ret = sbi_debug_uninstall_triggers(0, 2); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 0 2"); + ret = sbi_debug_install_triggers(1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 1"); + report(shmem[1].data.tstate == 1, "install index 1"); + ret = sbi_debug_uninstall_triggers(0, 3); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 0 3"); + ret = sbi_debug_install_triggers(2); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_install_triggers 2"); + report(shmem[0].data.tstate == 0, "install index 0"); + report(shmem[1].data.tstate == 1, "install index 1"); + ret = sbi_debug_uninstall_triggers(1, 1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 1 1"); + ret = sbi_debug_uninstall_triggers(0, 3); + sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_uninstall_triggers 0 3"); + ret = sbi_debug_uninstall_triggers(0, 1); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_uninstall_triggers 0 1"); + } + report_prefix_pop(); + +out: + ret = sbi_debug_set_shmem_raw(-1, -1, 0); + sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_set_shmem unset"); + + report_prefix_pop(); + + return ret; +} + static struct sbiret dbtr_test_store_install_uninstall(struct sbi_dbtr_shmem_entry *shmem, enum McontrolType type) { @@ -838,6 +1150,8 @@ void check_dbtr(void) if (!num_trigs) goto exit_test; + dbtr_test_api(num_trigs); + trig_type = dbtr_test_type(&num_trigs); if (trig_type == SBI_DBTR_TDATA1_TYPE_NONE) goto exit_test;