From patchwork Sat Apr 6 12:38:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920413 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=EaDGIe1+; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=LHG5mBUO; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZhV100nz1yYt for ; Sat, 6 Apr 2024 23:40:42 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QJqJRM62cFbLFXdywYzt3KR9c/xazA6P5K1P09VIP20=; b=EaDGIe1+H0F5ov N8BRkqWYyzasDOvzOsSepmuhb0nNX7GCT4fcrLXKgBqm9eiioepWOBWjR0HaHU9L3ifbNrPrigXAb Ihnqo6geZXOeaP0bjySKeFMHRFS663+JD37nZmYGz0Sp6oTPldTlzlEkgxIvMBPU0TAHE3KYU3LaB y5mZLBZMkHWKaferT4PijFiNZWVq2FmVLCWk5235rvb9+iDmlxEDnT/xSsv8tVlYzhypHg2waa8Qg QgLUlW+a6bOvneu/7kjyh03nN1AukOlo9GHpcx3voAOK9TWpR/HV4jW0VR1VwjFBmY/QP/pMvf15r 3TNfxPzikVvenA55ZKGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Lc-0000000AIZn-3TCL; Sat, 06 Apr 2024 12:40:40 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5La-0000000AIYj-25k7 for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:40:39 +0000 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-5cedfc32250so2416960a12.0 for ; Sat, 06 Apr 2024 05:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407238; x=1713012038; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2eRtFguiVvn3b4AxH0QU+OXVRgeLtifhqAQZ/pJYpnQ=; b=LHG5mBUOn1Mjut3bPhK7+s7PgH6lGWQYGXciM5hdtcKN0nK+HrCXt2fDhQ/1YzzU3W 0TOu0BacqY3Vv3HBbxSK2QPkU87S2gC14V1SnGqwYb0PAMtMuqIi6XSKAjK9fczCfAhB taekdbH0HF+SwvY7jkFqRa7kG7sKc054whmZCfGCythWtLdwaa2fvjCCncUdG8ZzMVjT ISOraCFBl7h9YZTdzAu8yFlEmwWQbprs/GA+DV+xn9pC8XLxZdJGh7naLcj7aWta90Y9 wF16AQLfyXNNotVOFKatCRKTupe9dla62QKgTVqjlbysAqwGJvXmKMTb29PhhueirgPW FURA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407238; x=1713012038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2eRtFguiVvn3b4AxH0QU+OXVRgeLtifhqAQZ/pJYpnQ=; b=e6GGaLcM7YCaAS8IR/Nph7PZI3nechYdRp1/5NrzK0+TkOgg5TLVEQYo1uuRBCrRC+ i5BwqFzNrB6+n2E6iELqlNxvBxIlK8IzPXr8TjNzXRU8llcuU7Cj8GdLjyCQW0yNrdbk OBjIneUGW4Iq4VX0p/hU4+b/vSS1yIkgV9M4bzgP911hVgJ0vqG4fCoR8mm14MhlVaLV 7qBuTHyJGcdklWn9FB+2ItBcoHX3ovlThZgsrkZTzYI3Fl8uHSRy79l3ORlwHsaCpEsO Xs4+VA3NmHmpYIcCvaSXFNN/VJBBzNiSlaLSDwoTNeOdS6XnMctsHUr16b3mkw0lh8Op 30jg== X-Forwarded-Encrypted: i=1; AJvYcCUmtPOk7bZhNw4VQNUxxcZcuLbQVIAkcYArneEiFqOSkg1htc5obNzZZNRdq4llCXCbB26lgwsw/6ps06AM7+x/8GPenejZnnRIWEJojw== X-Gm-Message-State: AOJu0YzHUYM3l/Wk3zOtB4OSWQ/VWgWvf2HepA7AblxBqvbpxpPp9jSr KLbzgBtGqGW0yZ+K72pVL8W+jMbDLqG2fV5pUQGL74GYpSHpFhF7 X-Google-Smtp-Source: AGHT+IFRwkbTF8lHFVWUWdHITKOoyi+cM/zQNImgd0YNfpYQL2AebNpOitSBxxkyLMi56+NDz70TCQ== X-Received: by 2002:a05:6a20:1587:b0:1a3:9fa6:74f6 with SMTP id h7-20020a056a20158700b001a39fa674f6mr4468400pzj.58.1712407237671; Sat, 06 Apr 2024 05:40:37 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.40.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:40:37 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 12/14] shellcheck: Fix SC2178 Date: Sat, 6 Apr 2024 22:38:21 +1000 Message-ID: <20240406123833.406488-13-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com> References: <20240406123833.406488-1-npiggin@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_054038_583467_55770E25 X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: SC2178 (warning): Variable was used as an array but is now assigned a string. No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- arm/efi/run | 2 +- riscv/efi/run | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:52b listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org SC2178 (warning): Variable was used as an array but is now assigned a string. No bug identified. Reviewed-by: Andrew Jones Signed-off-by: Nicholas Piggin --- arm/efi/run | 2 +- riscv/efi/run | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arm/efi/run b/arm/efi/run index cf6d34b0b..8f41fc02d 100755 --- a/arm/efi/run +++ b/arm/efi/run @@ -44,7 +44,7 @@ qemu_args=() cmd_args=() while (( "$#" )); do if [ "$1" = "-append" ]; then - cmd_args=$2 + cmd_args=("$2") shift 2 else qemu_args+=("$1") diff --git a/riscv/efi/run b/riscv/efi/run index cce068694..5a72683a6 100755 --- a/riscv/efi/run +++ b/riscv/efi/run @@ -47,7 +47,7 @@ qemu_args=() cmd_args=() while (( "$#" )); do if [ "$1" = "-append" ]; then - cmd_args=$2 + cmd_args=("$2") shift 2 else qemu_args+=("$1")