From patchwork Fri Mar 15 13:32:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jones X-Patchwork-Id: 1912541 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=jF3q49jq; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.a=rsa-sha256 header.s=google header.b=h0JBLo/G; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Tx4v11CW0z1yX0 for ; Sat, 16 Mar 2024 00:33:01 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=msG3aKy59LQL+FjMkdFp8udvcCop3by/6aSmBlc/XaA=; b=jF3q49jqaYHt+p xaarHA6jHFoJ9Te240BlY8DidlItRQvBGaThNEXKhRtClqrkdSYj/WkaY/ymFEZIuAk/nwP0Vj1ao aF0JaWqqU69qv5OyyMRfIIhnWo8g5X6RAPwOPllEovwpRSwYJMrNoed/5izFYLah1+Q2W+oLO70JN peoDjP5vr0yndiTUlJ9VHNjI3mpNZrvT8shM9jbXe382+HA/yw0Bd8NpY+Lkbhk1AqvO+X80QH4eY V80GM33nMUXKb/g3KYeqvd75G2x+jxJlHZ0K4nfQndfkoOjdk2ChZJBb8w0aOEJHu1Q/MhpNFc539 ba1Nhx2Ibbrue7uzQKJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rl7gB-00000000LBo-2TNu; Fri, 15 Mar 2024 13:32:59 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rl7g8-00000000L8w-0uBA for kvm-riscv@lists.infradead.org; Fri, 15 Mar 2024 13:32:58 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-56890b533aaso2497949a12.3 for ; Fri, 15 Mar 2024 06:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1710509573; x=1711114373; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WliWwB4pLSB4XNMK4ekBqZdJHbTrwZ95+gbfXlrKXHQ=; b=h0JBLo/G5Ql5OCgHvuKlPlXERNx6Xt/QdewcVoNAcf6g7gZ8YVsmCcrpCdJxsQAvNp t/SXAMsQM8dv0oAGPy2/fSeiCjyAYc6BA5+Q41Npe2Y0pRkcDRSIrR0iQsvne29ulU6X 8CzUwMvhN+jrnsNmfpcrn54yKjYvnht6inxZDeDWQjA1+zFerCo3cO+MBXj6tNMyqMNk WtxjCoTyXltOI61FUa72EHwnadYxPgokn0VbcVvsjHL77xiwHax10GclVqApNLq3xcSw 6ov8zMg8t92e91r3pPK5nyr0imtnuCu8S2AZVHnkiaN80LCTXbDAm35iWN+MsA8H/6R9 W8Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710509573; x=1711114373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WliWwB4pLSB4XNMK4ekBqZdJHbTrwZ95+gbfXlrKXHQ=; b=QoACCDXvABvIGn1Cb67Y2P8MQTG1CjJJYEJql1G4NPwkm9TBwFJufNPiJVmRqaI4mp 2BSFZ3x1xyrO55DOzLz/UM/7LSopBqktcDjyk4DW2xx/lyIO+R+9RTOQ83BIq3JdaDGc 8LI44B6ijajwAxDJx79yFDVegDeoBwaXs42IMHFVOzAOO/xpJrvZdp/rYu5893p3ZaUA Af//jqxY9rThjJL9/I2V8Em1zypAqnE9KHkzKw3+TmpKP09fIgXxAL0FsQRHUOdXb93S UUi8qXbWym+wMxc5lyEeWh2y8aqpEnIdqQVClCxlk2HMT8QIO2+gzmt3gG2SuRAHJsln +C8g== X-Gm-Message-State: AOJu0YwsvUbAaNbKyUnZq7qRJMVQAFGTL7yT6rk69uQ6rUlDi6AT80hV XCjX0l2edQag2meFVToMKDTs8RjgAik3NFqm14aQgxe6S0CmbfCi7ML7GzDFMhNrqYnn989FOn8 + X-Google-Smtp-Source: AGHT+IGnENnt7gxPJ+CHZzFhXfmmMw7C+fy8JI1J4a93OrrPmpFY9tkEPPC6+xLx7ww8DoIzTlFQDg== X-Received: by 2002:a05:6402:1ccd:b0:566:c167:4ac1 with SMTP id ds13-20020a0564021ccd00b00566c1674ac1mr3577775edb.26.1710509572848; Fri, 15 Mar 2024 06:32:52 -0700 (PDT) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id g19-20020aa7c593000000b005689a4b250fsm1745457edq.48.2024.03.15.06.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 06:32:52 -0700 (PDT) From: Andrew Jones To: kvm-riscv@lists.infradead.org, tech-prs@lists.riscv.org Cc: cmaiolino@redhat.com, bsd@redhat.com Subject: [kvm-unit-tests PATCH 1/2] riscv: sbi: Check and test spec version Date: Fri, 15 Mar 2024 14:32:46 +0100 Message-ID: <20240315133244.579425-5-ajones@ventanamicro.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240315133244.579425-4-ajones@ventanamicro.com> References: <20240315133244.579425-4-ajones@ventanamicro.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240315_063256_562869_51E77C10 X-CRM114-Status: UNSURE ( 8.98 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The base extension tests are only valid for spec versions 0.2 and later, so ensure we have that before proceeding. Also check the spec version matches an expected value, as we do the other functions. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:52d listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The base extension tests are only valid for spec versions 0.2 and later, so ensure we have that before proceeding. Also check the spec version matches an expected value, as we do the other functions. Signed-off-by: Andrew Jones Reviewed-by: Carlos Maiolino --- riscv/sbi.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/riscv/sbi.c b/riscv/sbi.c index cd36290ce11e..707ce8dd1c57 100644 --- a/riscv/sbi.c +++ b/riscv/sbi.c @@ -50,6 +50,19 @@ static void check_base(void) report_prefix_push("base"); + ret = __base_sbi_ecall(SBI_EXT_BASE_GET_SPEC_VERSION, 0); + if (ret.error || ret.value < 2) { + report_skip("SBI spec version 0.2 or higher required"); + return; + } + + report_prefix_push("spec_version"); + if (env_or_skip("SPEC_VERSION")) { + expected = strtol(getenv("SPEC_VERSION"), NULL, 0); + gen_report(&ret, 0, expected); + } + report_prefix_pop(); + report_prefix_push("impl_id"); if (env_or_skip("IMPL_ID")) { expected = strtol(getenv("IMPL_ID"), NULL, 0);