From patchwork Sat Apr 6 12:38:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1920401 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=LBzXH/AV; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Ke65twI7; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZfY02Jxz1yYf for ; Sat, 6 Apr 2024 23:38:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/lFUr9M0p0WsbzpZIRbFzGt+wXhjkMKg03vISuTGXcQ=; b=LBzXH/AVgzVDuc r06BKqGkJbzgDtO5hYd81PGNo8LFFiWi4Ne7nF9WTfmQchIpJn/LUAEjLuZPNHi6SZ10voEHB+9D9 1dX5894Ys/n9l2grbNbpiOQfhzDDzpyiHiWc+E/Nl1JWpBmp/RobRU2BXPGxZ0vqG6iZcz/uQRwxu FGssNLhgZob5aAxYUMUt16JkWK0EWuY00vCpZqpcUzFL4QWF1LTAaDGTLZB2G96K1lwUZ5eAdtVtJ zMJEPOGpyFWhqoDHKREQI0g0OcllJOG8ndyVktAq0S+vQ++w3h4UXx4zevn7sm9E9tPpwYlhrK0/Y 1cbtfN9oiaaWeEGFA88Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Jv-0000000AI0f-3w8Q; Sat, 06 Apr 2024 12:38:55 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rt5Js-0000000AHzz-33Hv for kvm-riscv@lists.infradead.org; Sat, 06 Apr 2024 12:38:54 +0000 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-5cfd95130c6so2202933a12.1 for ; Sat, 06 Apr 2024 05:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712407131; x=1713011931; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7w2kaMdOJquHBKIGt0eh7rBKhuP+nEorD/7bYdg9VOI=; b=Ke65twI7b6FcyV9K1JmPZMuz0tMJozTQG6Q2drQxha1Np6J6NzQnaqAUG3WKN7hUj0 gHzgO1hSsDuo6SLzFnv/gt/1apTtFWyaJwbgWz8jb8DeBACmZirniCJECMYdUNQHs+96 XIVkkulYe69ak6Q8Bc5eodcEhwWEW/INEr73Ayzf/3OPDYQYtRKkfMyZSec8ExQkX6uA umFrSVKKqFniLgaUsewYkQI6n0/O/IefikYvvquRiXucudb7lbmlqUDUiRbZSKPjhVWx qrQZA/XFAtInEXwbHVT9D1jbVxrOKjn6YT46BmyW87nsmgxc0yhqaktkimSncegWYuXJ eJLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712407131; x=1713011931; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7w2kaMdOJquHBKIGt0eh7rBKhuP+nEorD/7bYdg9VOI=; b=SZqQDRlN5BWWmqTbBXLuDva5vwnZ197HZh0aMks3QpB3tjjGfbcD2eNIbJTRU6AGD6 ldmOIlcM98VVu0ebLAzA94TOEWoLeKicHMlNga7HUfd3xYyHD80mI+qV05CaVPVWapVr C6iklTvNAQVmwF8ROQRTNquNb2yUiHp+QEHD8z3rBKO+4zy2GNCQ3kU8KgPrl2cMyHmb KFJp0qO532Cz/Nq/oqlfsYxs755mWTNE+OW/8ELSU3AR+3VtH+T+ijvm0v+Kar7dybTD jakst7tu2Rwy0/fbNfkBszNEMU+T9kXTCqDmdZ2Bl1QqqOyvz/8StKxVcduaBF3HS88J DyVw== X-Forwarded-Encrypted: i=1; AJvYcCWPel8Y5pY+/iUIsw7IdtqvT2CrdJhAdEYcE84i5dicQGuDjdm80IE607fpZAHVW12pobKuoCyXlxZUEOTGA2xe4wK/qiy9Pq6mIxRMqw== X-Gm-Message-State: AOJu0YwNSQaklb8KczTniAc27bR/Df++uHdg6N0ALDGfmWt+2lUe+GIU k9+zf/AdradjgtMu1ZfBFy+6tOk2CBjCw6H6pNIHGZEUnnuj5eY/ X-Google-Smtp-Source: AGHT+IH4r6r9YbNAgX9HgtfYp0aid5yQ4Qc22A3fJ45yWlgo2AyKwwzLl2pM3GDnNTbmVtMVsPs95w== X-Received: by 2002:a05:6a20:4324:b0:1a7:5103:5520 with SMTP id h36-20020a056a20432400b001a751035520mr1027830pzk.43.1712407131082; Sat, 06 Apr 2024 05:38:51 -0700 (PDT) Received: from wheely.local0.net (124-169-104-130.tpgi.com.au. [124.169.104.130]) by smtp.gmail.com with ESMTPSA id nt5-20020a17090b248500b002a279a86e7asm5050576pjb.7.2024.04.06.05.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 05:38:50 -0700 (PDT) From: Nicholas Piggin To: Andrew Jones Cc: Nicholas Piggin , Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , =?utf-8?q?Nico_B=C3=B6hr?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: [RFC kvm-unit-tests PATCH v2 00/14] add shellcheck support Date: Sat, 6 Apr 2024 22:38:09 +1000 Message-ID: <20240406123833.406488-1-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240406_053852_963300_3CE37834 X-CRM114-Status: GOOD ( 11.24 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tree here https://gitlab.com/npiggin/kvm-unit-tests/-/tree/shellcheck Again on top of the "v8 migration, powerpc improvements" series. I don't plan to rebase the other way around since it's a lot of work. So this is still in RFC until the other big series gets merged. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [npiggin(at)gmail.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:536 listed in] [list.dnswl.org] X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Tree here https://gitlab.com/npiggin/kvm-unit-tests/-/tree/shellcheck Again on top of the "v8 migration, powerpc improvements" series. I don't plan to rebase the other way around since it's a lot of work. So this is still in RFC until the other big series gets merged. Thanks to Andrew for a lot of review. A submitted the likely s390x bugs separately ahead of this series, and also disabled one of the tests and dropped its fix patch as-per review comments. Hence 3 fewer patches. Other than that, since last post: * Tidied commit messages and added some of Andrew's comments. * Removed the "SC2034 unused variable" blanket disable, and just suppressed the config.mak and a couple of other warnings. * Blanket disabled "SC2235 Use { ..; } instead of (..)" and dropped the fix for it. * Change warning suppression comments as per Andrew's review, also mention in the new unittests doc about the "check =" option not allowing whitespace etc in the name since we don't cope with that. Thanks, Nick Nicholas Piggin (14): Add initial shellcheck checking shellcheck: Fix SC2223 shellcheck: Fix SC2295 shellcheck: Fix SC2094 shellcheck: Fix SC2006 shellcheck: Fix SC2155 shellcheck: Fix SC2143 shellcheck: Fix SC2013 shellcheck: Fix SC2145 shellcheck: Fix SC2124 shellcheck: Fix SC2294 shellcheck: Fix SC2178 shellcheck: Fix SC2048 shellcheck: Suppress various messages .shellcheckrc | 30 ++++++++++++++++++++++++ Makefile | 4 ++++ README.md | 3 +++ arm/efi/run | 4 ++-- configure | 2 ++ riscv/efi/run | 4 ++-- run_tests.sh | 11 +++++---- scripts/arch-run.bash | 52 ++++++++++++++++++++++++++++++----------- scripts/common.bash | 5 +++- scripts/mkstandalone.sh | 4 +++- scripts/runtime.bash | 14 +++++++---- 11 files changed, 105 insertions(+), 28 deletions(-) create mode 100644 .shellcheckrc