From patchwork Fri Jan 20 18:24:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 717871 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v4q0H6jCMz9t1T for ; Sat, 21 Jan 2017 05:26:07 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592AbdATS0F (ORCPT ); Fri, 20 Jan 2017 13:26:05 -0500 Received: from mout.web.de ([212.227.15.3]:56457 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbdATS0D (ORCPT ); Fri, 20 Jan 2017 13:26:03 -0500 Received: from [192.168.1.2] ([77.182.231.71]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lechi-1cBYO12fwU-00qUIo; Fri, 20 Jan 2017 19:25:04 +0100 Subject: [PATCH 06/11] KVM: PPC: Book3S HV: Use kcalloc() in kvmppc_alloc_host_rm_ops() To: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Alexander Graf , Benjamin Herrenschmidt , Michael Ellerman , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <62a8df66-ab16-8f93-8acd-20fb461fd7de@users.sourceforge.net> Date: Fri, 20 Jan 2017 19:24:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K0:MJA0+S8cD/Rk/q2gv06ZFP379IeDyqJi772dDXxoL+DLCkR4R/Z Xxd051xwxRFBr0alNfAdursLHH458QEfoWP50f13RfXklihKUu8/5qn8FJYKrmF1BLr/fJZ GE0Krz2uW2y+LQHCWMaRlsFbCUCrvqLs9UZesO1kPHOakT78DHQm6oxb08xd0jCgHjR2og+ 8XRurVJzClUkksoSvJE5A== X-UI-Out-Filterresults: notjunk:1; V01:K0:78M9beV6PH8=:c5RxgowFAK5xvh2FnSbqzY Gb+cE3bVFRJtTg6rLcJp79Tu0pbPBUMQNBGOZhYzrKOc1lN7u7JQK2aVeNnaFYUxgtp4ke+tI BKgvdIlCVeXeGiuY9Fp/ZTIWvscDWpKIZYkPA0Vbqcfegt2BcMZF+zn8279tA4pLA0x5SVqFA l4gcF0y9WTDXPe/VjE75GEt8vLa/SRpWepgLdd8eHpqvQ8wg8aSc1NEnP1dS6VV6uy+c9ijKh TugnxsYuT/lkKxaGzNViNsy0NrwhCncOq+9/t/x0iUn34FT7zumrUYXOISggHMTS/Ih1b6J4M TEuh6LLC/cZcslIiCJYQdtVpHOUngVgyvL9Ci/dXwj4ASZ9D3567uH6xnsfwAtnyncdz7bObh G3jO8TSrHy7y79x3H5Kv3r8NibeFIwG8rar7iSv/8X7Cg3iOC0ZwJyCQ0O3i1m6lMTVTWLdLA n9q2ou1cMcWv7/T6rX0xkOKMnZuguwy9CKHI64H4QTkc25qNN8N59GYos37kK2YRG1ir2eBvI meEPoEO2dp7sKv07f/8V6C9rH6XfBttXpTNmejcy/FH9VeDaflP1WBtSvB4Nx2rs+lm/9xjk8 s2DX/WaVpD8KtYfgxYAJOMdDg8yNpaMmMp4dQNPUgraTrLMq745+nutEaso6BBQDCRk39eIl8 1l1NBfJSkd5hGNX7DTUDejtz34fExX3f0FbKTwCsUuJxTrF88I5Yz1fFIbViE/h1uY+302Ny3 YG4TUcsz4a+CinS5TlmI7pan904QXpL2rTDHyFw+VKgs/yPun4UBfYyRh0T3YhdN/btpOolI4 /jMzAX/ Sender: kvm-ppc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm-ppc@vger.kernel.org From: Markus Elfring Date: Fri, 20 Jan 2017 16:20:43 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Delete the local variable "size" which became unnecessary with this refactoring. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/powerpc/kvm/book3s_hv.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c index 3122998f6a32..596201b3f22e 100644 --- a/arch/powerpc/kvm/book3s_hv.c +++ b/arch/powerpc/kvm/book3s_hv.c @@ -3199,7 +3199,6 @@ void kvmppc_alloc_host_rm_ops(void) struct kvmppc_host_rm_ops *ops; unsigned long l_ops; int cpu, core; - int size; /* Not the first time here ? */ if (kvmppc_host_rm_ops_hv) @@ -3209,9 +3208,9 @@ void kvmppc_alloc_host_rm_ops(void) if (!ops) return; - size = cpu_nr_cores() * sizeof(struct kvmppc_host_rm_core); - ops->rm_core = kzalloc(size, GFP_KERNEL); - + ops->rm_core = kcalloc(cpu_nr_cores(), + sizeof(*ops->rm_core), + GFP_KERNEL); if (!ops->rm_core) { kfree(ops); return;